Skip to contentSkip to conversation

2 bugs found in Cisco vpnclient-4.8.02.0030

PATCH Denis Joseph Barrow 1 participant 1 message Sep 9, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Tamas,
I've got the vpn client going over ethernet but not yet over the hso device. I found 2 idiotic substantial bugs in the vpn client one which caused the crash in linuxcniapi.c as you were seeing
You'll note that in some places the code was looping to <MAX_INTERFACES & other places to <=MAX_INTERFACES, this was flying over the edge of the array.
These bugs are not unique to the hso driver they just happened to manifest there.

Let me know if you still find crashes somehow, post them to me & more importantly let me know if you get hso going over vpn.

Please find some way to get the bugfixes back to Cisco.

Signature · 2 lines
best regards,
D.J. Barrow
vpnclient-4.8.02.0030/interceptor.c +1 -1
@@ -502,7 +502,7 @@
 {
     int i;
     
-    for (i=0; i <= MAX_INTERFACES; i++)
+    for (i=0; i < MAX_INTERFACES; i++)
     {
         BINDING *b = &Bindings[i];
         if (b->pDevice && (dev->ifindex == b->pDevice->ifindex))
vpnclient-4.8.02.0030/linuxcniapi.c +1 -1
@@ -577,7 +577,7 @@
 {
     int i;
     
-    for (i=0; i <= MAX_INTERFACES; i++)
+    for (i=0; i < MAX_INTERFACES; i++)
     {
         BINDING *b = &Bindings[i];
         if (b->pDevice && (iIndex == b->pDevice->ifindex))