TARGET_CPUS in assign_irq_vector
On x86-64, the genapic implementations of target_cpus returns cpu_online_map. What if more cpus have yet to come online? Shouldn't it be cpu_possible_map?
Though I'm probably confused. I don't really know what the intent of target_cpus and vector_allocation_domain is.
Thanks,
J
Quoted 7 lines · Jeremy Fitzhardinge
On x86-64, the genapic implementations of
target_cpusreturnscpu_online_map. What if more cpus have yet to come online? Shouldn't it becpu_possible_map?Though I'm probably confused. I don't really know what the intent of
target_cpusandvector_allocation_domainis.
logical mode, vector_allocation_domain will return all online cpus aka the 8 cpus.
phys_flat mode, vector_allotcation_domain will only the cpumask with the cpu set..
target_cpus is the cpus that could be possible to used to take vector and process that irq. so at least it should be online.
YH
Quoted 3 lines · Yinghai Lu
target_cpusis the cpus that could be possible to used to take vector and process that irq. so at least it should be online.
Would it be wrong to make it possible_cpu_mask?
J
Quoted 7 lines · Jeremy Fitzhardinge
Quoted 3 lines · Yinghai Lu
target_cpusis the cpus that could be possible to used to take vector and process that irq. so at least it should be online.Would it be wrong to make it
possible_cpu_mask?
it is wrong
YH
Quoted 4 lines · Yinghai Lu
Quoted 2 lines · Jeremy Fitzhardinge
Yinghai Lu wrote:
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
target_cpusis the cpus that could be possible to used to take vector and process that irq. so at least it should be online.Would it be wrong to make it
possible_cpu_mask?it is wrong
What happens if you online a new cpu and migrate the irq to it? Does it get allocated a new vector?
I'm using create_irq() as a general irq and vector allocation mechanism for Xen interrupts. I'd like to be able to allocate a vector across all possible cpus so I can bind Xen event channels to vectors. Should I: 1) add a create_irq_cpus() which takes a cpu mask rather than defaulting to TARGET_CPUS, 2) modify struct genapic to insert by own target_cpus(),
3) give up because the idea is fundamentally ill-conceived, or 4) something else?
Thanks,
J
Quoted 9 lines · Jeremy Fitzhardinge
Quoted 8 lines · Yinghai Lu
Quoted 6 lines · Jeremy Fitzhardinge
Quoted 4 lines · Yinghai Lu
target_cpusis the cpus that could be possible to used to take vector and process that irq. so at least it should be online.
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
Would it be wrong to make it
possible_cpu_mask?it is wrong
What happens if you online a new cpu and migrate the irq to it? Does it get allocated a new vector?
for phys_flat mode: it will get new vector for on new cpu.
Quoted 8 lines
I'm using
create_irq()as a general irq and vector allocation mechanism for Xen interrupts. I'd like to be able to allocate a vector across all possible cpus so I can bind Xen event channels to vectors. Should I: 1) add acreate_irq_cpus()which takes a cpu mask rather than defaulting toTARGET_CPUS, 2) modify struct genapic to insert by owntarget_cpus(),
3) give up because the idea is fundamentally ill-conceived, or 4) something else?
seems need to rework __assign_irq_vector a little bit.
tocpumask_t (*vector_allocation_domain_t)(int cpu) static int __assign_irq_vector(int irq, cpumask_t mask, vector_allocation_domain_t p)
...
and you could have your own
static cpumask_t vec_domain_alloc(int cpu)
{
cpumask_t domain = cpu_possible_map;
return domain;
}static int assign_irq_vector_all(int irq)
{
int err;
unsigned long flags;
cpumask_t mask = cpu_possible_map;
spin_lock_irqsave(&vector_lock, flags);
err = __assign_irq_vector(irq, mask, vec_domain_alloc);
spin_unlock_irqrestore(&vector_lock, flags);
return err;
}YH
Quoted 2 lines · Jeremy Fitzhardinge
3) give up because the idea is fundamentally ill-conceived, or 4) something else?
Yes.
When working with event channels you should not have any truck with vectors and you should not call the architecture specific do_IRQ().
Eric
Quoted 7 lines · Eric W. Biederman
Quoted 3 lines · Jeremy Fitzhardinge
3) give up because the idea is fundamentally ill-conceived, or 4) something else?
Quoted 5 lines
Yes.
When working with event channels you should not have any truck with vectors and you should not call the architecture specific
do_IRQ().
Hm. That would work OK for fully paravirtualized domains, which have no direct access to real hardware in any form (well, there's pci passthough, but interrupts are all thoroughly massaged into event channels).
But for dom0, the kernel handles interrupts weird hybrid mode. The interrupts themselves are delivered via event channels rather than via a local apic, but the IO APIC is still under the kernel's control, and is responsible for poking (Xen-allocated) vectors into it. This only applies to physical irq event channels; there's no need to have vectors for purely software event channels like interdomain, IPI and timers. This is further complicated by the fact that the dom0 kernel parses the ACPI and MPTABLES to find out about IO APICs, so the existing APIC subsystem is already involved. I need to work out how'd I'd hook all this together with a minimum of mess.
J
Quoted 4 lines · Jeremy Fitzhardinge
Hm. That would work OK for fully paravirtualized domains, which have no direct access to real hardware in any form (well, there's pci passthough, but interrupts are all thoroughly massaged into event channels).
Quoted 10 lines
But for dom0, the kernel handles interrupts weird hybrid mode. The interrupts themselves are delivered via event channels rather than via a local apic, but the IO APIC is still under the kernel's control, and is responsible for poking (Xen-allocated) vectors into it. This only applies to physical irq event channels; there's no need to have vectors for purely software event channels like interdomain, IPI and timers. This is further complicated by the fact that the dom0 kernel parses the ACPI and MPTABLES to find out about IO APICs, so the existing APIC subsystem is already involved. I need to work out how'd I'd hook all this together with a minimum of mess.
In that case. Having the information on the event channel tell you which cpu and which vector were received is sufficient. Then you can call into do_IRQ() with the information. Unless ack_irq() and friends are enough different at the local apic level to cause a challenge.
For the reset of the event channel interrupts you simply want to dispatch the irq directly.
Eric