tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27
Hi,
is it possible to push tpm-correct-tpm-timeouts-to-jiffies-conversion.patch (the patch header follows) into 2.6.27, please?
From: Marcin Obara <[email protected]>
This patch fixes timeouts conversion to jiffies, by replacing msecs_to_jiffies() calls with usecs_to_jiffies(). According to TCG TPM Specification Version 1.2 Revision 103 (pages 166, 167) TPM timeouts and durations are returned in microseconds (usec) not in miliseconds (msec).
Quoted 5 lines · On Thu, 11 Sep 2008 00:11:37 +0200 Jiri Slaby <[email protected]> wrote:
Hi,
is it possible to push tpm-correct-tpm-timeouts-to-jiffies-conversion.patch (the patch header follows) into 2.6.27, please?
Sure.
Quoted 11 lines
From: Marcin Obara <[email protected]>
This patch fixes timeouts conversion to jiffies, by replacing
msecs_to_jiffies()calls withusecs_to_jiffies(). According to TCG TPM Specification Version 1.2 Revision 103 (pages 166, 167) TPM timeouts and durations are returned in microseconds (usec) not in miliseconds (msec).Signed-off-by Marcin Obara <[email protected]>Cc Marcel Selhorst <[email protected]>Cc Kylene Jo Hall <[email protected]>Signed-off-by Andrew Morton <[email protected]>
Why? I wasn't aware that this fixed anything which anyone had observed (pokes tongue out at the changelog).
2008/9/11 Andrew Morton <[email protected]>:
Quoted 18 lines
Quoted 5 lines · On Thu, 11 Sep 2008 00:11:37 +0200 Jiri Slaby <[email protected]> wrote:
Hi,
is it possible to push tpm-correct-tpm-timeouts-to-jiffies-conversion.patch (the patch header follows) into 2.6.27, please?
Sure.
Quoted 7 lines
From: Marcin Obara <[email protected]>
This patch fixes timeouts conversion to jiffies, by replacing
msecs_to_jiffies()calls withusecs_to_jiffies(). According to TCG TPM Specification Version 1.2 Revision 103 (pages 166, 167) TPM timeouts and durations are returned in microseconds (usec) not in miliseconds (msec).
Quoted 8 lines
Quoted 4 lines
Signed-off-by Marcin Obara <[email protected]>Cc Marcel Selhorst <[email protected]>Cc Kylene Jo Hall <[email protected]>Signed-off-by Andrew Morton <[email protected]>Why? I wasn't aware that this fixed anything which anyone had observed (pokes tongue out at the changelog).
This fixes i.e.: long hang while loading TPM driver, if TPM chip starts in "Idle" state instead of "Ready" state. Without this patch - 'modprobe' may hang for 30 seconds or more. Please, push this patch into 2.6.27.
Marcin
Quoted 8 lines · Marcin Obara
Quoted 3 lines
Why? I wasn't aware that this fixed anything which anyone had observed (pokes tongue out at the changelog).
This fixes i.e.: long hang while loading TPM driver, if TPM chip starts in "Idle" state instead of "Ready" state. Without this patch - 'modprobe' may hang for 30 seconds or more. Please, push this patch into 2.6.27.
I personally don't care whether this goes into .27 or waits till .28. However, I *would* appreciate it if we make sure that whenever it goes go upstream, we also send tpm-work-around-bug-in-broadcom-bcm0102-chipset.patch at the same time.
I have to admit that it's not exactly confidence inspiring - if the Broadcom chip gets timeout units wrong, what *other* issues lurk in its silicon? It's bad enough when you find bugs in a RAID chipset or mouse hardware - it's even worse when it's a security chip.. ;)
Quoted 16 lines · On Thu, 11 Sep 2008 23:10:08 -0400 [email protected] wrote:
Quoted 8 lines · Marcin Obara
Quoted 3 lines
Why? I wasn't aware that this fixed anything which anyone had observed (pokes tongue out at the changelog).
This fixes i.e.: long hang while loading TPM driver, if TPM chip starts in "Idle" state instead of "Ready" state. Without this patch - 'modprobe' may hang for 30 seconds or more. Please, push this patch into 2.6.27.
I personally don't care whether this goes into .27 or waits till .28. However, I *would* appreciate it if we make sure that whenever it goes go upstream, we also send tpm-work-around-bug-in-broadcom-bcm0102-chipset.patch at the same time.
Quoted 5 lines
I have to admit that it's not exactly confidence inspiring - if the Broadcom chip gets timeout units wrong, what *other* issues lurk in its silicon? It's bad enough when you find bugs in a RAID chipset or mouse hardware - it's even worse when it's a security chip.. ;)
hm, it's rather a lot of patching just to fix a once-off 30-second pause. On second thoughts, let's do it all in 2.6.28.