physmap.c: Check return of platform_device_register()
PATCH 1/3 physmap.c: Check return of platform_device_register()
The PHYSMAP_COMPAT code had been ignoring the return value of platform_device_register() in the physmap_init() function.
--- drivers/mtd/maps/physmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/maps/physmap.c +1 -1
@@ -312,7 +312,7 @@ static int __init physmap_init(void) err =platform_driver_register (&physmap_flash_driver);#ifdef PHYSMAP_COMPAT if (err ==0 ) -platform_device_register (&physmap_flash); + err =platform_device_register (&physmap_flash);#endif return err;
Signature · 1 line
1.5.4.1
Quoted 13 lines · Zev Weiss
The
PHYSMAP_COMPATcode had been ignoring the return value ofplatform_device_register()in thephysmap_init()function.Signed-off-by Zev Weiss <[email protected]>--- drivers/mtd/maps/physmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/mtd/maps/physmap.c +0
-0
drivers/mtd/maps/physmap.c static int __init physmap_init(void) · line 316
Quoted 6 lines
drivers/mtd/maps/physmap.c +1
-1@@ -312,7 +312,7 @@ static int __init physmap_init(void) err =platform_driver_register (&physmap_flash_driver);#ifdef PHYSMAP_COMPAT if (err ==0 ) -platform_device_register (&physmap_flash); + err =platform_device_register (&physmap_flash);#endif
I don't think you want the registration of the physmap driver to fail if the compat platform device fails to register.
One reason that the compat platform device can fail to register can be that there is already a non-compat platform device for the compat flash chip, and in that case I don't think you want to fail the driver init (while leaving the physmap_flash_driver registered, too!).
Quoted 25 lines · Lennert Buytenhek
Quoted 13 lines · Zev Weiss
The
PHYSMAP_COMPATcode had been ignoring the return value ofplatform_device_register()in thephysmap_init()function.Signed-off-by Zev Weiss <[email protected]>--- drivers/mtd/maps/physmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/mtd/maps/physmap.c +0
-0drivers/mtd/maps/physmap.c static int __init physmap_init(void) · line 316
Quoted 6 lines
drivers/mtd/maps/physmap.c +1
-1@@ -312,7 +312,7 @@ static int __init physmap_init(void) err =platform_driver_register (&physmap_flash_driver);#ifdef PHYSMAP_COMPAT if (err ==0 ) -platform_device_register (&physmap_flash); + err =platform_device_register (&physmap_flash);#endif I don't think you want the registration of the physmap driver to fail if the compat platform device fails to register.
Quoted 5 lines
One reason that the compat platform device can fail to register can be that there is already a non-compat platform device for the compat flash chip, and in that case I don't think you want to fail the driver init (while leaving the
physmap_flash_driverregistered, too!).
Chalk another one up to ignorance on my part...sounds like a nak all 'round.
Quoted 13 lines · On Fri, 12 Sep 2008 23:32:58 -0700 Zev Weiss <[email protected]> wrote:
The
PHYSMAP_COMPATcode had been ignoring the return value ofplatform_device_register()in thephysmap_init()function.Signed-off-by Zev Weiss <[email protected]>--- drivers/mtd/maps/physmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/mtd/maps/physmap.c +0
-0
drivers/mtd/maps/physmap.c static int __init physmap_init(void) · line 318
Quoted 8 lines
drivers/mtd/maps/physmap.c +1
-1@@ -312,7 +312,7 @@ static int __init physmap_init(void) err =platform_driver_register (&physmap_flash_driver);#ifdef PHYSMAP_COMPAT if (err ==0 ) -platform_device_register (&physmap_flash); + err =platform_device_register (&physmap_flash);#endif return err;
Your email client is performing space-stuffing, thus making the patches unapplyable.
Presumably we should run platform_driver_unregister() if the platform_device_register() failed.
Hello.
Quoted 4 lines · Andrew Morton
Quoted 4 lines
The
PHYSMAP_COMPATcode had been ignoring the return value ofplatform_device_register()in thephysmap_init()function.Signed-off-by Zev Weiss <[email protected]>
[...]
Quoted 12 lines
Quoted 12 lines
drivers/mtd/maps/physmap.c +1
-1@@ -312,7 +312,7 @@ static int __init physmap_init(void) err =platform_driver_register (&physmap_flash_driver);#ifdef PHYSMAP_COMPAT if (err ==0 ) -platform_device_register (&physmap_flash); + err =platform_device_register (&physmap_flash);#endif
Quoted 4 lines
drivers/mtd/maps/physmap.c static int __init physmap_init(void) · line 318
Quoted 1 line
drivers/mtd/maps/physmap.c +0
-0return err;Your email client is performing space-stuffing, thus making the patches unapplyable.
Er... are you sure? The patch looks alright tab wise, even after quoting...
Quoted 2 lines
Presumably we should run
platform_driver_unregister()if theplatform_device_register()failed.
Why is that? There could be "normal" platform devices out there...
WBR, Sergei
Quoted 20 lines · I just
Quoted 4 lines
Quoted 4 lines
The
PHYSMAP_COMPATcode had been ignoring the return value ofplatform_device_register()in thephysmap_init()function.Signed-off-by Zev Weiss <[email protected]>[...]
Quoted 13 lines
Quoted 13 lines
drivers/mtd/maps/physmap.c +1
-1@@ -312,7 +312,7 @@ static int __init physmap_init(void) err =platform_driver_register (&physmap_flash_driver);#ifdef PHYSMAP_COMPAT if (err ==0 ) -platform_device_register (&physmap_flash); + err =platform_device_register (&physmap_flash);#endif return err;
[...]
Quoted 4 lines
Quoted 2 lines
Presumably we should run
platform_driver_unregister()if theplatform_device_register()failed.Why is that? There could be "normal" platform devices out there...
With that said, the patch is pointless (as already noted by Lennert).
WBR, Sergei