Skip to contentSkip to conversation

drivers/net/mlx4/alloc.c needs mm.h

PATCH Applied [email protected] 3 participants 3 messages Sep 5, 2008 – Sep 13, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 4/6 drivers/net/mlx4/alloc.c needs mm.h

From: Andrew Morton <[email protected]>

sparc32 allmodconfig with linux-next:

drivers/net/mlx4/alloc.c: In function 'mlx4_buf_alloc':
drivers/net/mlx4/alloc.c:164: error: 'PAGE_KERNEL' undeclared (first use in this function) drivers/net/mlx4/alloc.c:164: error: (Each undeclared identifier is reported only once drivers/net/mlx4/alloc.c:164: error: for each function it appears in.)

this is due to some header shuffle in linux-next. I didn't look to see what it was. I'd sugges that this patch be merged ahead of a linux-next merge to avoid bisection breaks.

We strictly only need asm/pgtable.h, but going direct to asm includes always seems grubby.

Cc Jeff Garzik <[email protected]>
Cc "David S. Miller" <[email protected]>

---

 drivers/net/mlx4/alloc.c |    1 +
 1 file changed, 1 insertion(+)
drivers/net/mlx4/alloc.c renamed from drivers/net/mlx4/alloc.c~drivers-net-mlx4-allocc-needs-mmh +1 -0
diff -puN drivers/net/mlx4/alloc.c~drivers-net-mlx4-allocc-needs-mmh drivers/net/mlx4/alloc.c
@@ -33,6 +33,7 @@
 
 #include <linux/errno.h>
 #include <linux/slab.h>
+#include <linux/mm.h>
 #include <linux/bitmap.h>
 #include <linux/dma-mapping.h>
 #include <linux/vmalloc.h>

_

#1 lore raw
Quoted 3 lines

drivers/net/mlx4/alloc.c:164: error: 'PAGE_KERNEL' undeclared (first use in this function)

+#include <linux/mm.h>

Looks like a good fix to me.

- R.

Applied
#2 lore raw
In reply to [email protected]
Quoted 16 lines · [email protected] wrote:

From: Andrew Morton <[email protected]>

sparc32 allmodconfig with linux-next:

drivers/net/mlx4/alloc.c: In function 'mlx4_buf_alloc':
drivers/net/mlx4/alloc.c:164: error: 'PAGE_KERNEL' undeclared (first use in this function) drivers/net/mlx4/alloc.c:164: error: (Each undeclared identifier is reported only once drivers/net/mlx4/alloc.c:164: error: for each function it appears in.)

this is due to some header shuffle in linux-next. I didn't look to see what it was. I'd sugges that this patch be merged ahead of a linux-next merge to avoid bisection breaks.

We strictly only need asm/pgtable.h, but going direct to asm includes always seems grubby.

Quoted 7 lines
Cc Jeff Garzik <[email protected]>
Cc "David S. Miller" <[email protected]>

---

 drivers/net/mlx4/alloc.c |    1 +
 1 file changed, 1 insertion(+)

applied