bluez-gnome: how to turn adapter off?

DISCUSSION Stefan Seyfried 3 participants 9 messages Sep 29, 2008 – Sep 30, 2008 Bluetooth drivers

Share & tools

Stefan Seyfried

author

2008-09-29 15:59 UTC #0 lore raw

Hi,

I now got several bugreports from people searching for the button to turn their bluetooth device off in the bluetooth-applet. I seem to remember that there was the setting "off" (in addition to "Hidden", "Always visible", "Temporary visible") in previous versions. So what's the rationale for removing it (users seem to expect to find it there)? And if I remember
incorrectly: could we place such a button there?

Thanks,

Stefan

Signature · 6 lines

Stefan Seyfried
R&D Team Mobile Devices            |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)

Bastien Nocera

2008-09-29 16:05 UTC #1 lore raw

Quoted 8 lines · Stefan Seyfried

Hi,
I now got several bugreports from people searching for the button to turn their bluetooth device off in the bluetooth-applet. I seem to remember that there was the setting "off" (in addition to "Hidden", "Always visible", "Temporary visible") in previous versions. So what's the rationale for removing it (users seem to expect to find it there)? And if I remember
incorrectly: could we place such a button there?

There was never an "off" switch. There was:
- Other devices can connect
- Visible and connectable for other devices
- Limited discoverable and connectable

The last 2 were folded into a single option.

Stefan Seyfried

author

2008-09-29 16:20 UTC #2 lore raw

Quoted 10 lines · Bastien Nocera

Quoted 8 lines · Stefan Seyfried
Hi,
I now got several bugreports from people searching for the button to turn their bluetooth device off in the bluetooth-applet. I seem to remember that there was the setting "off" (in addition to "Hidden", "Always visible", "Temporary visible") in previous versions. So what's the rationale for removing it (users seem to expect to find it there)? And if I remember
incorrectly: could we place such a button there?

Quoted 6 lines

There was never an "off" switch. There was:
- Other devices can connect
- Visible and connectable for other devices
- Limited discoverable and connectable
The last 2 were folded into a single option.

Ok, so I remembered wrong ;-) How about adding a "disable this adapter" option? Would a patch that implements this be welcome?

Signature · 6 lines

Stefan Seyfried
R&D Team Mobile Devices            |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)

Bastien Nocera

2008-09-29 20:39 UTC #3 lore raw

On Mon, 2008-09-29 at 18:20 +0200, Stefan Seyfried wrote:
<snip>

Quoted 2 lines

Ok, so I remembered wrong ;-) How about adding a "disable this adapter" option? Would a patch that implements this be welcome?

I'd like a patch implementing HAL killswitching. DannyK can explain to you how that's supposed to work.

I saw this as a single toggle menu item in the right-click, allowing you to enable/disable the main Bluetooth adapter on laptops. If there's a killswitch present, and there's 0 or 1 adapter (and the adapter matches the expected device) then the Bluetooth icon would shown grayed out.

This would probably also require more work like this:
<match key="@info.parent:system.product" contains="VGN-S1XP">
<merge key="killswitch.expected_usb_vendor_id"
type="int">0x44e</merge>
<merge key="killswitch.expected_usb_product_id"
type="int">0x3007</merge>

      </match>

To make sure the killswitch controls (or tries to control) the correct adapter.

Cheers

Marcel Holtmann

maintainer

2008-09-29 23:44 UTC #4 lore raw

Hi Bastien,

Quoted 11 lines

Quoted 2 lines
Ok, so I remembered wrong ;-) How about adding a "disable this adapter" option? Would a patch that implements this be welcome?
I'd like a patch implementing HAL killswitching. DannyK can explain to you how that's supposed to work.
I saw this as a single toggle menu item in the right-click, allowing you to enable/disable the main Bluetooth adapter on laptops. If there's a killswitch present, and there's 0 or 1 adapter (and the adapter matches the expected device) then the Bluetooth icon would shown grayed out.

Quoted 7 lines

This would probably also require more work like this:
<match key="@info.parent:system.product" contains="VGN-S1XP">
<merge key="killswitch.expected_usb_vendor_id"
type="int">0x44e</merge>
<merge key="killswitch.expected_usb_product_id"
type="int">0x3007</merge>
      </match>

can we not just reference the UDI the killswitch belongs to. The vendor and product things can be misleading.

Regards

Marcel

Marcel Holtmann

maintainer

2008-09-30 03:18 UTC #5 lore raw

In reply to Bastien Nocera

Hi Bastien,

Quoted 10 lines

Quoted 2 lines
Ok, so I remembered wrong ;-) How about adding a "disable this adapter" option? Would a patch that implements this be welcome?
I'd like a patch implementing HAL killswitching. DannyK can explain to you how that's supposed to work.
I saw this as a single toggle menu item in the right-click, allowing you to enable/disable the main Bluetooth adapter on laptops. If there's a killswitch present, and there's 0 or 1 adapter (and the adapter matches the expected device) then the Bluetooth icon would shown grayed out.

so I added killswitch support to bluetooth-properties. Works pretty good enough for me.

I like having a grayed out icon, but for that to work, we first need to have some who actually draws it in all resolutions for us.

Regards

Marcel

Bastien Nocera

2008-09-30 10:17 UTC #6 lore raw

Quoted 13 lines · Marcel Holtmann

Hi Bastien,
Quoted 10 lines
Quoted 2 lines
Ok, so I remembered wrong ;-) How about adding a "disable this adapter" option? Would a patch that implements this be welcome?
I'd like a patch implementing HAL killswitching. DannyK can explain to you how that's supposed to work.
I saw this as a single toggle menu item in the right-click, allowing you to enable/disable the main Bluetooth adapter on laptops. If there's a killswitch present, and there's 0 or 1 adapter (and the adapter matches the expected device) then the Bluetooth icon would shown grayed out.

Quoted 5 lines

so I added killswitch support to bluetooth-properties. Works pretty good enough for me.
I like having a grayed out icon, but for that to work, we first need to have some who actually draws it in all resolutions for us.

GTK+ doesn't use separate pixbufs for those type of icons, but generates them on the fly with gdk_pixbuf_saturate_and_pixelate().

new_pixbuf = gdk_pixbuf_copy (original); gdk_pixbuf_saturate_and_pixelate(original, new_pixbuf, 0.8, TRUE);

And then set "new_pixbuf" as the image for the status icon. This will be a bit convoluted in the actual code as you're using icon names, and we'd need to 1) know whether we have a killswitch, and whether it's enabled and 2) modify the status icon to use the pixbuf.

Marcel Holtmann

maintainer

2008-09-30 10:29 UTC #7 lore raw

Hi Bastien,

Quoted 20 lines

Quoted 11 lines
Quoted 10 lines
Quoted 2 lines
Ok, so I remembered wrong ;-) How about adding a "disable this adapter" option? Would a patch that implements this be welcome?
I'd like a patch implementing HAL killswitching. DannyK can explain to you how that's supposed to work.
I saw this as a single toggle menu item in the right-click, allowing you to enable/disable the main Bluetooth adapter on laptops. If there's a killswitch present, and there's 0 or 1 adapter (and the adapter matches the expected device) then the Bluetooth icon would shown grayed out.
Quoted 5 lines
so I added killswitch support to bluetooth-properties. Works pretty good enough for me.
I like having a grayed out icon, but for that to work, we first need to have some who actually draws it in all resolutions for us.
GTK+ doesn't use separate pixbufs for those type of icons, but generates them on the fly with gdk_pixbuf_saturate_and_pixelate().

Quoted 7 lines

new_pixbuf = gdk_pixbuf_copy (original); gdk_pixbuf_saturate_and_pixelate(original, new_pixbuf, 0.8, TRUE);
And then set "new_pixbuf" as the image for the status icon. This will be a bit convoluted in the actual code as you're using icon names, and we'd need to 1) know whether we have a killswitch, and whether it's enabled and 2) modify the status icon to use the pixbuf.

as long as we have to poll the killswitch from HAL, this is never going to get merged into bluez-gnome. I want async notifications.

Regards

Marcel

Marcel Holtmann

maintainer

2008-09-29 23:43 UTC #8 lore raw

In reply to Stefan Seyfried

Hi Stefan,

Quoted 12 lines

Quoted 12 lines
Quoted 6 lines
I now got several bugreports from people searching for the button to turn their bluetooth device off in the bluetooth-applet. I seem to remember that there was the setting "off" (in addition to "Hidden", "Always visible", "Temporary visible") in previous versions. So what's the rationale for removing it (users seem to expect to find it there)? And if I remember
incorrectly: could we place such a button there?
There was never an "off" switch. There was:
- Other devices can connect
- Visible and connectable for other devices
- Limited discoverable and connectable

Quoted 4 lines

Quoted 1 line
The last 2 were folded into a single option.
Ok, so I remembered wrong ;-) How about adding a "disable this adapter" option? Would a patch that implements this be welcome?

you might have been right, because some distros shipped a patch to add an "off" selection to it. This wouldn't have done anything useful on the desktop, but they did it without knowing what they are doing.

Regards

Marcel