git user settings not retrieved when launched for Windows explorer

Dear Marco,

When I double click on qgit.exe, the user name and email are not shown in the user settings (for any of the 3 combo values). But if I run qgit from the commandline at the mysysgit bash prompt, the boxes are properly filled. I would like to debug it but, as I reported last week, the MSVC project doesn't work for me.

Quoted 9 lines · Abdelrazak Younes

Dear Marco,

When I double click on qgit.exe, the user name and email are not shown in the user settings (for any of the 3 combo values). But if I run qgit from the commandline at the mysysgit bash prompt, the boxes are properly filled. I would like to debug it but, as I reported last week, the MSVC project doesn't work for me.

Sound like a problem of startup directory: on the command line you start from the right directory...when you double click on which repo qgit is open ?

Quoted 5 lines

Sound like a problem of startup directory: on the command line you start from the right directory...when you double click on which repo qgit is open ?

None of course. But when I open a repository manually I would expect that this is properly filled in.

And if I launch qgit with the context menu (right clicking a directory in the Explorer), qgit never managed to open the repository.

Quoted 5 lines · Abdelrazak Younes

Quoted 5 lines

Sound like a problem of startup directory: on the command line you start from the right directory...when you double click on which repo qgit is open ?

Quoted 4 lines

None of course. But when I open a repository manually I would expect that this is properly filled in.

In git.cpp, Git::userInfo() function get info about user by means of 'git config' calls, my guess (I cannot it test now) is that 'git config' does not work if we are not in a git directory.

Quoted 6 lines

And if I launch qgit with the context menu (right clicking a directory in the Explorer), qgit never managed to open the repository.

This is a bug that I never managed to get rid of :-(

It is strange because it works if you try in a subdirectory, as example try right clicking on 'src' directory of qgit project.

Quoted 5 lines · Abdelrazak Younes

Quoted 5 lines

Sound like a problem of startup directory: on the command line you start from the right directory...when you double click on which repo qgit is open ?

Quoted 4 lines

None of course. But when I open a repository manually I would expect that this is properly filled in.

In git.cpp, Git::userInfo() function get info about user by means of 'git config' calls, my guess (I cannot it test now) is that 'git config' does not work if we are not in a git directory.

No, 'git config user.name' works fine in any directory, even on the naked Windows console (I mean without msys bash). So that must be something else. I've traced it down to
MyProcess::on_finished().

   isErrorExit =   (exitStatus != QProcess::NormalExit)
                || (exitCode != 0 && isWinShell)
                || !errorDesc.isEmpty()
                ||  canceling;

At this point we have:
exitStatus = NormalExit
exitCode = 1
isWinShell = false
errorDesc.isEmpty() returns true
canceling = false

Which gives 'isErrorExit = false'. I wonder if the isWinShell test is correct?

Quoted 17 lines · Abdelrazak Younes

No, 'git config user.name' works fine in any directory, even on the naked Windows console (I mean without msys bash). So that must be something else. I've traced it down to
MyProcess::on_finished().

    isErrorExit =   (exitStatus != QProcess::NormalExit)
                 || (exitCode != 0&&  isWinShell)
                 || !errorDesc.isEmpty()
                 ||  canceling;

At this point we have:
exitStatus = NormalExit
exitCode = 1
isWinShell = false
errorDesc.isEmpty() returns true
canceling = false

Quoted 4 lines

Which gives 'isErrorExit = false'. I wonder if the isWinShell test is correct?

Hi Abdel,

I would think it is correct to return isErrorExit == false

The problem is that it seems git config return empty data if run from outside git directory...isn't it ?

Quoted 5 lines · Abdelrazak Younes

Quoted 5 lines

Sound like a problem of startup directory: on the command line you start from the right directory...when you double click on which repo qgit is open ?

Quoted 4 lines

None of course. But when I open a repository manually I would expect that this is properly filled in.

In git.cpp, Git::userInfo() function get info about user by means of 'git config' calls, my guess (I cannot it test now) is that 'git config' does not work if we are not in a git directory.

OK, with this patch, I see that the local config request is apparently successful even though the 'user' and 'email' strings stay empty.

Quoted 3 lines · Abdelrazak Younes

OK, with this patch, I see that the local config request is apparently successful even though the 'user' and 'email' strings stay empty.

An empty user and email it does not mean failure.

An empty user and email it does not mean failure. Again, I would think that is git config that returns no data (without failing) if it is run from outside git directory.

Quoted 4 lines · Marco Costalba

An empty user and email it does not mean failure. Again, I would think that is git config that returns no data (without failing) if it is run from outside git directory.

Yes ! it is like this, I have finally had the possibility to test.

git config does not returns user and mail if run outside git dir because user and mail are local set.

So how do you explain this:

Quoted 3 lines · Abdelrazak Younes

So how do you explain this:

Form git-config(1) docs:

This command will fail if:

(quoted diff) +0 -2

-The config file is invalid,
......
-you use --global option without $HOME being properly set.

So please try to comment out following line

src/git.cpp +1 -1

@@ -345,7 +345,7 @@ void Git::userInfo(SList info) {
  	info.clear();
  	info<<  "Environment"<<  user<<  email;
 
-	errorReportingEnabled = false; // 'git config' could fail, see docs
+	//errorReportingEnabled = false; // 'git config' could fail, see docs
 
  	run("git config user.name",&user);
  	run("git config user.email",&email);

run from double click and you probably will see an error message box where git says $HOME is not set (I can reproduce this now).

So what I think is that when you run from command line there is the $HOME variable set and command does not fails.

So I guess this was set by msysgit at installation time. But I see this variable only at the console (after typing 'set'), I don't see it in the user environment variable nor in the system one. So I guess the fix would be for msysgit to create this entry?

Dear Marco,

By the way, these two edit boxes are not editable on Windows, is that on purpose? If yes, maybe we could let the user change them is 'Local config' is selected and call the appropriate git function?

Quoted 3 lines · Abdelrazak Younes

Dear Marco,

Quoted 5 lines

By the way, these two edit boxes are not editable on Windows, is that on purpose? If yes, maybe we could let the user change them is 'Local config' is selected and call the appropriate git function?

I know this limitation. I was just too lazy to implement edit myself...it would be a nice patch to have tough ;-)