Skip to contentSkip to conversation

fujitsu-laptop: fix section mismatch warning

PATCH In review Randy Dunlap 3 participants 3 messages Oct 8, 2008 – Oct 9, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fujitsu-laptop: fix section mismatch warning

From: Randy Dunlap <[email protected]>

Could fix a bug in a hotplug add scenario.

WARNING: drivers/misc/fujitsu-laptop.o(.text+0xbde): Section mismatch in reference from the function acpi_fujitsu_add() to the variable .init.data:fujitsu_dmi_table The function acpi_fujitsu_add() references
the variable __initdata fujitsu_dmi_table.
This is often because acpi_fujitsu_add lacks a __initdata
annotation or the annotation of fujitsu_dmi_table is wrong.

cc Jonathan Woithe <[email protected]>
---
 drivers/misc/fujitsu-laptop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/fujitsu-laptop.c +1 -1
@@ -455,7 +455,7 @@ static int dmi_check_cb_s6410(const stru
 	return 0;
 }
 
-static struct dmi_system_id __initdata fujitsu_dmi_table[] = {
+static struct dmi_system_id fujitsu_dmi_table[] = {
 	{
 	 .ident = "Fujitsu Siemens",
 	 .matches = {
reviewer
#1 lore raw

applied to acpi-test.

thanks,
-Len

Quoted 28 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Could fix a bug in a hotplug add scenario.

WARNING: drivers/misc/fujitsu-laptop.o(.text+0xbde): Section mismatch in reference from the function acpi_fujitsu_add() to the variable .init.data:fujitsu_dmi_table The function acpi_fujitsu_add() references
the variable __initdata fujitsu_dmi_table.
This is often because acpi_fujitsu_add lacks a __initdata
annotation or the annotation of fujitsu_dmi_table is wrong.

cc Jonathan Woithe <[email protected]>
---
 drivers/misc/fujitsu-laptop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/fujitsu-laptop.c +1 -1
@@ -455,7 +455,7 @@ static int dmi_check_cb_s6410(const stru
 	return 0;
 }
 
-static struct dmi_system_id __initdata fujitsu_dmi_table[] = {
+static struct dmi_system_id fujitsu_dmi_table[] = {
 	{
 	 .ident = "Fujitsu Siemens",
 	 .matches = {
#2 lore raw
In reply to Randy Dunlap
Quoted 19 lines

From: Randy Dunlap <[email protected]>

Could fix a bug in a hotplug add scenario.

WARNING: drivers/misc/fujitsu-laptop.o(.text+0xbde): Section mismatch in reference from the function acpi_fujitsu_add() to the variable .init.data:fujitsu_dmi_table The function acpi_fujitsu_add() references
the variable __initdata fujitsu_dmi_table.
This is often because acpi_fujitsu_add lacks a __initdata
annotation or the annotation of fujitsu_dmi_table is wrong.

cc Jonathan Woithe <[email protected]>
---
 drivers/misc/fujitsu-laptop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/misc/fujitsu-laptop.c static int dmi_check_cb_s6410(const stru · line 461

Quoted 8 lines
drivers/misc/fujitsu-laptop.c +1 -1
@@ -455,7 +455,7 @@ static int dmi_check_cb_s6410(const stru
 	return 0;
 }
 
-static struct dmi_system_id __initdata fujitsu_dmi_table[] = {
+static struct dmi_system_id fujitsu_dmi_table[] = {
 	{
 	 .ident = "Fujitsu Siemens",
 	 .matches = {

Ack.

Regards
jonathan