myri10ge: remove over-paranoid queue number modulus

PATCH Applied Brice Goglin 2 participants 2 messages Oct 9, 2008

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Brice Goglin

author

2008-10-09 14:08 UTC #0 lore raw

PATCH 1/1 myri10ge: remove over-paranoid queue number modulus

No need to modulus the queue number in ->hard_start_xmit() since the core is going to do that for you modulus ->real_num_tx_queues.

Signed-off-by Brice Goglin <[email protected]>

drivers/net/myri10ge/myri10ge.c +0 -2

index ab7755a..8cec6f3 100644
@@ -2643,8 +2643,6 @@ static int myri10ge_xmit(struct sk_buff *skb, struct net_device *dev)
 	u8 flags, odd_flag;
 
 	queue = skb_get_queue_mapping(skb);
-	queue &= (mgp->num_slices - 1);
-
 	ss = &mgp->ss[queue];
 	netdev_queue = netdev_get_tx_queue(mgp->dev, queue);
 	tx = &ss->tx;

David Miller

maintainer Applied

2008-10-09 21:32 UTC #1 lore raw

From: Brice Goglin <[email protected]>
Date: Thu, 09 Oct 2008 16:10:13 +0200

Quoted 4 lines

No need to modulus the queue number in ->hard_start_xmit() since the core is going to do that for you modulus ->real_num_tx_queues.
Signed-off-by Brice Goglin <[email protected]>

Applied, thank you.