Skip to contentSkip to conversation

PPC440EPx gpio driver

PATCH In review Steven A. Falco 3 participants 3 messages Oct 10, 2008

Subsystems (2)
PowerPC Linux for PowerPC embedded PPC4XX
lore
Share & tools
lore

Steven A. Falco

author
#0 lore raw

PATCH v7 1/1 PPC440EPx gpio driver

This patch adds support for the GPIO functions of PPC40x and PPC44x SOCs.

Signed-off-by Steve Falco <sfalco at harris.com>

---
Changes from the previous version:

1) Removed !! from the input routine. I'll work up a separate patch for sysfs to sanitize input.

2) Used the clr/set macros to improve readability.

3) Changed the device from amcc to ibm.

arch/powerpc/platforms/40x/Kconfig +8 -0
index a9260e2..aaada72 100644
@@ -139,6 +139,14 @@ config STB03xxx
 	select IBM405_ERR77
 	select IBM405_ERR51
 
+config PPC4xx_GPIO
+	bool "PPC4xx GPIO support"
+	depends on 40x
+	select ARCH_REQUIRE_GPIOLIB
+	select GENERIC_GPIO
+	help
+	  Enable gpiolib support for ppc40x based boards
+
 # 40x errata/workaround config symbols, selected by the CPU models above
 
 # All 405-based cores up until the 405GPR and 405EP have this errata.
arch/powerpc/platforms/44x/Kconfig +8 -0
index 249ba01..eec5cb4 100644
@@ -127,6 +143,14 @@ config XILINX_VIRTEX440_GENERIC_BOARD
 	  Most Virtex 5 designs should use this unless it needs to do some
 	  special configuration at board probe time.
 
+config PPC4xx_GPIO
+	bool "PPC4xx GPIO support"
+	depends on 44x
+	select ARCH_REQUIRE_GPIOLIB
+	select GENERIC_GPIO
+	help
+	  Enable gpiolib support for ppc440 based boards
+
 # 44x specific CPU modules, selected based on the board above.
 config 440EP
 	bool
arch/powerpc/sysdev/Makefile +1 -0
index a90054b..35d5765 100644
@@ -35,6 +35,7 @@ obj-$(CONFIG_OF_RTC)		+= of_rtc.o
 ifeq ($(CONFIG_PCI),y)
 obj-$(CONFIG_4xx)		+= ppc4xx_pci.o
 endif
+obj-$(CONFIG_PPC4xx_GPIO)	+= ppc4xx_gpio.o
 
 # Temporary hack until we have migrated to asm-powerpc
 ifeq ($(ARCH),powerpc)
arch/powerpc/sysdev/ppc4xx_gpio.c new file +217 -0

217 lines not on this page · raw message

Acked-by on v7 1/1
#1 lore raw
Quoted 2 lines · Steven A. Falco

This patch adds support for the GPIO functions of PPC40x and PPC44x SOCs.

Looks good. But you should change the subject line now. Its not only a PPC440EPx gpio driver but ppc4xx. Also please add "powerpc/4xx: " to the beginning of the subject line. And you should always send 4xx related patches to the subsystem maintainer too (CC), in this case Josh Boyer.

Quoted 1 line
Signed-off-by Steve Falco <sfalco at harris.com>

You can add my:

Acked-by Stefan Roese <[email protected]>

in the next patch revision. :)

Best regards,
Stefan

Acked-by
#2 lore raw
Quoted 10 lines · On Fri, 10 Oct 2008 16:02:32 +0200 "Stefan Roese" <[email protected]> wrote:
Quoted 2 lines · Steven A. Falco

This patch adds support for the GPIO functions of PPC40x and PPC44x SOCs.

Looks good. But you should change the subject line now. Its not only a PPC440EPx gpio driver but ppc4xx. Also please add "powerpc/4xx: " to the beginning of the subject line. And you should always send 4xx related patches to the subsystem maintainer too (CC), in this case Josh Boyer.

Quoted 7 lines
Quoted 1 line
Signed-off-by Steve Falco <sfalco at harris.com>

You can add my:

Acked-by Stefan Roese <[email protected]>

in the next patch revision. :)

Tested on the warp (440EP).

Acked-by Sean MacLennan <[email protected]>

Cheers,
Sean