Skip to contentSkip to conversation

BR2_PACKAGE_BUSYBOX_CONFIG and Atmel targets

Buildroot New Anders Blomdell 4 participants 9 messages Oct 12, 2008 – Oct 15, 2008

lore
Share & tools
lore
#0 lore raw

in target/device/Atmel/atngw100/Makefile.in there is a line

BR2_PACKAGE_BUSYBOX_CONFIG:=$(BOARD_PATH)/busybox-1.9.1.config

unfortunately this makes it impossible to change busybox config (primarily I want to turn off telnet) to a custom version. What is the correct way to handle this?

Regards

Anders Blomdell

#1 lore raw
Quoted 8 lines · On Sun, 12 Oct 2008 12:16:24 +0200 Anders Blomdell…

in target/device/Atmel/atngw100/Makefile.in there is a line

BR2_PACKAGE_BUSYBOX_CONFIG:=$(BOARD_PATH)/busybox-1.9.1.config

unfortunately this makes it impossible to change busybox config (primarily I want to turn off telnet) to a custom version. What is the correct way to handle this?

Well, naming indicates that you will need to add a busybox-<version>.config file.

It is probably a good idea to scrap the <version> part as well, just have a generic busybox.config file. Kconfig options should not change that often, and user will be asked to answer yes/no to new features most times.

Signature · 2 lines
Best regards,
Hans-Christian Egtvedt
#2 lore raw
Quoted 7 lines · Hans-Christian Egtvedt
Quoted 4 lines · On Sun, 12 Oct 2008 12:16:24 +0200 Anders Blomdell…

in target/device/Atmel/atngw100/Makefile.in there is a line

BR2_PACKAGE_BUSYBOX_CONFIG:=$(BOARD_PATH)/busybox-1.9.1.config

Quoted 7 lines
Quoted 4 lines

unfortunately this makes it impossible to change busybox config (primarily I want to turn off telnet) to a custom version. What is the correct way to handle this?

Well, naming indicates that you will need to add a busybox-<version>.config file.

And change the Makfile.in as well, IMHO that is the wrong path to follow.

Quoted 5 lines

It is probably a good idea to scrap the <version> part as well, just have a generic busybox.config file. Kconfig options should not change that often, and user will be asked to answer yes/no to new features most times.

Is there any good reason at all to unconditionally ignore the busybox config choosen by the user (many of the Atmel boards and a few other does this)? Would a patch that just removes all these unconditional configurations be accepted, or is there any deep reason for not allowing Atmel users choose their own busybox configuration (and in the default case choose the buildroot default instead of a board specific one)?

Regards

Anders Blomdell

#3 lore raw
Quoted 21 lines · Anders Blomdell
Quoted 7 lines · Hans-Christian Egtvedt
Quoted 4 lines · On Sun, 12 Oct 2008 12:16:24 +0200 Anders Blomdell…

in target/device/Atmel/atngw100/Makefile.in there is a line

BR2_PACKAGE_BUSYBOX_CONFIG:=$(BOARD_PATH)/busybox-1.9.1.config

Quoted 7 lines
Quoted 4 lines

unfortunately this makes it impossible to change busybox config (primarily I want to turn off telnet) to a custom version. What is the correct way to handle this?

Well, naming indicates that you will need to add a busybox-<version>.config file.

And change the Makfile.in as well, IMHO that is the wrong path to follow.

Quoted 5 lines

It is probably a good idea to scrap the <version> part as well, just have a generic busybox.config file. Kconfig options should not change that often, and user will be asked to answer yes/no to new features most times.

Quoted 6 lines

Is there any good reason at all to unconditionally ignore the busybox config choosen by the user (many of the Atmel boards and a few other does this)? Would a patch that just removes all these unconditional configurations be accepted, or is there any deep reason for not allowing Atmel users choose their own busybox configuration (and in the default case choose the buildroot default instead of a board specific one)?

Did you read docs/README and try what's documented there (see "finegrained")?

#4 lore raw
Quoted 27 lines · Bernhard Reutner-Fischer
Quoted 19 lines · Anders Blomdell
Quoted 5 lines · Hans-Christian Egtvedt
Quoted 2 lines · On Sun, 12 Oct 2008 12:16:24 +0200 Anders Blomdell…

in target/device/Atmel/atngw100/Makefile.in there is a line

Quoted 8 lines
Quoted 6 lines

BR2_PACKAGE_BUSYBOX_CONFIG:=$(BOARD_PATH)/busybox-1.9.1.config

unfortunately this makes it impossible to change busybox config (primarily I want to turn off telnet) to a custom version. What is the correct way to handle this?

Well, naming indicates that you will need to add a busybox-<version>.config file.

And change the Makfile.in as well, IMHO that is the wrong path to follow.

Quoted 4 lines

It is probably a good idea to scrap the <version> part as well, just have a generic busybox.config file. Kconfig options should not change that often, and user will be asked to answer yes/no to new features most times.

Quoted 6 lines

Is there any good reason at all to unconditionally ignore the busybox config choosen by the user (many of the Atmel boards and a few other does this)? Would a patch that just removes all these unconditional configurations be accepted, or is there any deep reason for not allowing Atmel users choose their own busybox configuration (and in the default case choose the buildroot default instead of a board specific one)?

Quoted 2 lines

Did you read docs/README and try what's documented there (see "finegrained")?

No, missed that (or more correctly I interpreted that setting BR2_PACKAGE_BUSYBOX_CONFIG should be equivalent).

Regards

Anders Blomdell

Signature · 5 lines
Anders Blomdell                  Email: anders.blomdell at control.lth.se
Department of Automatic Control
Lund University                  Phone:    +46 46 222 4625
P.O. Box 118                     Fax:      +46 46 138118
SE-221 00 Lund, Sweden
#5 lore raw
Quoted 4 lines · Anders Blomdell
Quoted 2 lines

Did you read docs/README and try what's documented there (see "finegrained")?

No, missed that (or more correctly I interpreted that setting BR2_PACKAGE_BUSYBOX_CONFIG should be equivalent).

It's supposed to override any config- or board-imposed configfile(s). If it's broken in svn then bug somebody to fix it.

cheers,

#6 lore raw
In reply to Anders Blomdell
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Anders" == Anders Blomdell <[email protected]> writes:

Hi,

Anders> in target/device/Atmel/atngw100/Makefile.in there is a line Anders> BR2_PACKAGE_BUSYBOX_CONFIG:=$(BOARD_PATH)/busybox-1.9.1.config

Yes, this is done so specific boards can enforce certain busybox/uclibc configurations. For most boards this is fine, but you can ofcause start to question it for evaluation boards.

Either change the config that it points to or don't select that board (or create your own board config based on the atngw).

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw
Quoted 10 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Anders" == Anders Blomdell <[email protected]> writes:

Hi,

Anders> in target/device/Atmel/atngw100/Makefile.in there is a line Anders> BR2_PACKAGE_BUSYBOX_CONFIG:=$(BOARD_PATH)/busybox-1.9.1.config

Yes, this is done so specific boards can enforce certain busybox/uclibc configurations. For most boards this is fine, but you can ofcause start to question it for evaluation boards.

To me it looks like this diminishes the value of buildroot for these boards, I would suggest something like the attached patch (i.e. providing board specific defaults without forcing the user to always use them)

Quoted 2 lines

Either change the config that it points to or don't select that board (or create your own board config based on the atngw).

And put these restrictions in the buildroot documentation, so others will find it sooner than I did...

Regards

Anders

Signature · 9 lines
Anders Blomdell                  Email: anders.blomdell at control.lth.se
Department of Automatic Control
Lund University                  Phone:    +46 46 222 4625
P.O. Box 118                     Fax:      +46 46 138118
SE-221 00 Lund, Sweden
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: atmel_buildroot.patch
Url: http://busybox.net/lists/buildroot/attachments/20081013/bb270309/attachment.txt 
#8 lore raw

PATCH 1/1 Obey BR2_PACKAGE_BUSYBOX_CONFIG on atngw100

In reply to Peter Korsgaard

Resend of patch thet was at end of a previous discussion ('BR2_PACKAGE_BUSYBOX_CONFIG and Atmel targets'), in the hope that someone eventually picks it up...

Regards

Anders Blomdell

Signature · 10 lines
Anders Blomdell                  Email: anders.blomdell at control.lth.se
Department of Automatic Control
Lund University                  Phone:    +46 46 222 4625
P.O. Box 118                     Fax:      +46 46 138118
SE-221 00 Lund, Sweden

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: atmel_buildroot.patch
Url: http://busybox.net/lists/buildroot/attachments/20081015/a26a45eb/attachment.txt