Skip to contentSkip to conversation

Quirk for Apple Aluminum Bluetooth keyboard FN key

PATCH In review Mario Limonciello 2 participants 3 messages Oct 14, 2008 – Oct 23, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Quirk for Apple Aluminum Bluetooth keyboard FN key

This patch was present in Ubuntu Hardy, but got dropped by accident in Intrepid and never submitted upstream. It adds a quirk enabling the FN key on the Apple Aluminum Bluetooth Wireless Keyboard.

---
 net/bluetooth/hidp/core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
net/bluetooth/hidp/core.c +2 -0
index 96434d7..fc6e643 100644
@@ -684,6 +684,8 @@ static const struct {
 } hidp_blacklist[] = {
     /* Apple wireless Mighty Mouse */
     { 0x05ac, 0x030c, HID_QUIRK_MIGHTYMOUSE | HID_QUIRK_INVERT_HWHEEL },
+    /* Apple wireless Bluetooth Keyboard */
+    { 0x05ac, 0x022c, HID_QUIRK_APPLE_HAS_FN },
 
     { }    /* Terminating entry */
 };
Signature · 1 line
1.5.4.3
maintainer
#1 lore raw

Hi Mario,

Quoted 3 lines

This patch was present in Ubuntu Hardy, but got dropped by accident in Intrepid and never submitted upstream. It adds a quirk enabling the FN key on the Apple Aluminum Bluetooth Wireless Keyboard.

yeah, the Ubuntu kernel team is pretty bad in getting patches back to upstream. However in this case please check with the upstream kernel since the HID bus makes all quirks general to the HID subsystem.

Regards

Marcel

#2 lore raw

Hi Marcel:

Quoted 8 lines · Marcel Holtmann

Hi Mario,
yeah, the Ubuntu kernel team is pretty bad in getting patches back to upstream. However in this case please check with the upstream kernel since the HID bus makes all quirks general to the HID subsystem.

Regards

Marcel

Yeah, that's what I was thinking should be happening, and a little bit shocked that it didn't work properly since I saw a variation of this quirk in the hid source files already. I was a little thrown off though since there is already a quirk for the mighty mouse sitting in this section that I was patching, so it seemed sensible to add the quirk for the keyboard there too. I'll try to investigate why those quirks aren't carrying over properly.

Regards

Signature · 3 lines
Mario Limonciello
*Dell | Linux Engineering*
[email protected]