Skip to contentSkip to conversation

remove compilerwarning in lib_ppc_board.c

PATCH New Heiko Schocher 3 participants 3 messages Oct 15, 2008

lore
Share & tools
lore

Heiko Schocher

author
#0 lore raw

PATCH 1/1 remove compilerwarning in lib_ppc_board.c

Hello Jason,

compiling actual u-boot-next branch for a powerpc board, shows following warning:

[hs at pollux u-boot]$ make -s all
board.c:639: warning: function declaration isn't a prototype board.c:646: warning: function declaration isn't a prototype [hs at pollux u-boot]$

introduced from commit:
-------------------------------------------------------------------------------
author Jason Jin <[email protected]>

         Fri, 10 Oct 2008 03:41:01 +0000 (11:41 +0800)
committer       Wolfgang Denk <[email protected]>
         Tue, 14 Oct 2008 15:57:27 +0000 (17:57 +0200)

commit 0f8cbc1829d9c7d9616fd29b366a99d037facdcd

Do not init SATA when disabled on 8536DS.

SGMII and SATA share the serdes on MPC8536 CPU, When SATA disabled and the driver still try to access the SATA registers, the cpu will hangup. This patch try to fix this by reading the serdes status before the SATA initialize.

Signed-off-by Jason Jin <[email protected]>
Acked-by Andy Fleming <[email protected]>

-------------------------------------------------------------------------------

This patch solves the warning. Jason, can you please try it, and give your okay for this fix?

Signed-off-by Heiko Schocher <[email protected]>
---
 board/freescale/mpc8536ds/mpc8536ds.c |    2 +-
 lib_ppc/board.c                       |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
board/freescale/mpc8536ds/mpc8536ds.c +1 -1
index 3cf12fd..3066b24 100644
@@ -608,7 +608,7 @@ get_board_ddr_clk(ulong dummy)
 }
 #endif
 
-int is_sata_supported()
+int is_sata_supported(void)
 {
 	volatile ccsr_gur_t *gur = (void *)(CFG_MPC85xx_GUTS_ADDR);
 	uint devdisr = gur->devdisr;
lib_ppc/board.c +2 -2
index 03681e9..3fdd94b 100644
@@ -635,7 +635,7 @@ void board_init_f (ulong bootflag)
 	/* NOTREACHED - relocate_code() does not return */
 }
 
-int __is_sata_supported()
+int __is_sata_supported(void)
 {
 	/* For some boards, when sata disabled by the switch, and the
 	 * driver still access the sata registers, the cpu will hangup.

@@ -643,7 +643,7 @@ int __is_sata_supported()
 	 * board have such issue.*/
 	return 1;
 }
-int is_sata_supported() __attribute__((weak, alias("__is_sata_supported")));
+int is_sata_supported(void) __attribute__((weak, alias("__is_sata_supported")));
 
 /************************************************************************
  *
Signature · 5 lines
1.5.6.1

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw

PATCH 1/1 remove compilerwarning in lib_ppc_board.c

Dear Heiko Schocher,

Quoted 8 lines · In message <[email protected]> you wrote:

compiling actual u-boot-next branch for a powerpc board, shows following warning:

[hs at pollux u-boot]$ make -s all
board.c:639: warning: function declaration isn't a prototype board.c:646: warning: function declaration isn't a prototype [hs at pollux u-boot]$

...

Quoted 2 lines

This patch solves the warning. Jason, can you please try it, and give your okay for this fix?

I was just looking for a fix for the same issue, so I just checked it in :-)

Thanks!

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Good manners are the settled  medium  of  social,  as  specie  is  of
commercial, life; returns are equally expected for both.
           - Lord Chesterfield _Letters to his Son_, 25 December 1753
#2 lore raw

PATCH 1/1 remove compilerwarning in lib_ppc_board.c

Quoted 26 lines

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Wednesday, October 15, 2008 4:39 PM
To: hs at denx.de
Cc: Jin Zhengxiong-R64188; Fleming Andy-AFLEMING; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] [POWERPC] remove compilerwarning in lib_ppc_board.c

Dear Heiko Schocher,

Quoted 8 lines · In message <[email protected]> you wrote:

compiling actual u-boot-next branch for a powerpc board, shows following warning:

[hs at pollux u-boot]$ make -s all
board.c:639: warning: function declaration isn't a prototype board.c:646: warning: function declaration isn't a prototype [hs at pollux u-boot]$

...

Quoted 1 line

This patch solves the warning. Jason, can you please try

it, and give

Quoted 1 line

your okay for this fix?

Quoted 9 lines

I was just looking for a fix for the same issue, so I just checked it in :-)

Thanks!

Best regards,

Wolfgang Denk

Thanks! Two :-)

Jason

Quoted 9 lines
Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: 
wd at denx.de Good manners are the settled  medium  of  social,  
as  specie  is  of commercial, life; returns are equally 
expected for both.
           - Lord Chesterfield _Letters to his Son_, 25 December 1753