Skip to contentSkip to conversation

Fix debugfs_create_*'s error checking method for mips/kernel/

PATCH Applied Zhaolei 3 participants 3 messages Oct 17, 2008 MIPS

lore
Share & tools
lore

Zhaolei

author
#0 lore raw

PATCH 1/1 Fix debugfs_create_*'s error checking method for mips/kernel/

Hi,

debugfs_create_*() returns NULL if an error occurs, returns -ENODEV when debugfs is not enabled in the kernel.

Signed-off-by Zhao Lei <[email protected]>
---
 arch/mips/kernel/setup.c     |    4 ++--
 arch/mips/kernel/unaligned.c |    8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)
arch/mips/kernel/setup.c +2 -2
index 16f8edf..4430a1f 100644
@@ -601,8 +601,8 @@ static int __init debugfs_mips(void)
 	struct dentry *d;
 
 	d = debugfs_create_dir("mips", NULL);
-	if (IS_ERR(d))
-		return PTR_ERR(d);
+	if (!d)
+		return -ENOMEM;
 	mips_debugfs_dir = d;
 	return 0;
 }
arch/mips/kernel/unaligned.c +4 -4
index c327b21..2070966 100644
@@ -560,12 +560,12 @@ static int __init debugfs_unaligned(void)
 		return -ENODEV;
 	d = debugfs_create_u32("unaligned_instructions", S_IRUGO,
 			       mips_debugfs_dir, &unaligned_instructions);
-	if (IS_ERR(d))
-		return PTR_ERR(d);
+	if (!d)
+		return -ENOMEM;
 	d = debugfs_create_u32("unaligned_action", S_IRUGO | S_IWUSR,
 			       mips_debugfs_dir, &unaligned_action);
-	if (IS_ERR(d))
-		return PTR_ERR(d);
+	if (!d)
+		return -ENOMEM;
 	return 0;
 }
 __initcall(debugfs_unaligned);
Signature · 1 line
1.5.5.3
Applied
#2 lore raw
In reply to Zhaolei
Quoted 2 lines · Zhaolei

debugfs_create_*() returns NULL if an error occurs, returns -ENODEV when debugfs is not enabled in the kernel.

Applied. Thanks,

Ralf