sparc: correct section of apc_no_idle
PATCH 1/1 sparc: correct section of apc_no_idle
The latest mainline gives this section mismatch on sparc:
The function __devinit apc_probe() references
a variable __initdata apc_no_idle.
If apc_no_idle is only used by apc_probe then
annotate apc_no_idle with a matching annotation.
Since the commit 7e7e2f035663c5ceb029bfb9d91e75099b0a5625, apc_probe() is on __devinit so we have to correct apc_no_idle which is referenced by this function.
---
arch/sparc/kernel/apc.c +1 -1
@@ -31,7 +31,7 @@#define APC_DEVNAME "apc"static u8 __iomem *regs; -static int apc_no_idle__initdata =0 ; +static int apc_no_idle__devinitdata =0 ;#define apc_readb (offs) (sbus_readb(regs+offs))#define apc_writeb (val, offs) (sbus_writeb(val, regs+offs))
2008/10/18 Frederic Weisbecker <[email protected]>:
Quoted 19 lines
The latest mainline gives this section mismatch on sparc:
The function
__devinitapc_probe()references
a variable__initdataapc_no_idle.
Ifapc_no_idleis only used byapc_probethen
annotateapc_no_idlewith a matching annotation.Since the commit
7e7e2f035663c5ceb029bfb9d91e75099b0a5625,apc_probe()is on__devinitso we have to correctapc_no_idlewhich is referenced by this function.Signed-off-by Frederic Weisbecker <[email protected]>---
arch/sparc/kernel/apc.c +0
-0
arch/sparc/kernel/apc.c line 37
Quoted 8 lines
arch/sparc/kernel/apc.c +1
-1@@ -31,7 +31,7 @@#define APC_DEVNAME "apc"static u8 __iomem *regs; -static int apc_no_idle__initdata =0 ; +static int apc_no_idle__devinitdata =0 ;#define apc_readb (offs) (sbus_readb(regs+offs))#define apc_writeb (val, offs) (sbus_writeb(val, regs+offs))
(Adding William and sparclinux in cc)
From: Frederic Weisbecker <[email protected]>
Date: Sat, 18 Oct 2008 18:11:34 +0200
[ Please post sparc patches to [email protected] in
the future, CC:'d ]
Quoted 7 lines
The latest mainline gives this section mismatch on sparc:
The function
__devinitapc_probe()references
a variable__initdataapc_no_idle.
Ifapc_no_idleis only used byapc_probethen
annotateapc_no_idlewith a matching annotation.
Quoted 5 lines
Since the commit
7e7e2f035663c5ceb029bfb9d91e75099b0a5625,apc_probe()is on__devinitso we have to correctapc_no_idlewhich is referenced by this function.Signed-off-by Frederic Weisbecker <[email protected]>
Applied, thanks.
Quoted 13 lines
arch/sparc/kernel/apc.c +1
-1@@ -31,7 +31,7 @@#define APC_DEVNAME "apc"static u8 __iomem *regs; -static int apc_no_idle__initdata =0 ; +static int apc_no_idle__devinitdata =0 ;#define apc_readb (offs) (sbus_readb(regs+offs))#define apc_writeb (val, offs) (sbus_writeb(val, regs+offs))