Skip to contentSkip to conversation

sparc: correct section of current_pc()

PATCH In review Frederic Weisbecker 2 participants 2 messages Oct 18, 2008 – Oct 22, 2008 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc: correct section of current_pc()

Latest mainline gives this section mismatch on sparc:

The function current_pc() references
the variable __init no_sun4u_here.
This is often because current_pc lacks a __init annotation or the annotation of no_sun4u_here is wrong.

Since current_pc() is used only in early time, it is correct to put it in .init section.

---

arch/sparc/kernel/head.S +1 -0
index 2d325fd..2fe2c11 100644
@@ -465,6 +465,7 @@ gokernel:
 		mov	%o7, %g4		! Save %o7
 
 		/* Jump to it, and pray... */
+		__INIT
 current_pc:
 		call	1f
 		 nop
maintainer
#1 lore raw

From: Frederic Weisbecker <[email protected]>
Date: Sat, 18 Oct 2008 18:32:45 +0200

[ [email protected] CC:'d ]

Quoted 11 lines

Latest mainline gives this section mismatch on sparc:

The function current_pc() references
the variable __init no_sun4u_here.
This is often because current_pc lacks a __init annotation or the annotation of no_sun4u_here is wrong.

Since current_pc() is used only in early time, it is correct to put it in .init section.

Also applied, thanks.

Quoted 12 lines
arch/sparc/kernel/head.S +1 -0
index 2d325fd..2fe2c11 100644
@@ -465,6 +465,7 @@ gokernel:
 		mov	%o7, %g4		! Save %o7
 
 		/* Jump to it, and pray... */
+		__INIT
 current_pc:
 		call	1f
 		 nop