kdump: Fix invalid access on i386 sparsemem.
Subsystems (3)
PATCH 1/1 kdump: Fix invalid access on i386 sparsemem.
Hi,
Since linux-2.6.27, kdump has failed on i386 sparsemem kernel. 1st-kernel gets a panic just before switching to 2nd-kernel.
The cause is that a kernel accesses invalid mem_section by page_to_pfn(image->swap_page) at machine_kexec(). image->swap_page is allocated if kexec for hibernation, but it is not allocated if kdump. So if kdump, a kernel should not access the mem_section corresponding to image->swap_page. The attached patch fixes this invalid access.
Thanks
Ken'ichi Ohmichi
---
arch/x86/kernel/machine_kexec_32.c +4 -1
@@ -162,7 +162,10 @@ void machine_kexec(struct kimage *image) page_list[VA_PTE_0 ] = (unsigned long )kexec_pte0; page_list[PA_PTE_1 ] =__pa (kexec_pte1); page_list[VA_PTE_1 ] = (unsigned long )kexec_pte1; - page_list[PA_SWAP_PAGE ] = (page_to_pfn (image->swap_page) <<PAGE_SHIFT ); + +if (image->type ==KEXEC_TYPE_DEFAULT ) + page_list[PA_SWAP_PAGE ] = (page_to_pfn (image->swap_page) + <<PAGE_SHIFT );/* The segment registers are funny things, they have both a * visible and an invisible part. Whenever the visible part is
_
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Ingo Molnar
AppliedQuoted 6 lines · Ken'ichi Ohmichi
Hi,
Since linux-2.6.27, kdump has failed on i386 sparsemem kernel. 1st-kernel gets a panic just before switching to 2nd-kernel.
Quoted 6 lines
The cause is that a kernel accesses invalid
mem_sectionbypage_to_pfn(image->swap_page)atmachine_kexec().image->swap_pageis allocated if kexec for hibernation, but it is not allocated if kdump. So if kdump, a kernel should not access themem_sectioncorresponding toimage->swap_page. The attached patch fixes this invalid access.
applied to tip/x86/urgent, thanks!
Ingo
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec