Skip to contentSkip to conversation

AX88796: ax_probe() fix irq assignment

PATCH Applied roel kluin 2 participants 2 messages Oct 20, 2008 – Oct 21, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

roel kluin

author
#0 lore raw

PATCH 1/1 AX88796: ax_probe() fix irq assignment

dev->irq is unsigned

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/ax88796.c +3 -3
index 4207d6e..9a314d8 100644
@@ -838,12 +838,12 @@ static int ax_probe(struct platform_device *pdev)
 
 	/* find the platform resources */
 
-	dev->irq  = platform_get_irq(pdev, 0);
-	if (dev->irq < 0) {
+	ret  = platform_get_irq(pdev, 0);
+	if (ret < 0) {
 		dev_err(&pdev->dev, "no IRQ specified\n");
-		ret = -ENXIO;
 		goto exit_mem;
 	}
+	dev->irq = ret;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (res == NULL) {
Applied
#1 lore raw
Quoted 11 lines · roel kluin

dev->irq is unsigned

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/ax88796.c +0 -0
index 4207d6e..9a314d8 100644
@@ -838,12 +838,12 @@ static int ax_probe(struct platform_device *pdev)
 
 	/* find the platform resources */

drivers/net/ax88796.c static int ax_probe(struct platform_device *pdev) · line 846

Quoted 10 lines
drivers/net/ax88796.c +3 -3
 
-	dev->irq  = platform_get_irq(pdev, 0);
-	if (dev->irq < 0) {
+	ret  = platform_get_irq(pdev, 0);
+	if (ret < 0) {
 		dev_err(&pdev->dev, "no IRQ specified\n");
-		ret = -ENXIO;
 		goto exit_mem;
 	}
+	dev->irq = ret;

applied