at91: board specific lowlevel_init.S

This patch allows to have an at91 board specific lowlevel_init.S

Signed-off-by Ilko Iliev <[email protected]>

index ec6ad5d..7882e89 100644

cpu/arm926ejs/at91/lowlevel_init.S +1 -1

@@ -27,7 +27,7 @@
 #include <config.h>
 #include <version.h>
 
-#ifndef CONFIG_SKIP_LOWLEVEL_INIT
+#if !defined(CONFIG_SKIP_LOWLEVEL_INIT) && 
 !defined(CONFIG_USER_LOWLEVEL_INIT)
 
 .globl lowlevel_init

lowlevel_init:

Dear Ilko Iliev,

Quoted 20 lines · In message <[email protected]> you wrote:

This patch allows to have an at91 board specific lowlevel_init.S

Signed-off-by Ilko Iliev <[email protected]>

index ec6ad5d..7882e89 100644

cpu/arm926ejs/at91/lowlevel_init.S +1 -1

@@ -27,7 +27,7 @@
 #include <config.h>
 #include <version.h>
 
-#ifndef CONFIG_SKIP_LOWLEVEL_INIT
+#if !defined(CONFIG_SKIP_LOWLEVEL_INIT) && 
 !defined(CONFIG_USER_LOWLEVEL_INIT)
 
 .globl lowlevel_init

lowlevel_init:

cpu/arm926ejs/at91/lowlevel_init.S +0 -0

@@ -39,5 +39,5 @@ lowlevel_init:
        mov     pc, lr
 

cpu/arm926ejs/at91/lowlevel_init.S lowlevel_init: · line 43

Quoted 6 lines

cpu/arm926ejs/at91/lowlevel_init.S +2 -2

        .ltorg
-
-#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
+
+#endif /* !CONFIG_SKIP_LOWLEVEL_INIT && !CONFIG_USER_LOWLEVEL_INIT */

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

Quoted 24 lines · Wolfgang Denk

Dear Ilko Iliev,

Quoted 20 lines · In message <[email protected]> you wrote:

This patch allows to have an at91 board specific lowlevel_init.S

Signed-off-by Ilko Iliev <[email protected]>

index ec6ad5d..7882e89 100644

cpu/arm926ejs/at91/lowlevel_init.S +1 -1

@@ -27,7 +27,7 @@
 #include <config.h>
 #include <version.h>
 
-#ifndef CONFIG_SKIP_LOWLEVEL_INIT
+#if !defined(CONFIG_SKIP_LOWLEVEL_INIT) && 
 !defined(CONFIG_USER_LOWLEVEL_INIT)
 
 .globl lowlevel_init

lowlevel_init:

cpu/arm926ejs/at91/lowlevel_init.S +0 -0

@@ -39,5 +39,5 @@ lowlevel_init:
        mov     pc, lr
 

Quoted 10 lines

cpu/arm926ejs/at91/lowlevel_init.S lowlevel_init: · line 43

Quoted 6 lines

cpu/arm926ejs/at91/lowlevel_init.S +2 -2

        .ltorg
-
-#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
+
+#endif /* !CONFIG_SKIP_LOWLEVEL_INIT && !CONFIG_USER_LOWLEVEL_INIT */

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work. There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Quoted 4 lines

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work.

There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Dear Ilko Iliev,

Quoted 7 lines · In message <[email protected]> you wrote:

Quoted 4 lines

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work.

What do you mean by "attribute .weak doesn't work" ?

Quoted 3 lines

There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Well, if you don't know, then don't ask me, ask your compiler - he knows how to do this.

For example, common/cmd_boot.c has this code snippet right at the beginning:

30
31 /* Allow ports to override the default behavior */
32 __attribute__((weak))
33 unsigned long do_go_exec (ulong (*entry)(int, char *[]), int argc, char *argv[]) 34 {
35 return entry (argc, argv);
36 }

Compile this with -S option, and you get this:

12 .Ltext0:

 13         .align 2
 14         .weak   do_go_exec
 15         .type   do_go_exec, @function

16 do_go_exec:
17 .LFB87:
18 .file 1 "cmd_boot.c"
19 .loc 1 34 0
20 .LVL0:
21 mflr 0
22 .LCFI0:
23 stwu 1,-16(1)
...

So to me it seems as if the attribute .weak is supposed to work just fine.

What exactly is not working for you?

Dear Mr. Denk,

Quoted 50 lines

Dear Ilko Iliev,

Quoted 7 lines · In message <[email protected]> you wrote:

Quoted 4 lines

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work.

What do you mean by "attribute .weak doesn't work" ?

Quoted 3 lines

There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Well, if you don't know, then don't ask me, ask your compiler - he knows how to do this.

For example, common/cmd_boot.c has this code snippet right at the beginning:

30
31 /* Allow ports to override the default behavior */
32 __attribute__((weak))
33 unsigned long do_go_exec (ulong (*entry)(int, char *[]), int argc, char *argv[]) 34 {
35 return entry (argc, argv);
36 }

Compile this with -S option, and you get this:

12 .Ltext0:

 13         .align 2
 14         .weak   do_go_exec
 15         .type   do_go_exec, @function

16 do_go_exec:
17 .LFB87:
18 .file 1 "cmd_boot.c"
19 .loc 1 34 0
20 .LVL0:
21 mflr 0
22 .LCFI0:
23 stwu 1,-16(1)
...

Quoted 5 lines

So to me it seems as if the attribute .weak is supposed to work just fine.

What exactly is not working for you?

With ".weak lowlevel_init" the function is marked as weak (I can see this in the ELF file) but it is not overwritten from the another lowlevel_init().

Quoted 62 lines · Ilko Iliev

Dear Mr. Denk,

Quoted 59 lines

Dear Ilko Iliev,

Quoted 9 lines · In message <[email protected]> you wrote:

Quoted 5 lines

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work.

What do you mean by "attribute .weak doesn't work" ?

Quoted 4 lines

There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Well, if you don't know, then don't ask me, ask your compiler - he knows how to do this.

For example, common/cmd_boot.c has this code snippet right at the beginning:

30
31 /* Allow ports to override the default behavior */
32 __attribute__((weak))
33 unsigned long do_go_exec (ulong (*entry)(int, char *[]), int argc, char *argv[]) 34 {
35 return entry (argc, argv);
36 }

Compile this with -S option, and you get this:

12 .Ltext0:

 13         .align 2
 14         .weak   do_go_exec
 15         .type   do_go_exec, @function

16 do_go_exec:
17 .LFB87:
18 .file 1 "cmd_boot.c"
19 .loc 1 34 0
20 .LVL0:
21 mflr 0
22 .LCFI0:
23 stwu 1,-16(1)
...

So to me it seems as if the attribute .weak is supposed to work just fine.

What exactly is not working for you?

Quoted 4 lines

With ".weak lowlevel_init" the function is marked as weak (I can see this in the ELF file) but it is not overwritten from the another lowlevel_init().

try
.weak __default_lowlevel_init = lowlevel_init

Quoted 62 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 60 lines · Ilko Iliev

Dear Mr. Denk,

Quoted 48 lines

Dear Ilko Iliev,

Quoted 7 lines · In message <[email protected]> you wrote:

Quoted 4 lines

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work.

What do you mean by "attribute .weak doesn't work" ?

Quoted 3 lines

There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Well, if you don't know, then don't ask me, ask your compiler - he knows how to do this.

For example, common/cmd_boot.c has this code snippet right at the beginning:

30
31 /* Allow ports to override the default behavior */
32 __attribute__((weak))
33 unsigned long do_go_exec (ulong (*entry)(int, char *[]), int argc, char *argv[]) 34 {
35 return entry (argc, argv);
36 }

Compile this with -S option, and you get this:

12 .Ltext0:

 13         .align 2
 14         .weak   do_go_exec
 15         .type   do_go_exec, @function

16 do_go_exec:
17 .LFB87:
18 .file 1 "cmd_boot.c"
19 .loc 1 34 0
20 .LVL0:
21 mflr 0
22 .LCFI0:
23 stwu 1,-16(1)
...

Quoted 5 lines

So to me it seems as if the attribute .weak is supposed to work just fine.

What exactly is not working for you?

With ".weak lowlevel_init" the function is marked as weak (I can see this in the ELF file) but it is not overwritten from the another lowlevel_init().

Quoted 3 lines

try

I tried and the result is:
lowlevel_init.S:32: Error: junk at end of line, first unrecognized character is `='

Quoted 79 lines · Ilko Iliev

Quoted 66 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 63 lines · Ilko Iliev

Dear Mr. Denk,

Quoted 59 lines

Dear Ilko Iliev,

Quoted 9 lines · In message <[email protected]> you wrote:

Quoted 5 lines

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work.

What do you mean by "attribute .weak doesn't work" ?

Quoted 4 lines

There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Well, if you don't know, then don't ask me, ask your compiler - he knows how to do this.

For example, common/cmd_boot.c has this code snippet right at the beginning:

30
31 /* Allow ports to override the default behavior */
32 __attribute__((weak))
33 unsigned long do_go_exec (ulong (*entry)(int, char *[]), int argc, char *argv[]) 34 {
35 return entry (argc, argv);
36 }

Compile this with -S option, and you get this:

12 .Ltext0:

 13         .align 2
 14         .weak   do_go_exec
 15         .type   do_go_exec, @function

16 do_go_exec:
17 .LFB87:
18 .file 1 "cmd_boot.c"
19 .loc 1 34 0
20 .LVL0:
21 mflr 0
22 .LCFI0:
23 stwu 1,-16(1)
...

So to me it seems as if the attribute .weak is supposed to work just fine.

What exactly is not working for you?

Quoted 11 lines

Quoted 5 lines

With ".weak lowlevel_init" the function is marked as weak (I can see this in the ELF file) but it is not overwritten from the another lowlevel_init().

try

Quoted 5 lines

I tried and the result is:
lowlevel_init.S:32: Error: junk at end of line, first unrecognized character is `='

	sorry try this

	.global __default_lowlevel_init
		.....
	.weak	lowlevel_init
	.set	lowlevel_init,__default_lowlevel_init

	after in the other asm
	.global lowlevel_init
		.......

Best Regards,
J.

Quoted 97 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 79 lines · Ilko Iliev

Quoted 66 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 63 lines · Ilko Iliev

Dear Mr. Denk,

Quoted 59 lines

Dear Ilko Iliev,

Quoted 9 lines · In message <[email protected]> you wrote:

Quoted 5 lines

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work.

What do you mean by "attribute .weak doesn't work" ?

Quoted 4 lines

There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Well, if you don't know, then don't ask me, ask your compiler - he knows how to do this.

For example, common/cmd_boot.c has this code snippet right at the beginning:

30
31 /* Allow ports to override the default behavior */
32 __attribute__((weak))
33 unsigned long do_go_exec (ulong (*entry)(int, char *[]), int argc, char *argv[]) 34 {
35 return entry (argc, argv);
36 }

Compile this with -S option, and you get this:

12 .Ltext0:

 13         .align 2
 14         .weak   do_go_exec
 15         .type   do_go_exec, @function

16 do_go_exec:
17 .LFB87:
18 .file 1 "cmd_boot.c"
19 .loc 1 34 0
20 .LVL0:
21 mflr 0
22 .LCFI0:
23 stwu 1,-16(1)
...

So to me it seems as if the attribute .weak is supposed to work just fine.

What exactly is not working for you?

Quoted 11 lines

Quoted 5 lines

With ".weak lowlevel_init" the function is marked as weak (I can see this in the ELF file) but it is not overwritten from the another lowlevel_init().

try

Quoted 5 lines

I tried and the result is:
lowlevel_init.S:32: Error: junk at end of line, first unrecognized character is `='

	sorry try this

	.global __default_lowlevel_init
		.....
	.weak	lowlevel_init
	.set	lowlevel_init,__default_lowlevel_init

	after in the other asm
	.global lowlevel_init
		.......

Quoted 3 lines

Best Regards,
J.

Still doesn't work - the lowlevel_init is weak, but not overwritten.

It works only if the second (strong) function is in the same archive. Maybe this is a bug of the linker.

Quoted 117 lines · Ilko Iliev

Quoted 115 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 91 lines · Ilko Iliev

Quoted 74 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 70 lines · Ilko Iliev

Dear Mr. Denk,

Quoted 65 lines

Dear Ilko Iliev,

Quoted 11 lines · In message <[email protected]> you wrote:

Quoted 6 lines

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work.

What do you mean by "attribute .weak doesn't work" ?

Quoted 5 lines

There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Well, if you don't know, then don't ask me, ask your compiler - he knows how to do this.

For example, common/cmd_boot.c has this code snippet right at the beginning:

30
31 /* Allow ports to override the default behavior */
32 __attribute__((weak))
33 unsigned long do_go_exec (ulong (*entry)(int, char *[]), int argc, char *argv[]) 34 {
35 return entry (argc, argv);
36 }

Compile this with -S option, and you get this:

12 .Ltext0:

 13         .align 2
 14         .weak   do_go_exec
 15         .type   do_go_exec, @function

16 do_go_exec:
17 .LFB87:
18 .file 1 "cmd_boot.c"
19 .loc 1 34 0
20 .LVL0:
21 mflr 0
22 .LCFI0:
23 stwu 1,-16(1)
...

So to me it seems as if the attribute .weak is supposed to work just fine.

What exactly is not working for you?

Quoted 14 lines

Quoted 6 lines

With ".weak lowlevel_init" the function is marked as weak (I can see this in the ELF file) but it is not overwritten from the another lowlevel_init().

try

Quoted 6 lines

I tried and the result is:
lowlevel_init.S:32: Error: junk at end of line, first unrecognized character is `='

	sorry try this

	.global __default_lowlevel_init
		.....
	.weak	lowlevel_init
	.set	lowlevel_init,__default_lowlevel_init

	after in the other asm
	.global lowlevel_init
		.......

Best Regards,
J.

Quoted 6 lines

Still doesn't work - the lowlevel_init is weak, but not overwritten.

It works only if the second (strong) function is in the same archive. Maybe this is a bug of the linker.

Do you specify that the 2 is type "func"

Quoted 119 lines · Ilko Iliev

Quoted 111 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 91 lines · Ilko Iliev

Quoted 74 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 70 lines · Ilko Iliev

Dear Mr. Denk,

Quoted 65 lines

Dear Ilko Iliev,

Quoted 11 lines · In message <[email protected]> you wrote:

Quoted 6 lines

Maybe instead of adding mor #ifdef'ery here, we can turn lowlevel_init() into a "weak" function that can be redefined by board specific code?

The lowlevel_init() is an assembler function called from another assembler function and the attribute .weak doesn't work.

What do you mean by "attribute .weak doesn't work" ?

Quoted 5 lines

There are no assembler file in the U-BOOT tree which use weak functions. Do you know how can I make an assembler function weak?

Well, if you don't know, then don't ask me, ask your compiler - he knows how to do this.

For example, common/cmd_boot.c has this code snippet right at the beginning:

30
31 /* Allow ports to override the default behavior */
32 __attribute__((weak))
33 unsigned long do_go_exec (ulong (*entry)(int, char *[]), int argc, char *argv[]) 34 {
35 return entry (argc, argv);
36 }

Compile this with -S option, and you get this:

12 .Ltext0:

 13         .align 2
 14         .weak   do_go_exec
 15         .type   do_go_exec, @function

16 do_go_exec:
17 .LFB87:
18 .file 1 "cmd_boot.c"
19 .loc 1 34 0
20 .LVL0:
21 mflr 0
22 .LCFI0:
23 stwu 1,-16(1)
...

So to me it seems as if the attribute .weak is supposed to work just fine.

What exactly is not working for you?

Quoted 14 lines

Quoted 6 lines

With ".weak lowlevel_init" the function is marked as weak (I can see this in the ELF file) but it is not overwritten from the another lowlevel_init().

try

Quoted 6 lines

I tried and the result is:
lowlevel_init.S:32: Error: junk at end of line, first unrecognized character is `='

	sorry try this

	.global __default_lowlevel_init
		.....
	.weak	lowlevel_init
	.set	lowlevel_init,__default_lowlevel_init

	after in the other asm
	.global lowlevel_init
		.......

Quoted 4 lines

Best Regards,
J.

Still doesn't work - the lowlevel_init is weak, but not overwritten.

Quoted 4 lines

It works only if the second (strong) function is in the same archive. Maybe this is a bug of the linker.

Do you specify that the 2 is type "func"

Best Regards,
J.

I tried several variants to make the function lowlevel_init() weak but without success.
If there is no other solution for the problem could you commit my patch. Without this patch I can't post the patch for our PM9261 and PM9263 boards.

Hi Ilko,

Ilko Iliev wrote:
<snip>

Quoted 6 lines

I tried several variants to make the function lowlevel_init() weak but without success.
If there is no other solution for the problem could you commit my patch. Without this patch I can't post the patch for our PM9261 and PM9263 boards.

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

Quoted 12 lines · Ben Warren

Hi Ilko,

Ilko Iliev wrote:
<snip>

Quoted 7 lines

I tried several variants to make the function lowlevel_init() weak but without success.
If there is no other solution for the problem could you commit my patch. Without this patch I can't post the patch for our PM9261 and PM9263 boards.

Quoted 6 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

I've found a solution but it's need to update the all u-boot linking method.

Move from AR to LD.

Which need some work to fit on all boards.

Best Regards,
J.

Quoted 2 lines · Ben Warren

Quoted 5 lines

Quoted 5 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

Could be possible to commit my patch (I need it for the PM9261/PM9263

patches) because the moving from AR to LD will take a lot of time. When the moving from AR to LD is done, I will correct my board's patches.

Otherwise I must wait a lot of time and must change my patches every time when there is an correction in the at91 platform.

Quoted 6 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

I've found a solution but it's need to update the all u-boot linking method.

Move from AR to LD.

Which need some work to fit on all boards.

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 8 lines · In message <[email protected]> you wrote:

Quoted 6 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

I've found a solution but it's need to update the all u-boot linking method.

Quoted 1 line

Move from AR to LD.

Well, that is exactly what Ben just described.

Quoted 1 line

Which need some work to fit on all boards.

Well, actually only the file lowlevel_init.o needs to be treated that way, so the needed hcanges look not too complicated to me.

Quoted 17 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 10 lines · In message <[email protected]> you wrote:

Quoted 6 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

I've found a solution but it's need to update the all u-boot linking method.

Move from AR to LD.

Well, that is exactly what Ben just described.

Quoted 5 lines

Quoted 2 lines

Which need some work to fit on all boards.

Well, actually only the file lowlevel_init.o needs to be treated that way, so the needed hcanges look not too complicated to me.

I'll send a patch to move cpu/at91 to it only and an example to use it with board dir

Dear Jean-Christophe,

Quoted 27 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 14 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 10 lines · In message <[email protected]> you wrote:

Quoted 6 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

I've found a solution but it's need to update the all u-boot linking method.

Move from AR to LD.

Quoted 8 lines

Well, that is exactly what Ben just described.

Quoted 2 lines

Which need some work to fit on all boards.

Well, actually only the file lowlevel_init.o needs to be treated that way, so the needed hcanges look not too complicated to me.

I'll send a patch to move cpu/at91 to it only and an example to use it with board dir

Quoted 39 lines · Ilko Iliev

Dear Jean-Christophe,

Quoted 35 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 21 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 7 lines · In message <[email protected]> you wrote:

Quoted 7 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

Quoted 5 lines

I've found a solution but it's need to update the all u-boot linking method.

Move from AR to LD.

Well, that is exactly what Ben just described.

Quoted 7 lines

Quoted 3 lines

Which need some work to fit on all boards.

Well, actually only the file lowlevel_init.o needs to be treated that way, so the needed hcanges look not too complicated to me.

I'll send a patch to move cpu/at91 to it only and an example to use it with board dir

Could you try this

config.mk +3 -0

index 5a9334c..0d81ab3 100644
@@ -80,6 +80,9 @@ STRIP	= $(CROSS_COMPILE)strip
 OBJCOPY = $(CROSS_COMPILE)objcopy
 OBJDUMP = $(CROSS_COMPILE)objdump
 RANLIB	= $(CROSS_COMPILE)RANLIB
+cmd_link_o_target = $(if $(strip $(2)),\
+			$(LD) $(PLATFORM_LDFLAGS) -r -o $(1) $(2) ,\
+			rm -f $@; $(AR) rcs $(1))
 
 #########################################################################
 

cpu/arm926ejs/at91/Makefile +1 -1

index 2d2a888..662657c 100644
@@ -36,7 +36,7 @@ OBJS    := $(addprefix $(obj),$(SOBJS) $(COBJS-y))
 all:	$(obj).depend $(LIB)
 
 $(LIB):	$(OBJS)
-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $@, $(OBJS))
 
 #########################################################################
 

and modify your board lib build by

cpu/arm926ejs/at91/Makefile +1 -1

-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $@, $(OBJS))

Best Regards,
J.

Dear Jean,

Quoted 76 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 39 lines · Ilko Iliev

Dear Jean-Christophe,

Quoted 35 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 21 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 7 lines · In message <[email protected]> you wrote:

Quoted 7 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

Quoted 5 lines

I've found a solution but it's need to update the all u-boot linking method.

Move from AR to LD.

Well, that is exactly what Ben just described.

Quoted 7 lines

Quoted 3 lines

Which need some work to fit on all boards.

Well, actually only the file lowlevel_init.o needs to be treated that way, so the needed hcanges look not too complicated to me.

I'll send a patch to move cpu/at91 to it only and an example to use it with board dir

Could you try this

config.mk +3 -0

index 5a9334c..0d81ab3 100644
@@ -80,6 +80,9 @@ STRIP	= $(CROSS_COMPILE)strip
 OBJCOPY = $(CROSS_COMPILE)objcopy
 OBJDUMP = $(CROSS_COMPILE)objdump
 RANLIB	= $(CROSS_COMPILE)RANLIB
+cmd_link_o_target = $(if $(strip $(2)),\
+			$(LD) $(PLATFORM_LDFLAGS) -r -o $(1) $(2) ,\
+			rm -f $@; $(AR) rcs $(1))
 
 #########################################################################
 

cpu/arm926ejs/at91/Makefile +1 -1

index 2d2a888..662657c 100644
@@ -36,7 +36,7 @@ OBJS    := $(addprefix $(obj),$(SOBJS) $(COBJS-y))
 all:	$(obj).depend $(LIB)
 
 $(LIB):	$(OBJS)
-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $@, $(OBJS))
 
 #########################################################################
 

and modify your board lib build by

cpu/arm926ejs/at91/Makefile +1 -1

-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $@, $(OBJS))

Quoted 3 lines

Best Regards,
J.

Your patch doesn't resolve the problem - the lowlevel_init.o is still a part of libat91.s:
arm-elf-ld -r -o libat91.a lowlevel_init.o timer.o spi.o usb.o make[1]: Leaving directory `/home/develop/u-boot-last/u-boot/u-boot-2008-11-03/u-boot/cpu/arm926ejs/at91'

The attribute ".weak" works only if the file where is the weak function is not in a library.

Quoted 3 lines

The attribute ".weak" works only if the file where is the weak function is not in a library.

This method of build will not generate a library evenif it's still called libat91.a, it will generate a pre-built object.

Quoted 100 lines · Ilko Iliev

Dear Jean,

Quoted 86 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 48 lines · Ilko Iliev

Dear Jean-Christophe,

Quoted 43 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 25 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 8 lines · In message <[email protected]> you wrote:

Quoted 8 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

Quoted 6 lines

I've found a solution but it's need to update the all u-boot linking method.

Move from AR to LD.

Well, that is exactly what Ben just described.

Quoted 9 lines

Quoted 4 lines

Which need some work to fit on all boards.

Well, actually only the file lowlevel_init.o needs to be treated that way, so the needed hcanges look not too complicated to me.

I'll send a patch to move cpu/at91 to it only and an example to use it with board dir

Could you try this

config.mk +3 -0

index 5a9334c..0d81ab3 100644
@@ -80,6 +80,9 @@ STRIP	= $(CROSS_COMPILE)strip
 OBJCOPY = $(CROSS_COMPILE)objcopy
 OBJDUMP = $(CROSS_COMPILE)objdump
 RANLIB	= $(CROSS_COMPILE)RANLIB
+cmd_link_o_target = $(if $(strip $(2)),\
+			$(LD) $(PLATFORM_LDFLAGS) -r -o $(1) $(2) ,\
+			rm -f $@; $(AR) rcs $(1))
 
 #########################################################################
 

cpu/arm926ejs/at91/Makefile +1 -1

index 2d2a888..662657c 100644
@@ -36,7 +36,7 @@ OBJS    := $(addprefix $(obj),$(SOBJS) $(COBJS-y))
 all:	$(obj).depend $(LIB)
 
 $(LIB):	$(OBJS)
-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $@, $(OBJS))
 
 #########################################################################
 

and modify your board lib build by

cpu/arm926ejs/at91/Makefile +1 -1

-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $@, $(OBJS))

Quoted 4 lines

Best Regards,
J.

Your patch doesn't resolve the problem - the lowlevel_init.o is still a part of libat91.s:
arm-elf-ld -r -o libat91.a lowlevel_init.o timer.o spi.o usb.o make[1]: Leaving directory `/home/develop/u-boot-last/u-boot/u-boot-2008-11-03/u-boot/cpu/arm926ejs/at91'

Quoted 3 lines

The attribute ".weak" works only if the file where is the weak function is not in a library.

This method of build will not generate a library evenif it's still called libat91.a, it will generate a pre-built object.

Quoted 100 lines · Ilko Iliev

Dear Jean,

Quoted 86 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 48 lines · Ilko Iliev

Dear Jean-Christophe,

Quoted 43 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 25 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 8 lines · In message <[email protected]> you wrote:

Quoted 8 lines

I've found that weak functions are only overwritten if the overwriting function is in a file (not archive) that has strongly-linked symbols. Admittedly, I've only done this with C code but expect that the assembly equivalent works the same way. The idea of using weak functions seems great, but suffers from some pretty cumbersome weaknesses :)

Quoted 6 lines

I've found a solution but it's need to update the all u-boot linking method.

Move from AR to LD.

Well, that is exactly what Ben just described.

Quoted 9 lines

Quoted 4 lines

Which need some work to fit on all boards.

Well, actually only the file lowlevel_init.o needs to be treated that way, so the needed hcanges look not too complicated to me.

I'll send a patch to move cpu/at91 to it only and an example to use it with board dir

Could you try this

config.mk +3 -0

index 5a9334c..0d81ab3 100644
@@ -80,6 +80,9 @@ STRIP	= $(CROSS_COMPILE)strip
 OBJCOPY = $(CROSS_COMPILE)objcopy
 OBJDUMP = $(CROSS_COMPILE)objdump
 RANLIB	= $(CROSS_COMPILE)RANLIB
+cmd_link_o_target = $(if $(strip $(2)),\
+			$(LD) $(PLATFORM_LDFLAGS) -r -o $(1) $(2) ,\
+			rm -f $@; $(AR) rcs $(1))
 
 #########################################################################
 

cpu/arm926ejs/at91/Makefile +1 -1

index 2d2a888..662657c 100644
@@ -36,7 +36,7 @@ OBJS    := $(addprefix $(obj),$(SOBJS) $(COBJS-y))
 all:	$(obj).depend $(LIB)
 
 $(LIB):	$(OBJS)
-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $@, $(OBJS))
 
 #########################################################################
 

and modify your board lib build by

cpu/arm926ejs/at91/Makefile +1 -1

-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $@, $(OBJS))

Quoted 4 lines

Best Regards,
J.

Your patch doesn't resolve the problem - the lowlevel_init.o is still a part of libat91.s:
arm-elf-ld -r -o libat91.a lowlevel_init.o timer.o spi.o usb.o make[1]: Leaving directory `/home/develop/u-boot-last/u-boot/u-boot-2008-11-03/u-boot/cpu/arm926ejs/at91'

Quoted 3 lines

The attribute ".weak" works only if the file where is the weak function is not in a library.

This method of build will not generate a library evenif it's still called libat91.a, it will generate a pre-built object.