Skip to contentSkip to conversation

i2c-mux ACPI parent device references in example

DISCUSSION Jonas Gorski 2 participants 5 messages Oct 8, 2025 – Oct 27, 2025 ACPI

lore
Share & tools
lore
#0 lore raw

Hi,

I'm currently trying to wrap my head around describing devices via SSDT.

While reading Documentation/firmware-guide/acpi/i2c-muxes.rst, the references used for the devices behind the mux confuse me a bit.

The tree from the example is:

    Device (SMB1)
    {
        Device (MUX0)
        {
            Device (CH00)
            {
                Device (CLIA)
                {
                    Name (_CRS, ResourceTemplate () {
                        I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
                                    AddressingMode7Bit, "\\_SB.SMB1.CH00", 0x00,
                                    ResourceConsumer,,)
                    }
                }
            }

            Device (CH01)
            {
                Device (CLIB)
                {
                    Name (_CRS, ResourceTemplate () {
                        I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
                                    AddressingMode7Bit, "\\_SB.SMB1.CH01", 0x00,
                                    ResourceConsumer,,)
                    }
                }
            }
        }
    }

Is there a ".MUX0" missing in the references, or is it correct that it is not present?

E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?

FWIW, the references were changed from relative to absolute in e65cb011349e ("Documentation: ACPI: Fix parent device references").

Best regards,
Jonas

#1 lore raw
Quoted 40 lines · Jonas Gorski

Hi,

I'm currently trying to wrap my head around describing devices via SSDT.

While reading Documentation/firmware-guide/acpi/i2c-muxes.rst, the references used for the devices behind the mux confuse me a bit.

The tree from the example is:

    Device (SMB1)
    {
        Device (MUX0)
        {
            Device (CH00)
            {
                Device (CLIA)
                {
                    Name (_CRS, ResourceTemplate () {
                        I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
                                    AddressingMode7Bit, "\\_SB.SMB1.CH00", 0x00,
                                    ResourceConsumer,,)
                    }
                }
            }

            Device (CH01)
            {
                Device (CLIB)
                {
                    Name (_CRS, ResourceTemplate () {
                        I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
                                    AddressingMode7Bit, "\\_SB.SMB1.CH01", 0x00,
                                    ResourceConsumer,,)
                    }
                }
            }
        }
    }
Quoted 7 lines

Is there a ".MUX0" missing in the references, or is it correct that it is not present?

E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?

FWIW, the references were changed from relative to absolute in e65cb011349e ("Documentation: ACPI: Fix parent device references").

Oh, seems to me like a miss from my side. Thanks for a good catch! Can you send a formal fix patch?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

Hi,

Quoted 45 lines · Andy Shevchenko
Quoted 43 lines · Jonas Gorski

Hi,

I'm currently trying to wrap my head around describing devices via SSDT.

While reading Documentation/firmware-guide/acpi/i2c-muxes.rst, the references used for the devices behind the mux confuse me a bit.

The tree from the example is:

    Device (SMB1)
    {
        Device (MUX0)
        {
            Device (CH00)
            {
                Device (CLIA)
                {
                    Name (_CRS, ResourceTemplate () {
                        I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
                                    AddressingMode7Bit, "\\_SB.SMB1.CH00", 0x00,
                                    ResourceConsumer,,)
                    }
                }
            }

            Device (CH01)
            {
                Device (CLIB)
                {
                    Name (_CRS, ResourceTemplate () {
                        I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
                                    AddressingMode7Bit, "\\_SB.SMB1.CH01", 0x00,
                                    ResourceConsumer,,)
                    }
                }
            }
        }
    }

Is there a ".MUX0" missing in the references, or is it correct that it is not present?

Quoted 7 lines
Quoted 4 lines

E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?

FWIW, the references were changed from relative to absolute in e65cb011349e ("Documentation: ACPI: Fix parent device references").

Oh, seems to me like a miss from my side. Thanks for a good catch! Can you send a formal fix patch?

Was my plan until my internet connection went down yesterday. Will send it out once it's back.

Best regards,
Jonas

#3 lore raw
Quoted 3 lines · Jonas Gorski
Quoted 1 line · Andy Shevchenko

On Wed, Oct 08, 2025 at 11:14:37AM +0200, Jonas Gorski wrote:

...

Quoted 10 lines
Quoted 7 lines
Quoted 4 lines

E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?

FWIW, the references were changed from relative to absolute in e65cb011349e ("Documentation: ACPI: Fix parent device references").

Oh, seems to me like a miss from my side. Thanks for a good catch! Can you send a formal fix patch?

Was my plan until my internet connection went down yesterday. Will send it out once it's back.

Is it okay now? Or did I miss the patch?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 13 lines · Andy Shevchenko
Quoted 3 lines · Jonas Gorski
Quoted 1 line · Andy Shevchenko

On Wed, Oct 08, 2025 at 11:14:37AM +0200, Jonas Gorski wrote:

...

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?

FWIW, the references were changed from relative to absolute in e65cb011349e ("Documentation: ACPI: Fix parent device references").

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Oh, seems to me like a miss from my side. Thanks for a good catch! Can you send a formal fix patch?

Was my plan until my internet connection went down yesterday. Will send it out once it's back.

Is it okay now? Or did I miss the patch?

Getting it fixed took longer than expected, then other things took priority.

Patch should be now in your inbox (I hope I got the terminology right).

Best regards,
Jonas