Skip to contentSkip to conversation

net/mlx5e: remove unnecessary memset

PATCH Applied Zhu Yanjun 2 participants 2 messages Nov 7, 2020 – Nov 10, 2020

Subsystems (3)
lore
Share & tools
lore

Zhu Yanjun

author
#0 lore raw

PATCH 1/1 net/mlx5e: remove unnecessary memset

Since kvzalloc will initialize the allocated memory, it is not necessary to initialize it once again.

Fixes 11b717d61526 ("net/mlx5: E-Switch, Get reg_c0 value on CQE")
---
 .../ethernet/mellanox/mlx5/core/eswitch_offloads.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +0 -1
index 1bcf260..35c5629 100644
@@ -1528,7 +1528,6 @@ static int esw_create_restore_table(struct mlx5_eswitch *esw)
 		goto out_free;
 	}
 
-	memset(flow_group_in, 0, inlen);
 	match_criteria = MLX5_ADDR_OF(create_flow_group_in, flow_group_in,
 				      match_criteria);
 	misc = MLX5_ADDR_OF(fte_match_param, match_criteria,
Signature · 1 line
1.7.1
#1 lore raw
Quoted 23 lines · Zhu Yanjun

Since kvzalloc will initialize the allocated memory, it is not necessary to initialize it once again.

Fixes 11b717d61526 ("net/mlx5: E-Switch, Get reg_c0 value on CQE")
---
 .../ethernet/mellanox/mlx5/core/eswitch_offloads.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index 1bcf260..35c5629 100644

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +0 -1
@@ -1528,7 +1528,6 @@ static int esw_create_restore_table(struct
 mlx5_eswitch *esw)
 		goto out_free;
 	}
 
-	memset(flow_group_in, 0, inlen);
 	match_criteria = MLX5_ADDR_OF(create_flow_group_in,
 flow_group_in,

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c static int esw_create_restore_table(struct mlx5_eswitch *esw) · line 1533

Quoted 2 lines
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +0 -0
 				      match_criteria);
 	misc = MLX5_ADDR_OF(fte_match_param, match_criteria,

applied to net-next-mlx5,
Thank you !