hw/vfio: Add VMD Passthrough Quirk
Subsystems (4)
PATCH 1/1 hw/vfio: Add VMD Passthrough Quirk
The VMD endpoint provides a real PCIe domain to the guest, including bridges and endpoints. The IOMMU performs Host Physical Address to Guest Physical Address translation when assigning downstream endpoint BARs and when translating MMIO addresses.
This translation is not desired when assigning bridge windows. When MMIO goes to an endpoint after being translated to HPA, the bridge will reject the HPA transaction because the bridge window has been programmed with translated GPAs.
VMD device 28C0 natively supports passthrough by providing the Host Physical Address in shadow registers accessible to the guest for bridge window assignment. The shadow registers are valid if bit 1 is set in VMD VMLOCK config register 0x70.
This quirk emulates the VMLOCK and HPA shadow registers for all VMD device ids which don't natively offer this feature. The Linux VMD driver is updated to match the QEMU subsystem id to enable this feature.
--- hw/vfio/pci-quirks.c | 119 +++++++++++++++++++++++++++++++++++++++++++ hw/vfio/pci.c | 7 +++ hw/vfio/pci.h | 2 + hw/vfio/trace-events | 4 ++ 4 files changed, 132 insertions(+)
hw/vfio/pci-quirks.c +119 -0
@@ -1709,3 +1709,122 @@ free_exit:return ret; } + +/* +* The VMD endpoint provides a real PCIe domain to the guest. The IOMMU +* performs Host Physical Address to Guest Physical Address translation when +* assigning downstream endpoint BARs and when translating MMIO addresses. +* However this translation is not desired when assigning bridge windows. When +* MMIO goes to an endpoint after being translated to HPA, the bridge rejects +* the transaction because the window has been programmed with translated GPAs. +* +* VMD uses the Host Physical Address in order to correctly program the bridge +* windows in its PCIe domain. VMD device 28C0 has HPA shadow registers located +* at offset 0x2000 in MEMBAR2 (BAR 4). The shadow registers are valid if bit 1 +* is set in the VMD VMLOCK config register 0x70. +* +* This quirk emulates the VMLOCK and HPA shadow registers for all VMD device +* ids which don't natively offer this feature. The subsystem vendor/device +* id is set to the QEMU subsystem vendor/device id, where the driver matches +* the id to enable this feature. +*/ +typedef struct VFIOVMDQuirk { +VFIOPCIDevice *vdev; +uint64_t membar_phys[2 ]; +}VFIOVMDQuirk ; + +static uint64_t vfio_vmd_quirk_read (void *opaque,hwaddr addr,unsigned size) +{ +VFIOVMDQuirk *data = opaque; +uint64_t val =0 ; + +memcpy (&val, (void *)data->membar_phys + addr, size); +return val; +} + +static const MemoryRegionOps vfio_vmd_quirk = { + .read = vfio_vmd_quirk_read, + .endianness =DEVICE_LITTLE_ENDIAN , +}; + +#define VMD_VMLOCK 0x70 +#define VMD_SHADOW 0x2000 +#define VMD_MEMBAR2 4 + +static int vfio_vmd_emulate_shadow_registers (VFIOPCIDevice *vdev) +{ +VFIOQuirk *quirk; +VFIOVMDQuirk *data; +PCIDevice *pdev = &vdev->pdev; +int ret; + + data =g_malloc0 (sizeof (*data)); + ret =pread (vdev->vbasedev.fd, data->membar_phys,16 , + vdev->config_offset +PCI_BASE_ADDRESS_2 ); +if (ret !=16 ) { +error_report ("VMD %s cannot read MEMBARs (%d)" , + vdev->vbasedev.name, ret); +g_free (data); +return -EFAULT ; + } + + quirk =vfio_quirk_alloc (1 ); + quirk->data = data; + data->vdev = vdev; + +/* Emulate Shadow Registers */ +memory_region_init_io (quirk->mem,OBJECT (vdev), &vfio_vmd_quirk, data, +"vfio-vmd-quirk" ,sizeof (data->membar_phys)); +memory_region_add_subregion_overlap (vdev->bars[VMD_MEMBAR2 ].region.mem, +VMD_SHADOW , quirk->mem,1 ); +memory_region_set_readonly (quirk->mem, true); +memory_region_set_enabled (quirk->mem, true); + +QLIST_INSERT_HEAD (&vdev->bars[VMD_MEMBAR2 ].quirks, quirk, next); + +trace_vfio_pci_vmd_quirk_shadow_regs (vdev->vbasedev.name, + data->membar_phys[0 ], + data->membar_phys[1 ]); + +/* Advertise Shadow Register support */ +pci_byte_test_and_set_mask (pdev->config +VMD_VMLOCK ,0x2 ); +pci_set_byte (pdev->wmask +VMD_VMLOCK ,0 ); +pci_set_byte (vdev->emulated_config_bits +VMD_VMLOCK ,0x2 ); + +trace_vfio_pci_vmd_quirk_vmlock (vdev->vbasedev.name, +pci_get_byte (pdev->config +VMD_VMLOCK )); + +/* Drivers can match the subsystem vendor/device id */ +pci_set_word (pdev->config +PCI_SUBSYSTEM_VENDOR_ID , +PCI_SUBVENDOR_ID_REDHAT_QUMRANET ); +pci_set_word (vdev->emulated_config_bits +PCI_SUBSYSTEM_VENDOR_ID , ~0 ); + +pci_set_word (pdev->config +PCI_SUBSYSTEM_ID ,PCI_SUBDEVICE_ID_QEMU ); +pci_set_word (vdev->emulated_config_bits +PCI_SUBSYSTEM_ID , ~0 ); + +trace_vfio_pci_vmd_quirk_subsystem (vdev->vbasedev.name, + vdev->sub_vendor_id, vdev->sub_device_id, +pci_get_word (pdev->config +PCI_SUBSYSTEM_VENDOR_ID ), +pci_get_word (pdev->config +PCI_SUBSYSTEM_ID )); + +return 0 ; +} + +int vfio_pci_vmd_init (VFIOPCIDevice *vdev) +{ +int ret =0 ; + +switch (vdev->device_id) { +case 0x28C0 :/* Native passthrough support */ +break ; +/* Emulates Native passthrough support */ +case 0x201D : +case 0x467F : +case 0x4C3D : +case 0x9A0B : + ret =vfio_vmd_emulate_shadow_registers (vdev); +break ; + } + +return ret; +}
hw/vfio/pci.c +7 -0
@@ -3024,6 +3024,13 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) } } +if (vdev->vendor_id ==PCI_VENDOR_ID_INTEL ) { + ret =vfio_pci_vmd_init (vdev); +if (ret) { +error_report ("Failed to setup VMD" ); + } + } +vfio_register_err_notifier (vdev);vfio_register_req_notifier (vdev);vfio_setup_resetfn_quirk (vdev);
hw/vfio/pci.h +2 -0
@@ -217,6 +217,8 @@ int vfio_pci_igd_opregion_init(VFIOPCIDevice *vdev,int vfio_pci_nvidia_v100_ram_init (VFIOPCIDevice *vdev,Error **errp);int vfio_pci_nvlink2_init (VFIOPCIDevice *vdev,Error **errp); +int vfio_pci_vmd_init (VFIOPCIDevice *vdev); +void vfio_display_reset (VFIOPCIDevice *vdev);int vfio_display_probe (VFIOPCIDevice *vdev,Error **errp);void vfio_display_finalize (VFIOPCIDevice *vdev);
hw/vfio/trace-events +4 -0
@@ -90,6 +90,10 @@ vfio_pci_nvidia_gpu_setup_quirk(const char *name, uint64_t tgt, uint64_t size) " vfio_pci_nvlink2_setup_quirk_ssatgt(const char *name, uint64_t tgt, uint64_t size) "%s tgt=0x%"PRIx64" size=0x%"PRIx64 vfio_pci_nvlink2_setup_quirk_lnkspd(const char *name, uint32_t link_speed) "%s link_speed=0x%x" +vfio_pci_vmd_quirk_shadow_regs(const char *name, uint64_t mb1, uint64_t mb2) "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" +vfio_pci_vmd_quirk_vmlock(const char *name, uint8_t vmlock) "%s vmlock=0x%x" +vfio_pci_vmd_quirk_subsystem(const char *name, uint16_t old_svid, uint16_t old_sdid, uint16_t new_svid, uint16_t new_sdid) "%s subsystem id 0x%04x:0x%04x -> 0x%04x:0x%04x" + # common.c vfio_region_write(const char *name, int index, uint64_t addr, uint64_t data, unsigned size) " (%s:region%d+0x%"PRIx64", 0x%"PRIx64 ", %d)" vfio_region_read(char *name, int index, uint64_t addr, unsigned size, uint64_t data) " (%s:region%d+0x%"PRIx64", %d) = 0x%"PRIx64
Signature · 1 line
2.18.1
PATCH 1/1 pci: vmd: Use Shadow MEMBAR registers for QEMU/KVM guests
VMD device 28C0 provides native guest passthrough of the VMD endpoint through the use of shadow registers that provide Host Physical Addresses to correctly assign bridge windows. A quirk has been added to QEMU's VFIO quirks to emulate the shadow registers for VMD devices which don't support this mode natively in hardware.
The VFIO quirk assigns the VMD a subsystem vendor/device ID using the standard QEMU vendor/device, which are typically only used for emulation and not VFIO. There are no plans for an emulated VMD controller, but if one is developed in the future, support for this mode can be added by emulating the VMD VMLOCK and Shadow MEMBAR registers
--- drivers/pci/controller/vmd.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/pci/controller/vmd.c +7 -1
@@ -598,6 +598,7 @@ static irqreturn_t vmd_irq(int irq, void *data)static int vmd_probe (struct pci_dev *dev,const struct pci_device_id *id) {struct vmd_dev *vmd; +unsigned long features = id->driver_data;int i, err;if (resource_size (&dev->resource[VMD_CFGBAR ]) < (1 <<20 ))
@@ -648,9 +649,14 @@ static int vmd_probe(struct pci_dev *dev, const struct pci_device_id *id)return err; } +/* VFIO-quirked VMD controllers emulate the Shadow MEMBAR feature */ +if (dev->subsystem_vendor ==PCI_SUBVENDOR_ID_REDHAT_QUMRANET && + dev->subsystem_device ==PCI_SUBDEVICE_ID_QEMU ) + features |=VMD_FEAT_HAS_MEMBAR_SHADOW ; +spin_lock_init (&vmd->cfg_lock);pci_set_drvdata (dev, vmd); - err =vmd_enable_domain (vmd, (unsigned long ) id->driver_data); + err =vmd_enable_domain (vmd, features);if (err)return err;
Signature · 1 line
2.18.1
Quoted 190 lines · Jon Derrick
The VMD endpoint provides a real PCIe domain to the guest, including bridges and endpoints. The IOMMU performs Host Physical Address to Guest Physical Address translation when assigning downstream endpoint BARs and when translating MMIO addresses.
This translation is not desired when assigning bridge windows. When MMIO goes to an endpoint after being translated to HPA, the bridge will reject the HPA transaction because the bridge window has been programmed with translated GPAs.
VMD device 28C0 natively supports passthrough by providing the Host Physical Address in shadow registers accessible to the guest for bridge window assignment. The shadow registers are valid if bit 1 is set in VMD VMLOCK config register
0x70.This quirk emulates the VMLOCK and HPA shadow registers for all VMD device ids which don't natively offer this feature. The Linux VMD driver is updated to match the QEMU subsystem id to enable this feature.
Signed-off-by Jon Derrick <[email protected]>--- hw/vfio/pci-quirks.c | 119 +++++++++++++++++++++++++++++++++++++++++++ hw/vfio/pci.c | 7 +++ hw/vfio/pci.h | 2 + hw/vfio/trace-events | 4 ++ 4 files changed, 132 insertions(+)hw/vfio/pci-quirks.c +119
-0@@ -1709,3 +1709,122 @@ free_exit:return ret; } + +/* +* The VMD endpoint provides a real PCIe domain to the guest. The IOMMU +* performs Host Physical Address to Guest Physical Address translation when +* assigning downstream endpoint BARs and when translating MMIO addresses. +* However this translation is not desired when assigning bridge windows. When +* MMIO goes to an endpoint after being translated to HPA, the bridge rejects +* the transaction because the window has been programmed with translated GPAs. +* +* VMD uses the Host Physical Address in order to correctly program the bridge +* windows in its PCIe domain. VMD device 28C0 has HPA shadow registers located +* at offset 0x2000 in MEMBAR2 (BAR 4). The shadow registers are valid if bit 1 +* is set in the VMD VMLOCK config register 0x70. +* +* This quirk emulates the VMLOCK and HPA shadow registers for all VMD device +* ids which don't natively offer this feature. The subsystem vendor/device +* id is set to the QEMU subsystem vendor/device id, where the driver matches +* the id to enable this feature. +*/ +typedef struct VFIOVMDQuirk { +VFIOPCIDevice *vdev; +uint64_t membar_phys[2 ]; +}VFIOVMDQuirk ; + +static uint64_t vfio_vmd_quirk_read (void *opaque,hwaddr addr,unsigned size) +{ +VFIOVMDQuirk *data = opaque; +uint64_t val =0 ; + +memcpy (&val, (void *)data->membar_phys + addr, size); +return val; +} + +static const MemoryRegionOps vfio_vmd_quirk = { + .read = vfio_vmd_quirk_read, + .endianness =DEVICE_LITTLE_ENDIAN , +}; + +#define VMD_VMLOCK 0x70 +#define VMD_SHADOW 0x2000 +#define VMD_MEMBAR2 4 + +static int vfio_vmd_emulate_shadow_registers (VFIOPCIDevice *vdev) +{ +VFIOQuirk *quirk; +VFIOVMDQuirk *data; +PCIDevice *pdev = &vdev->pdev; +int ret; + + data =g_malloc0 (sizeof (*data)); + ret =pread (vdev->vbasedev.fd, data->membar_phys,16 , + vdev->config_offset +PCI_BASE_ADDRESS_2 ); +if (ret !=16 ) { +error_report ("VMD %s cannot read MEMBARs (%d)" , + vdev->vbasedev.name, ret); +g_free (data); +return -EFAULT ; + } + + quirk =vfio_quirk_alloc (1 ); + quirk->data = data; + data->vdev = vdev; + +/* Emulate Shadow Registers */ +memory_region_init_io (quirk->mem,OBJECT (vdev), &vfio_vmd_quirk, data, +"vfio-vmd-quirk" ,sizeof (data->membar_phys)); +memory_region_add_subregion_overlap (vdev->bars[VMD_MEMBAR2 ].region.mem, +VMD_SHADOW , quirk->mem,1 ); +memory_region_set_readonly (quirk->mem, true); +memory_region_set_enabled (quirk->mem, true); + +QLIST_INSERT_HEAD (&vdev->bars[VMD_MEMBAR2 ].quirks, quirk, next); + +trace_vfio_pci_vmd_quirk_shadow_regs (vdev->vbasedev.name, + data->membar_phys[0 ], + data->membar_phys[1 ]); + +/* Advertise Shadow Register support */ +pci_byte_test_and_set_mask (pdev->config +VMD_VMLOCK ,0x2 ); +pci_set_byte (pdev->wmask +VMD_VMLOCK ,0 ); +pci_set_byte (vdev->emulated_config_bits +VMD_VMLOCK ,0x2 ); + +trace_vfio_pci_vmd_quirk_vmlock (vdev->vbasedev.name, +pci_get_byte (pdev->config +VMD_VMLOCK )); + +/* Drivers can match the subsystem vendor/device id */ +pci_set_word (pdev->config +PCI_SUBSYSTEM_VENDOR_ID , +PCI_SUBVENDOR_ID_REDHAT_QUMRANET ); +pci_set_word (vdev->emulated_config_bits +PCI_SUBSYSTEM_VENDOR_ID , ~0 ); + +pci_set_word (pdev->config +PCI_SUBSYSTEM_ID ,PCI_SUBDEVICE_ID_QEMU ); +pci_set_word (vdev->emulated_config_bits +PCI_SUBSYSTEM_ID , ~0 ); + +trace_vfio_pci_vmd_quirk_subsystem (vdev->vbasedev.name, + vdev->sub_vendor_id, vdev->sub_device_id, +pci_get_word (pdev->config +PCI_SUBSYSTEM_VENDOR_ID ), +pci_get_word (pdev->config +PCI_SUBSYSTEM_ID )); + +return 0 ; +} + +int vfio_pci_vmd_init (VFIOPCIDevice *vdev) +{ +int ret =0 ; + +switch (vdev->device_id) { +case 0x28C0 :/* Native passthrough support */ +break ; +/* Emulates Native passthrough support */ +case 0x201D : +case 0x467F : +case 0x4C3D : +case 0x9A0B : + ret =vfio_vmd_emulate_shadow_registers (vdev); +break ; + } + +return ret; +}hw/vfio/pci.c +7
-0@@ -3024,6 +3024,13 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) } } +if (vdev->vendor_id ==PCI_VENDOR_ID_INTEL ) { + ret =vfio_pci_vmd_init (vdev); +if (ret) { +error_report ("Failed to setup VMD" ); + } + } +vfio_register_err_notifier (vdev);vfio_register_req_notifier (vdev);vfio_setup_resetfn_quirk (vdev);hw/vfio/pci.h +2
-0@@ -217,6 +217,8 @@ int vfio_pci_igd_opregion_init(VFIOPCIDevice *vdev,int vfio_pci_nvidia_v100_ram_init (VFIOPCIDevice *vdev,Error **errp);int vfio_pci_nvlink2_init (VFIOPCIDevice *vdev,Error **errp); +int vfio_pci_vmd_init (VFIOPCIDevice *vdev); +void vfio_display_reset (VFIOPCIDevice *vdev);int vfio_display_probe (VFIOPCIDevice *vdev,Error **errp);void vfio_display_finalize (VFIOPCIDevice *vdev);hw/vfio/trace-events +0
-0
hw/vfio/trace-events vfio_pci_nvidia_gpu_setup_quirk(const char *name, uint64_t tgt, uint64_t size) " · line 99
Quoted 10 lines
hw/vfio/trace-events +4
-0@@ -90,6 +90,10 @@ vfio_pci_nvidia_gpu_setup_quirk(const char *name, uint64_t tgt, uint64_t size) " vfio_pci_nvlink2_setup_quirk_ssatgt(const char *name, uint64_t tgt, uint64_t size) "%s tgt=0x%"PRIx64" size=0x%"PRIx64 vfio_pci_nvlink2_setup_quirk_lnkspd(const char *name, uint32_t link_speed) "%s link_speed=0x%x" +vfio_pci_vmd_quirk_shadow_regs(const char *name, uint64_t mb1, uint64_t mb2) "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" +vfio_pci_vmd_quirk_vmlock(const char *name, uint8_t vmlock) "%s vmlock=0x%x" +vfio_pci_vmd_quirk_subsystem(const char *name, uint16_t old_svid, uint16_t old_sdid, uint16_t new_svid, uint16_t new_sdid) "%s subsystem id 0x%04x:0x%04x -> 0x%04x:0x%04x" + # common.c vfio_region_write(const char *name, int index, uint64_t addr, uint64_t data, unsigned size) " (%s:region%d+0x%"PRIx64", 0x%"PRIx64 ", %d)" vfio_region_read(char *name, int index, uint64_t addr, unsigned size, uint64_t data) " (%s:region%d+0x%"PRIx64", %d) = 0x%"PRIx64
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END ===
CC qemu-io-cmds.o
CC replication.o
In file included from hw/vfio/trace.c:5:/tmp/qemu-test/build/hw/vfio/trace.h:2348:120: error: expected ')'
qemu_log("%d@%zu.%06zu:vfio_pci_vmd_quirk_shadow_regs " "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" "\n",
^
/tmp/qemu-test/build/hw/vfio/trace.h:2348:17: note: to match this '('
qemu_log("%d@%zu.%06zu:vfio_pci_vmd_quirk_shadow_regs " "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" "\n",
^
/tmp/qemu-test/build/hw/vfio/trace.h:2348:122: error: missing terminating '"' character [-Werror,-Winvalid-pp-token]
qemu_log("%d@%zu.%06zu:vfio_pci_vmd_quirk_shadow_regs " "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" "\n",
^ CC block/raw-format.o
2 errors generated.
make: *** [/tmp/qemu-test/src/rules.mak:69: hw/vfio/trace.o] Error 1
make: *** Waiting for unfinished jobs....
CC block/vmdk.o
Traceback (most recent call last):
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=231ac96de1674d3b887b1d3b8fd4779c', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=x86_64-softmmu', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-y01wd0hh/src/docker-src.2020-04-22-17.32.38.5605:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-debug']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=231ac96de1674d3b887b1d3b8fd4779c
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-y01wd0hh/src'
make: *** [docker-run-test-debug@fedora] Error 2
real 3m31.279s
user 0m8.228s
The full log is available at
http://patchew.org/logs/[email protected]/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]
Quoted 17 lines · On Wed, 2020-04-22 at 14:36 -0700, [email protected] wrote:
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END ===
Quoted 7 lines
CC qemu-io-cmds.o
CC replication.o
In file included fromhw/vfio/trace.c:5:/tmp/qemu-test/build/hw/vfio/trace.h:2348:120: error: expected ')'qemu_log("%d@%zu.%06zu:vfio_pci_vmd_quirk_shadow_regs " "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" "\n", ^
It's the extra " at the end, which will be fixed in v2 Thanks for the sanity check
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END ===
CC stubs/uuid.o
In file included from hw/vfio/trace.c:5:0:hw/vfio/trace.h: In function '_nocheck__trace_vfio_pci_vmd_quirk_shadow_regs':hw/vfio/trace.h:2348:9: error: stray '\' in program
qemu_log("%d@%zu.%06zu:vfio_pci_vmd_quirk_shadow_regs " "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" "\n",
^
hw/vfio/trace.h:2348:121: error: expected ')' before 'n'
qemu_log("%d@%zu.%06zu:vfio_pci_vmd_quirk_shadow_regs " "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" "\n",
^
hw/vfio/trace.h:2348:122: error: missing terminating " character [-Werror]
qemu_log("%d@%zu.%06zu:vfio_pci_vmd_quirk_shadow_regs " "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" "\n",
^
hw/vfio/trace.h:2348:121: error: missing terminating " character
qemu_log("%d@%zu.%06zu:vfio_pci_vmd_quirk_shadow_regs " "%s membar1_phys=0x%"PRIx64" membar2_phys=0x%"PRIx64" "\n",
^
hw/vfio/trace.h:2351:18: error: format '%d' expects a matching 'int' argument [-Werror=format=]
, name, mb1, mb2);
^hw/vfio/trace.h:2351:18: error: format '%zu' expects a matching 'size_t' argument [-Werror=format=]hw/vfio/trace.h:2351:18: error: format '%zu' expects a matching 'size_t' argument [-Werror=format=]hw/vfio/trace.h:2351:18: error: format '%s' expects a matching 'char *' argument [-Werror=format=]hw/vfio/trace.h:2351:18: error: format '%lx' expects a matching 'long unsigned int' argument [-Werror=format=]hw/vfio/trace.h:2351:18: error: format '%lx' expects a matching 'long unsigned int' argument [-Werror=format=]
CC stubs/vm-stop.o
cc1: all warnings being treated as errors
CC stubs/vmstate.o
make: *** [hw/vfio/trace.o] Error 1
make: *** Waiting for unfinished jobs....
CC stubs/fd-register.o
Traceback (most recent call last):
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=db534fd3eb71499bb0dc521684cf5cb6', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-uce_gd7q/src/docker-src.2020-04-22-17.37.18.14548:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=db534fd3eb71499bb0dc521684cf5cb6
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-uce_gd7q/src'
make: *** [docker-run-test-quick@centos7] Error 2
real 2m17.142s
user 0m8.210s
The full log is available at
http://patchew.org/logs/[email protected]/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]