mac80211: allow all interfaces types to handle RX action frames
PATCH 1/1 mac80211: allow all interfaces types to handle RX action frames
Eliminate the vif.type check in ieee80211_rx_h_action. This check is unnecessary (these action frames can be handled by all interface types) and currently prevents, for example, AP interfaces from handling BACK action frames such as ADDBA and DELBA requests.
Signed-off-by Andrey Yurovsky <[email protected]>
net/mac80211/rx.c +0 -8
@@ -1552,14 +1552,6 @@ ieee80211_rx_h_action(struct ieee80211_rx_data *rx)if (len <IEEE80211_MIN_ACTION_SIZE +1 )return RX_DROP_MONITOR ; -/* -* FIXME: revisit this, I'm sure we should handle most -* of these frames in other modes as well! -*/ -if (sdata->vif.type !=NL80211_IFTYPE_STATION && - sdata->vif.type !=NL80211_IFTYPE_ADHOC ) -return RX_CONTINUE ; -switch (mgmt->u.action.category) {case WLAN_CATEGORY_BACK :switch (mgmt->u.action.u.addba_req.action_code) {
Quoted 6 lines · Andrey Yurovsky
Eliminate the vif.type check in
ieee80211_rx_h_action. This check is unnecessary (these action frames can be handled by all interface types) and currently prevents, for example, AP interfaces from handling BACK action frames such as ADDBA and DELBA requests.Signed-off-by Andrey Yurovsky <[email protected]>
Fine with me.
Acked-by Johannes Berg <[email protected]>
Quoted 22 lines
net/mac80211/rx.c +0
-8@@ -1552,14 +1552,6 @@ ieee80211_rx_h_action(struct ieee80211_rx_data *rx)if (len <IEEE80211_MIN_ACTION_SIZE +1 )return RX_DROP_MONITOR ; -/* -* FIXME: revisit this, I'm sure we should handle most -* of these frames in other modes as well! -*/ -if (sdata->vif.type !=NL80211_IFTYPE_STATION && - sdata->vif.type !=NL80211_IFTYPE_ADHOC ) -return RX_CONTINUE ; -switch (mgmt->u.action.category) {case WLAN_CATEGORY_BACK :switch (mgmt->u.action.u.addba_req.action_code) {