Skip to contentSkip to conversation

x86: checkt rev 3 fadt correctly for physical_apic bit

PATCH New Yinghai Lu 1 participant 1 message Oct 28, 2008 x86

lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw

PATCH 1/1 x86: checkt rev 3 fadt correctly for physical_apic bit

Impact: fix fadt version checking

FADT2_REVISION_ID is 3 aka rev 3 FADT. so need to use >= instead of >

Signed-off-by Yinghai Lu <[email protected]>
---
 arch/x86/kernel/genapic_flat_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/genapic_flat_64.c +1 -1
Index: linux-2.6/arch/x86/kernel/genapic_flat_64.c
===================================================================
@@ -197,7 +197,7 @@ static int physflat_acpi_madt_oem_check(
 	 * regardless of how many processors are present (x86_64 ES7000
 	 * is an example).
 	 */
-	if (acpi_gbl_FADT.header.revision > FADT2_REVISION_ID &&
+	if (acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID &&
 		(acpi_gbl_FADT.flags & ACPI_FADT_APIC_PHYSICAL)) {
 		printk(KERN_DEBUG "system APIC only can use physical flat");
 		return 1;