Skip to contentSkip to conversation

sh: Add '-up' to ISA flag if enable SH3

PATCH In review Nobuhiro Iwamatsu 2 participants 3 messages Oct 29, 2008 – Oct 31, 2008 SuperH

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sh: Add '-up' to ISA flag if enable SH3

By commit of b2d86a3fd9855380598c0c039e712a20086e119f, compilation of SH3 fails. In current binutils, "pref" opcode is not support SH3. However, it is supported. Please validate this flag till fix binutils.

---
 arch/sh/Makefile |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/sh/Makefile +4 -0
index 3a74ed6..b2d46a6 100644
@@ -20,6 +20,10 @@ isa-$(CONFIG_CPU_SH4AL_DSP)		:= sh4al
 isa-$(CONFIG_CPU_SH5)			:= shmedia
 isa-$(CONFIG_SH_DSP)			:= $(isa-y)-dsp
 
+ifdef CONFIG_CPU_SH3
+isa-y	:= $(isa-y)-up
+endif
+
 cflags-$(CONFIG_CPU_SH2)		:= $(call cc-option,-m2,)
 cflags-$(CONFIG_CPU_SH2A)		+= $(call cc-option,-m2a,) \
 					   $(call cc-option,-m2a-nofpu,)
Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 3 lines · Nobuhiro Iwamatsu

By commit of b2d86a3fd9855380598c0c039e712a20086e119f, compilation of SH3 fails. In current binutils, "pref" opcode is not support SH3. However, it is supported. Please validate this flag till fix binutils.

Sorry, this comment is a mistake.
I wanted to write
In current binutils, "pref" and other opcode are processed to SH3 as not supported.

Best regards,
Nobuhiro

#2 lore raw
In reply to Nobuhiro Iwamatsu
Quoted 9 lines · Nobuhiro Iwamatsu
Quoted 3 lines · Nobuhiro Iwamatsu

By commit of b2d86a3fd9855380598c0c039e712a20086e119f, compilation of SH3 fails. In current binutils, "pref" opcode is not support SH3. However, it is supported. Please validate this flag till fix binutils.

Sorry, this comment is a mistake.
I wanted to write
In current binutils, "pref" and other opcode are processed to SH3 as not supported.

[ random cursing at binutils goes here ]

Yes, you are correct, the -up is necessary. I've re-added it for all non-SHmedia parts.