Skip to contentSkip to conversation

: SGI x86 UV: Fix compile error in uv_hub.h

PATCH In review Mike Travis 2 participants 3 messages Oct 30, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : SGI x86 UV: Fix compile error in uv_hub.h

Subject: SGI x86 UV: Fix compile error in uv_hub.h

Fix compile errors of files that include asm/uv/uv_hub.h but do not include linux/timer.h.

Based on linux-next.

---
 arch/x86/include/asm/uv/uv_hub.h |    1 +
 1 file changed, 1 insertion(+)
arch/x86/include/asm/uv/uv_hub.h +1 -0
@@ -13,6 +13,7 @@
 
 #include <linux/numa.h>
 #include <linux/percpu.h>
+#include <linux/timer.h>
 #include <asm/types.h>
 #include <asm/percpu.h>
 
#1 lore raw
Quoted 11 lines · Mike Travis

Subject: SGI x86 UV: Fix compile error in uv_hub.h

Fix compile errors of files that include asm/uv/uv_hub.h but do not include linux/timer.h.

Based on linux-next.

---
 arch/x86/include/asm/uv/uv_hub.h |    1 +
 1 file changed, 1 insertion(+)

does not affect mainline currently, correct? Nevertheless i queued it up in x86/urgent as it's an obviously correct dependency fix.

Ingo

#2 lore raw
Quoted 14 lines · Ingo Molnar
Quoted 11 lines · Mike Travis

Subject: SGI x86 UV: Fix compile error in uv_hub.h

Fix compile errors of files that include asm/uv/uv_hub.h but do not include linux/timer.h.

Based on linux-next.

---
 arch/x86/include/asm/uv/uv_hub.h |    1 +
 1 file changed, 1 insertion(+)
Quoted 4 lines

does not affect mainline currently, correct? Nevertheless i queued it up in x86/urgent as it's an obviously correct dependency fix.

Ingo

The error popped up on linux-next this morning (in our daily build.)

I'm not sure how it got in there, I think a quilt refresh did it (the original file had the include so it didn't see the difference when writing the patch file.)

Thanks,
Mike