Skip to contentSkip to conversation

xfstests: create tape group

PATCH In review Eric Sandeen 2 participants 4 messages Nov 1, 2008 – Nov 3, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: create tape group

Create a tape group for anything which expects
to dump to tape (I guess this is a superset
of "remote" and a few others).

---

xfstests/group +14 -11
Index: xfs-cmds/xfstests/group
===================================================================
@@ -35,6 +35,9 @@ v2log		[email protected]
 # xfsdump, xfsrestore, xfsinvutil
 dump		[email protected] [email protected]
 
+# xfsdump, xfsrestore to tapes
+tape		[email protected] [email protected]
+
 # xfsdump, xfsrestore to remote tapes
 remote		[email protected] [email protected]
 
@@ -118,10 +121,10 @@ nfs4acl		[email protected] [email protected]
 019 mkfs auto
 020 metadata attr udf auto
 021 db attr auto
-022 dump ioctl auto
-023 dump ioctl auto
-024 dump ioctl auto
-025 dump ioctl auto
+022 dump ioctl tape auto
+023 dump ioctl tape auto
+024 dump ioctl tape auto
+025 dump ioctl tape auto
 026 dump ioctl auto
 027 dump ioctl auto
 028 dump ioctl auto
@@ -131,15 +134,15 @@ nfs4acl		[email protected] [email protected]
 032 mkfs auto
 033 repair auto
 034 other auto
-035 dump ioctl auto
-036 dump ioctl remote auto
-037 dump ioctl remote auto
-038 dump ioctl remote auto
-039 dump ioctl remote auto
+035 dump ioctl tape auto
+036 dump ioctl remote tape auto
+037 dump ioctl remote tape auto
+038 dump ioctl remote tape auto
+039 dump ioctl remote tape auto
 040 other auto
 041 growfs ioctl auto
 042 fsr ioctl auto
-043 dump ioctl auto
+043 dump ioctl tape auto
 044 other auto
 045 other auto
 046 dump ioctl auto
@@ -151,7 +154,7 @@ nfs4acl		[email protected] [email protected]
 052 quota db auto
 053 acl repair auto
 054 quota auto
-055 dump ioctl remote auto
+055 dump ioctl remote tape auto
 056 dump ioctl auto
 057 acl auto
 058 acl auto
#1 lore raw
Quoted 3 lines · Eric Sandeen

Create a tape group for anything which expects
to dump to tape (I guess this is a superset
of "remote" and a few others).

Given that most ppl don't have tape drives, should these be left in the auto group now that they can easily be run by 'check -g tape'? I know I've never had a config to run them the *entire* time I've personally run XFSQA...

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#2 lore raw
Quoted 7 lines · Dave Chinner
Quoted 4 lines · Eric Sandeen

Create a tape group for anything which expects
to dump to tape (I guess this is a superset
of "remote" and a few others).

Quoted 9 lines

Given that most ppl don't have tape drives, should these be left in the auto group now that they can easily be run by 'check -g tape'? I know I've never had a config to run them the *entire* time I've personally run XFSQA...

Cheers,

Dave.

Sounds like a plan. We probably don't even know (?) if they run well enough to be in the auto group? Revised patch below:

-----------------

Create a tape group for anything which expects to dump to tape (I guess this is a superset
of "remote" and a few others). Also, remove this from the auto group; most people won't have tapes and -g tape is easy enough (per dchinner's suggestion).

---

xfstests/group +14 -11
Index: xfs-cmds/xfstests/group
===================================================================
@@ -35,6 +35,9 @@ v2log		[email protected]
 # xfsdump, xfsrestore, xfsinvutil
 dump		[email protected] [email protected]
 
+# xfsdump, xfsrestore to tapes
+tape		[email protected] [email protected]
+
 # xfsdump, xfsrestore to remote tapes
 remote		[email protected] [email protected]
 
@@ -118,10 +121,10 @@ nfs4acl		[email protected] [email protected]
 019 mkfs auto
 020 metadata attr udf auto
 021 db attr auto
-022 dump ioctl auto
-023 dump ioctl auto
-024 dump ioctl auto
-025 dump ioctl auto
+022 dump ioctl tape
+023 dump ioctl tape
+024 dump ioctl tape
+025 dump ioctl tape
 026 dump ioctl auto
 027 dump ioctl auto
 028 dump ioctl auto
@@ -131,15 +134,15 @@ nfs4acl		[email protected] [email protected]
 032 mkfs auto
 033 repair auto
 034 other auto
-035 dump ioctl auto
-036 dump ioctl remote auto
-037 dump ioctl remote auto
-038 dump ioctl remote auto
-039 dump ioctl remote auto
+035 dump ioctl tape auto
+036 dump ioctl remote tape
+037 dump ioctl remote tape
+038 dump ioctl remote tape
+039 dump ioctl remote tape
 040 other auto
 041 growfs ioctl auto
 042 fsr ioctl auto
-043 dump ioctl auto
+043 dump ioctl tape
 044 other auto
 045 other auto
 046 dump ioctl auto
@@ -151,7 +154,7 @@ nfs4acl		[email protected] [email protected]
 052 quota db auto
 053 acl repair auto
 054 quota auto
-055 dump ioctl remote auto
+055 dump ioctl remote tape
 056 dump ioctl auto
 057 acl auto
 058 acl auto
#3 lore raw
Quoted 14 lines · Eric Sandeen
Quoted 12 lines · Dave Chinner
Quoted 4 lines · Eric Sandeen

Create a tape group for anything which expects
to dump to tape (I guess this is a superset
of "remote" and a few others).

Given that most ppl don't have tape drives, should these be left in the auto group now that they can easily be run by 'check -g tape'? I know I've never had a config to run them the *entire* time I've personally run XFSQA...

Quoted 6 lines
Quoted 4 lines

Cheers,

Dave.

Sounds like a plan. We probably don't even know (?) if they run well enough to be in the auto group? Revised patch below:

Looks OK to me.

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]