add include list.h in binfmts.h
PATCH 1/1 add include list.h in binfmts.h
From: Hiroshi Shimamoto <[email protected]>
linux_binfmt uses list_head, so list.h is needed.
Signed-off-by Hiroshi Shimamoto <[email protected]>
--- include/linux/binfmts.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/binfmts.h +1 -0
@@ -1,6 +1,7 @@#ifndef _LINUX_BINFMTS_H#define _LINUX_BINFMTS_H +#include <linux/list.h> #include <linux/capability.h> struct pt_regs ;
Signature · 1 line
1.5.6
Quoted 14 lines · On Wed, 29 Oct 2008 18:03:26 -0700 Hiroshi Shimamoto…
From: Hiroshi Shimamoto <[email protected]>
linux_binfmtuseslist_head, solist.his needed.Signed-off-by Hiroshi Shimamoto <[email protected]>--- include/linux/binfmts.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)include/linux/binfmts.h +0
-0
include/linux/binfmts.h line 7
Quoted 7 lines
include/linux/binfmts.h +1
-0@@ -1,6 +1,7 @@#ifndef _LINUX_BINFMTS_H#define _LINUX_BINFMTS_H +#include <linux/list.h> #include <linux/capability.h> struct pt_regs ;
Did this fix a build error which you were seeing?
Quoted 20 lines · Andrew Morton
Quoted 17 lines · On Wed, 29 Oct 2008 18:03:26 -0700 Hiroshi Shimamoto…
From: Hiroshi Shimamoto <[email protected]>
linux_binfmtuseslist_head, solist.his needed.Signed-off-by Hiroshi Shimamoto <[email protected]>--- include/linux/binfmts.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)include/linux/binfmts.h +0
-0@@ -1,6 +1,7 @@#ifndef _LINUX_BINFMTS_H#define _LINUX_BINFMTS_H
Quoted 6 lines
include/linux/binfmts.h line 7
Quoted 4 lines
include/linux/binfmts.h +1
-0+#include <linux/list.h> #include <linux/capability.h> struct pt_regs ;Did this fix a build error which you were seeing?
I just noticed it modifying arch/x86/kernel/signal_32.c headers. I don't know any case to fail build kernel.
The file signal_32.c includes <linux/list.h> first, and To remove including list.h causes a build error.
thanks,
Hiroshi Shimamoto