Skip to contentSkip to conversation

OMAP3: Update ARM's if then else logic in examples Makefile

U-Boot dirk.behme at googlemail.com 3 participants 4 messages Nov 11, 2008 – Nov 13, 2008

lore
Share & tools
lore
#0 lore raw

Update ARM's if then else logic.

---
 examples/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
examples/Makefile +3 -3
Index: u-boot-arm/examples/Makefile
===================================================================
@@ -30,12 +30,12 @@ LOAD_ADDR = 0x40000
 endif
 
 ifeq ($(ARCH),arm)
-LOAD_ADDR = 0xc100000
 ifeq ($(BOARD),omap2420h4)
 LOAD_ADDR = 0x80300000
-endif
-ifeq ($(CPU),omap3)
+else ifeq ($(CPU),omap3)
 LOAD_ADDR = 0x80300000
+else
+LOAD_ADDR = 0xc100000
 endif
 endif
 
#2 lore raw
In reply to dirk.behme at googlemail.com

Dear dirk.behme at googlemail.com,

Quoted 5 lines · In message <[email protected]> you wrote:

Update ARM's if then else logic.

---
 examples/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Hm... wouldn't it make sense to explicitely state against which repository this patch (and all other of your patches) was (were) made resp. where you want to have it added? For mainline, it just wouldn't work (as you probably know).

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
: 1.  What is the possibility of this being added in the future?
In the near future, the probability is close to zero. In the  distant
future, I'll be dead, and posterity can do whatever they like... :-)
                                                              - lwall
author
#3 lore raw

Dear Wolfgang,

Quoted 6 lines · Wolfgang Denk

Dear dirk.behme at googlemail.com,

Quoted 2 lines · In message <[email protected]> you wrote:

Update ARM's if then else logic.

Quoted 8 lines
Quoted 3 lines

---
examples/Makefile | 6 +++---

1 files changed, 3 insertions(+), 3 deletions(-)

Hm... wouldn't it make sense to explicitely state against which repository this patch (and all other of your patches) was (were) made resp. where you want to have it added?

Hm, I think this info is already there? Have you noticed the "[PATCH-OMAP3] OMAP3" in subject? Having this identifier in subject is the way Jean-Christophe likes to have patches for u-boot-arm/omap3 [1]
[2] marked.

Regarding my pending patches, there is one exception and this is

http://lists.denx.de/pipermail/u-boot/2008-November/043220.html

This is for (u-boot-arm) mainline as expressed by "ARM" in subject. As mentioned in note of this patch, I did it against mainline cause u-boot-arm wasn't in sync with mainline while creating that patch. But as u-boot-arm is in sync with mainline again now, it should apply there, too.

Best regards

Dirk

[1] http://lists.denx.de/pipermail/u-boot/2008-November/042897.html

[2]
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=shortlog;h=refs/heads/omap3