next: 6a13378a5 (Don't allow KWorld radio...) is broken
Hi guys,
The commit below is apparently wrong. Maybe you CCed HID maintainer, however linux-input didn't get the message, or at least I can't find it anywhere.
There is a difference between hid_blacklist and hid_ignore_list. One forbids generic hid driver to bind the device, while the other forces usbhid to release the device and move hands away from it.
You picked up the former, which is wrong. I wonder if you were so lucky that you didn't hit it. Care to send a fixup with proper CCs?
Thanks.
commit 6a13378a56ce06afca9db75f3d4e663fba5f0992
Author: Alexey Klimov <[email protected]> Date: Sun Oct 19 20:10:13 2008 -0300
V4L/DVB (9337a): HID: Don't allow KWorld radio fm700 be handled by usb hid d
rivers
This device is already handled by radio-si470x driver, and we therefore want usbhid to ignore it.
drivers/hid/hid-core.c +0 -0
@@ -1265,6 +1265,7 @@ static const struct hid_device_id hid_blacklist[] = { { HID_USB_DEVICE(USB_VENDOR_ID_EZKEY, USB_DEVICE_ID_BTC_8193) }, { HID_USB_DEVICE(USB_VENDOR_ID_GENERIC_13BA, USB_DEVICE_ID_GENERIC_13BA_
KBD_MOUSE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE)
},
+ { HID_USB_DEVICE(USB_VENDOR_ID_KWORLD, USB_DEVICE_ID_KWORLD_RADIO_FM700)
},
{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_2
) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, USB_DEVICE_ID_LABTEC_WIRELESS_KEY
BOARD) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_MX3000_RECEIVER)
},
Quoted 3 lines · Jiri Slaby
The commit below is apparently wrong. Maybe you CCed HID maintainer, however linux-input didn't get the message, or at least I can't find it anywhere.
Jiri, thanks for noticing.
No, I don't seem to have been CCed on that patch, and it is apparently wrong indeed.
Alexey, did you actually test it?
I'd prefer taking this through my tree, if it doesn't impose any problem on your side. Could you please fix it up and resend?
Thanks,
Signature · 1 line
Jiri Kosina
PATCH 1/2 hid: fix kworld fm700 radio hidquirks
This patch fixes kworld fm700 usb-radio hidqurks that handled by radio-si470x. Removes it from blacklist entry and places it in ignore entry in hid/hid-core.c
---
linux/drivers/hid/hid-core.c +1 -1
@@ -1265,7 +1265,6 @@ { HID_USB_DEVICE(USB_VENDOR_ID_EZKEY, USB_DEVICE_ID_BTC_8193) }, { HID_USB_DEVICE(USB_VENDOR_ID_GENERIC_13BA, USB_DEVICE_ID_GENERIC_13BA_KBD_MOUSE) }, { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE) }, - { HID_USB_DEVICE(USB_VENDOR_ID_KWORLD, USB_DEVICE_ID_KWORLD_RADIO_FM700) }, { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_2) }, { HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_MX3000_RECEIVER) },
@@ -1486,6 +1485,7 @@ { HID_USB_DEVICE(USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_1007) }, { HID_USB_DEVICE(USB_VENDOR_ID_IMATION, USB_DEVICE_ID_DISC_STAKKA) }, { HID_USB_DEVICE(USB_VENDOR_ID_KBGEAR, USB_DEVICE_ID_KBGEAR_JAMSTUDIO) }, + { HID_USB_DEVICE(USB_VENDOR_ID_KWORLD, USB_DEVICE_ID_KWORLD_RADIO_FM700) }, { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_GPEN_560) }, { HID_USB_DEVICE(USB_VENDOR_ID_LD, USB_DEVICE_ID_LD_CASSY) }, { HID_USB_DEVICE(USB_VENDOR_ID_LD, USB_DEVICE_ID_LD_POCKETCASSY) },
Signature · 1 line
Best regards, Klimov Alexey
PATCH 2/2 hid: fix radio-mr800 hidquirks
In reply to Jiri KosinaThis patch fixes radio-mr800 hidqurks. Removes it from blacklist entry and places it in ignore entry in hid/hid-core.c
---
linux/drivers/hid/hid-core.c +1 -1
@@ -1252,7 +1252,6 @@ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_JIS) }, { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY) }, { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY) }, - { HID_USB_DEVICE(USB_VENDOR_ID_AVERMEDIA, USB_DEVICE_ID_AVER_FM_MR800) }, { HID_USB_DEVICE(USB_VENDOR_ID_BELKIN, USB_DEVICE_ID_FLIP_KVM) }, { HID_USB_DEVICE(USB_VENDOR_ID_BRIGHT, USB_DEVICE_ID_BRIGHT_ABNT2) }, { HID_USB_DEVICE(USB_VENDOR_ID_CHERRY, USB_DEVICE_ID_CHERRY_CYMOTION) },
@@ -1408,6 +1407,7 @@ { HID_USB_DEVICE(USB_VENDOR_ID_ALCOR, USB_DEVICE_ID_ALCOR_USBRS232) }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUS, USB_DEVICE_ID_ASUS_LCM)}, { HID_USB_DEVICE(USB_VENDOR_ID_ASUS, USB_DEVICE_ID_ASUS_LCM2)}, + { HID_USB_DEVICE(USB_VENDOR_ID_AVERMEDIA, USB_DEVICE_ID_AVER_FM_MR800) }, { HID_USB_DEVICE(USB_VENDOR_ID_BERKSHIRE, USB_DEVICE_ID_BERKSHIRE_PCWD) }, { HID_USB_DEVICE(USB_VENDOR_ID_CIDC, 0x0103) }, { HID_USB_DEVICE(USB_VENDOR_ID_CYGNAL, USB_DEVICE_ID_CYGNAL_RADIO_SI470X) },
Quoted 1 line
Signature · 1 line
Best regards, Klimov Alexey
Quoted 2 lines · On Thu, 13 Nov 2008 01:33:17 +0100 (CET) Jiri Kosina <[email protected]> wrote:
I'd prefer taking this through my tree, if it doesn't impose any problem on your side.
That's fine for me.
Cheers,
Mauro
Quoted 3 lines · Jiri Slaby
There is a difference between
hid_blacklistandhid_ignore_list. One forbids generic hid driver to bind the device, while the other forces usbhid to release the device and move hands away from it.
I figured that out and remembered that this thing needed to be fixed and then got side-tracked by other things. Sorry.
Quoted 3 lines · Jiri Kosina
Alexey, did you actually test it?
I'd prefer taking this through my tree, if it doesn't impose any problem on your side. Could you please fix it up and resend?
It good thing to do. May i make patch against current kernel tree (rc4-git3) ? I also going to make patch for radio-mr800 that has wrong hidquirks too. I can send now, because this two patches ready.
Signature · 1 line
Best regards, Klimov Alexey
Quoted 6 lines · Alexey Klimov
Quoted 3 lines
Alexey, did you actually test it?
I'd prefer taking this through my tree, if it doesn't impose any problem on your side. Could you please fix it up and resend?It good thing to do. May i make patch against current kernel tree (rc4-git3) ? I also going to make patch for radio-mr800 that has wrong hidquirks too. I can send now, because this two patches ready.
Thanks, I have applied both patches to my tree (but please remember to always send kernel patches so that they apply using "patch -p1", I had to fix this by hand).
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs