mpc83xx: New board support SIMPC8313
PATCH 1/1 mpc83xx: New board support SIMPC8313
Quoted 6 lines
Quoted 2 lines
+ *((u32 *)(CFG_IMMR + addr)) = data;
use the
out_be32i/o memory accessor and friends please (here and elsewhere in the patch).
I am trying to resolve this last issue with your review and replacing all of the i/o memory accesses with in/out_be* has caused my code to inflate by about 200 bytes, and now I'm over the 4K limit by about 160 bytes for the 8313 bootstrap. Without trying to squeeze my code is there anything that could be done to shrink my code?
Ron
PATCH 1/1 mpc83xx: New board support SIMPC8313
Quoted 11 lines · Ron Madrid
Quoted 4 lines
Quoted 1 line
+ *((u32 *)(CFG_IMMR + addr)) = data;
use the
out_be32i/o memory accessor and friends please (here and elsewhere in the patch).I am trying to resolve this last issue with your review and replacing all of the i/o memory accesses with in/out_be* has caused my code to inflate by about 200 bytes, and now I'm over the 4K limit by about 160 bytes for the 8313 bootstrap. Without trying to squeeze my code is there anything that could be done to shrink my code?
Use raw accessors and make sure that explicit barriers are used where needed.
-Scott