Skip to contentSkip to conversation

usb: m66592 and r8a66597 resource changes

PATCH In review Magnus Damm 2 participants 2 messages Nov 13, 2008 – Nov 14, 2008

Subsystems (2)
USB SuperH
lore
Share & tools
lore

Magnus Damm

author
#0 lore raw

PATCH 1/1 usb: m66592 and r8a66597 resource changes

From: Magnus Damm <[email protected]>

Use the more common platform_get_resource() together with index instead of depending on the resource name and platform_get_resource_by_name(). Replace the resource_len() implementation with resource_size().

Signed-off-by Magnus Damm <[email protected]>

---

 drivers/usb/gadget/m66592-udc.c |    9 +++------
 drivers/usb/host/r8a66597-hcd.c |    8 +++-----
 2 files changed, 6 insertions(+), 11 deletions(-)
drivers/usb/gadget/m66592-udc.c +3 -6
@@ -1548,8 +1548,6 @@ static void nop_completion(struct usb_ep
 {
 }
 
-#define resource_len(r) (((r)->end - (r)->start) + 1)
-
 static int __init m66592_probe(struct platform_device *pdev)
 {
 	struct resource *res;

@@ -1559,11 +1557,10 @@ static int __init m66592_probe(struct pl
 	int ret = 0;
 	int i;
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-			(char *)udc_name);
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res) {
 		ret = -ENODEV;
-		pr_err("platform_get_resource_byname error.\n");
+		pr_err("platform_get_resource error.\n");
 		goto clean_up;
 	}
 

@@ -1574,7 +1571,7 @@ static int __init m66592_probe(struct pl
 		goto clean_up;
 	}
 
-	reg = ioremap(res->start, resource_len(res));
+	reg = ioremap(res->start, resource_size(res));
 	if (reg = NULL) {
 		ret = -ENOMEM;
 		pr_err("ioremap error.\n");
drivers/usb/host/r8a66597-hcd.c +3 -5
@@ -2264,7 +2264,6 @@ static int __init_or_module r8a66597_rem
 	return 0;
 }
 
-#define resource_len(r) (((r)->end - (r)->start) + 1)
 static int __init r8a66597_probe(struct platform_device *pdev)
 {
 	struct resource *res = NULL, *ires;

@@ -2282,11 +2281,10 @@ static int __init r8a66597_probe(struct 
 		goto clean_up;
 	}
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-					   (char *)hcd_name);
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res) {
 		ret = -ENODEV;
-		dev_err(&pdev->dev, "platform_get_resource_byname error.\n");
+		dev_err(&pdev->dev, "platform_get_resource error.\n");
 		goto clean_up;
 	}
 

@@ -2301,7 +2299,7 @@ static int __init r8a66597_probe(struct 
 	irq = ires->start;
 	irq_trigger = ires->flags & IRQF_TRIGGER_MASK;
 
-	reg = ioremap(res->start, resource_len(res));
+	reg = ioremap(res->start, resource_size(res));
 	if (reg = NULL) {
 		ret = -ENOMEM;
 		dev_err(&pdev->dev, "ioremap error.\n");
#1 lore raw

Hi Magnus-san,

Quoted 7 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Use the more common platform_get_resource() together with index instead of depending on the resource name and platform_get_resource_by_name(). Replace the resource_len() implementation with resource_size().

Signed-off-by Magnus Damm <[email protected]>

Thank you for your patch.
I tested this patch and confirmed it is working.

Thanks,
Yoshihiro Shimoda