Skip to contentSkip to conversation

drivers/ata/pata_radisys.c: cleanup kernel-doc

PATCH In review Qinghuang Feng 4 participants 4 messages Nov 16, 2008 – Nov 25, 2008 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/7 drivers/ata/pata_radisys.c: cleanup kernel-doc

No argument named @isich in radisys_set_dmamode,
remove it.

---

drivers/ata/pata_radisys.c +0 -1
index 0b0aa45..695d44a 100644
@@ -81,7 +81,6 @@ static void radisys_set_piomode (struct ata_port *ap, struct ata_device *adev)
  *	radisys_set_dmamode - Initialize host controller PATA DMA timings
  *	@ap: Port whose timings we are configuring
  *	@adev: Device to program
- *	@isich: True if the device is an ICH and has IOCFG registers
  *
  *	Set MWDMA mode for device, in host controller PCI config space.
  *
#2 lore raw
In reply to Qinghuang Feng
Quoted 10 lines · Qinghuang Feng

No argument named @isich in radisys_set_dmamode,
remove it.

---

drivers/ata/pata_radisys.c +0 -0
index 0b0aa45..695d44a 100644

drivers/ata/pata_radisys.c static void radisys_set_piomode (struct ata_port *ap, struct ata_device *adev) · line 86

Quoted 7 lines
drivers/ata/pata_radisys.c +0 -1
@@ -81,7 +81,6 @@ static void radisys_set_piomode (struct ata_port *ap, struct ata_device *adev)
  *	radisys_set_dmamode - Initialize host controller PATA DMA timings
  *	@ap: Port whose timings we are configuring
  *	@adev: Device to program
- *	@isich: True if the device is an ICH and has IOCFG registers
  *
  *	Set MWDMA mode for device, in host controller PCI config space.
  *

applied 1-7 to #upstream, after combining into a single patch. I felt a single changeset was more appropriate.

#3 lore raw
Quoted 3 lines

applied 1-7 to #upstream, after combining into a single patch. I felt a single changeset was more appropriate.

Hello sir,

That's good, but.
Andrew Morton have got these patches few days ago, and he forgot to Cc to you. These patches are in mm-trees now. I don't know if it will lead to some problem, so send this mail to you.