Skip to contentSkip to conversation

sh: Update sh timer function

PATCH New Nobuhiro Iwamatsu 3 participants 4 messages Nov 17, 2008 – Dec 9, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sh: Update sh timer function

Change to write/readX fcuntion and fix timer bug.

---
 cpu/sh3/Makefile |    2 +-
 cpu/sh3/time.c   |  103 ------------------------------------------------------
 cpu/sh4/time.c   |   76 ++++++++++++++++++++++++++-------------
 3 files changed, 52 insertions(+), 129 deletions(-)
 delete mode 100644 cpu/sh3/time.c
cpu/sh3/Makefile +1 -1
index 587413d..e3e5777 100644
@@ -32,7 +32,7 @@ include $(TOPDIR)/config.mk
 LIB	= $(obj)lib$(CPU).a
 
 SOBJS	= start.o
-COBJS	= cpu.o interrupts.o watchdog.o time.o cache.o
+COBJS	= cpu.o interrupts.o watchdog.o cache.o ../sh4/time.o
 
 SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))
cpu/sh3/time.c deleted +0 -103

103 lines not on this page · raw message

cpu/sh4/time.c +51 -25

125 lines not on this page · raw message

Signature · 1 line
1.5.6.5
#1 lore raw

PATCH 1/1 sh: Update sh timer function

Quoted 15 lines · Nobuhiro Iwamatsu

Change to write/readX fcuntion and fix timer bug.

---
 cpu/sh3/Makefile |    2 +-
 cpu/sh3/time.c   |  103 ------------------------------------------------------
 cpu/sh4/time.c   |   76 ++++++++++++++++++++++++++-------------
 3 files changed, 52 insertions(+), 129 deletions(-)
 delete mode 100644 cpu/sh3/time.c
cpu/sh3/Makefile +0 -0
index 587413d..e3e5777 100644

cpu/sh3/Makefile include $(TOPDIR)/config.mk · line 35

Quoted 5 lines
cpu/sh3/Makefile +1 -1
@@ -32,7 +32,7 @@ include $(TOPDIR)/config.mk
 LIB	= $(obj)lib$(CPU).a
 
 SOBJS	= start.o
-COBJS	= cpu.o interrupts.o watchdog.o time.o cache.o
+COBJS	= cpu.o interrupts.o watchdog.o cache.o ../sh4/time.o

I'm not a fan of this

Maybe you could change the current storrage as this

cpu/sh
|- cpu/sh/time.c
here the common sh code
cpu/sh/sh4/
sh4 specific
cpu/sh/sh3/
sh3 specific

Best Regards,
J.

#2 lore raw

PATCH 1/1 sh: Update sh timer function

Hi,

Quoted 25 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 15 lines · Nobuhiro Iwamatsu

Change to write/readX fcuntion and fix timer bug.

---
 cpu/sh3/Makefile |    2 +-
 cpu/sh3/time.c   |  103 ------------------------------------------------------
 cpu/sh4/time.c   |   76 ++++++++++++++++++++++++++-------------
 3 files changed, 52 insertions(+), 129 deletions(-)
 delete mode 100644 cpu/sh3/time.c
cpu/sh3/Makefile +0 -0
index 587413d..e3e5777 100644

cpu/sh3/Makefile include $(TOPDIR)/config.mk · line 35

Quoted 5 lines
cpu/sh3/Makefile +1 -1
@@ -32,7 +32,7 @@ include $(TOPDIR)/config.mk
 LIB	= $(obj)lib$(CPU).a
 
 SOBJS	= start.o
-COBJS	= cpu.o interrupts.o watchdog.o time.o cache.o
+COBJS	= cpu.o interrupts.o watchdog.o cache.o ../sh4/time.o

I'm not a fan of this

Maybe you could change the current storrage as this

Quoted 7 lines

cpu/sh
|- cpu/sh/time.c
here the common sh code
cpu/sh/sh4/
sh4 specific
cpu/sh/sh3/
sh3 specific

OK, you are right.

I think about directory constitution.
Thank you for commnet.

Best regards,
Nobuhiro

#3 lore raw

PATCH 1/1 sh: Update sh timer function

In reply to Nobuhiro Iwamatsu

Dear Nobuhiro Iwamatsu,

Quoted 3 lines · In message <[email protected]> you wrote:

Change to write/readX fcuntion and fix timer bug.

It seems there are some SH related patches in your queue which did not make it into mainline yet? Doi you intend to send a pull request any time soon?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"No matter where you go, there you are..."          - Buckaroo Banzai