Skip to contentSkip to conversation

net: af_packet should update its inuse counter

PATCH Applied Eric Dumazet 2 participants 2 messages Nov 17, 2008 – Nov 19, 2008

Subsystems (3)
Networking Network drivers Packet sockets
lore
Share & tools
lore

Eric Dumazet

author
#0 lore raw

PATCH 1/1 net: af_packet should update its inuse counter

This patch is a preparation to namespace conversion of /proc/net/protocols

In order to have relevant information for PACKET protocols, we should use sock_prot_inuse_add() to update a (percpu and pernamespace) counter of inuse sockets.

Signed-off-by Eric Dumazet <[email protected]>

---

net/packet/af_packet.c +2 -0
index c718e7e..b4870a3 100644
@@ -910,6 +910,7 @@ static int packet_release(struct socket *sock)
 	skb_queue_purge(&sk->sk_receive_queue);
 	sk_refcnt_debug_release(sk);
 
+	sock_prot_inuse_add(net, sk->sk_prot, -1);
 	sock_put(sk);
 	return 0;
 }

@@ -1085,6 +1086,7 @@ static int packet_create(struct net *net, struct socket *sock, int protocol)
 	write_lock_bh(&net->packet.sklist_lock);
 	sk_add_node(sk, &net->packet.sklist);
 	write_unlock_bh(&net->packet.sklist_lock);
+	sock_prot_inuse_add(net, &packet_proto, 1);
 	return(0);
 out:
 	return err;
maintainer Applied
#1 lore raw

From: Eric Dumazet <[email protected]>
Date: Mon, 17 Nov 2008 11:49:03 +0100

Quoted 7 lines

This patch is a preparation to namespace conversion of /proc/net/protocols

In order to have relevant information for PACKET protocols, we should use sock_prot_inuse_add() to update a (percpu and pernamespace) counter of inuse sockets.

Signed-off-by Eric Dumazet <[email protected]>

Applied to net-next-2.6, thanks.