DisplayState interface change
PATCH 1/1 DisplayState interface change
Hi all,
this is an update of the "DisplayState interface change" patch. The main change is introducing a DisplaySurface struct and a PixelFormat struct following Anthony's suggestion, they are both inspired by SDL.
I must say that now everything looks much better, Anthony was definitely right about the fact that we make too many assumptions based only on depth. Introducing these two structures allowed me also to simplify vnc.c, as you can see in the second patch.
I tested this series with i386 emulation, cirrus vga, vmware vga, curses and both sdl and vnc (even at the same time ;).
I realize that the first patch is very big, but it is a small as possible while still being able to compile.
I suggest you to read it on a per file basis, paying attention to the changes to console.c, console.h, vga.c, vl.c, vnc.c and sdl.c; the rest are just substitutions.
Cheers,
Stefano
Hi Stefano,
Quoted 10 lines · Stefano Stabellini
Hi all,
this is an update of the "DisplayState interface change" patch. The main change is introducing a DisplaySurface struct and a PixelFormat struct following Anthony's suggestion, they are both inspired by SDL.I must say that now everything looks much better, Anthony was definitely right about the fact that we make too many assumptions based only on depth. Introducing these two structures allowed me also to simplify
vnc.c, as you can see in the second patch.
Quoted 9 lines
I tested this series with i386 emulation, cirrus vga, vmware vga, curses and both sdl and vnc (even at the same time ;).
I realize that the first patch is very big, but it is a small as possible while still being able to compile.
I suggest you to read it on a per file basis, paying attention to the changes toconsole.c,console.h,vga.c,vl.c,vnc.candsdl.c; the rest are just substitutions.
I really like this new API. I took a high level look at the code and I think there are only some minor things to be cleaned up but I'd rather you split up the first patch like I mentioned before pointing those things out.
One thing that I think would be helpful is to add a concise document describing how to use this new API. We can even introduce a docs directory for this sort of thing (think Documentation/ in Linux).
Regards,
Anthony Liguori
Quoted 7 lines
Cheers,
Stefano
Quoted 5 lines · Anthony Liguori
I really like this new API. I took a high level look at the code and I think there are only some minor things to be cleaned up but I'd rather you split up the first patch like I mentioned before pointing those things out.
That's good to hear.
I'll add some accessors to try to simplify the patch, like you said.
Hello every Qemu-developers.
Excuse me for I am here. I am not a developer. I wanted to write a question on the Qemu forum but it is impossible to registrate. I get the message that the confirmation cod is wrong and I am sure that I fill in exactly the right letters and numbers. I tried and tried again, a hundred times. So I shall vanish from this group as soon as I get an answer* or* I get help to registrate. Please...
My question is: I cannot maximize the Qemu. I have not the Maximize button and when I click in the Window menu in left corner, the "Maximize" not highlighted.
I have operating system Linux Ubuntu 10.8 and I look at Windows XP on Qemu. Greetings
Ivan
2008/11/21 Stefano Stabellini <[email protected]>
Quoted 14 lines
Quoted 5 lines · Anthony Liguori
I really like this new API. I took a high level look at the code and I think there are only some minor things to be cleaned up but I'd rather you split up the first patch like I mentioned before pointing those things out.
That's good to hear.
I'll add some accessors to try to simplify the patch, like you said.
Quoted 5 lines · Ivan Bogardi
Hello every Qemu-developers.
Excuse me for I am here. I am not a developer. I wanted to write a question on the Qemu forum but it is impossible to registrate. I get the message that the confirmation cod is wrong and I am sure that I fill in exactly the right letters and numbers. I tried and tried again, a
Quoted 8 lines
hundred times. So I shall vanish from this group as soon as I get an answer/ or/ I get help to registrate. Please...
My question is: I cannot maximize the Qemu. I have not the Maximize button and when I click in the Window menu in left corner, the "Maximize" not highlighted.
I have operating system Linux Ubuntu 10.8 and I look at Windows XP on Qemu. Greetings
Ivan
Maximize is not implemented (yet).
I see.
Is there anybody can help me to registrate on Qemu forum? It is something
wrong with he confirmation code.
2008/11/21 Stefano Stabellini <[email protected]>
Quoted 21 lines
Quoted 11 lines · Ivan Bogardi
Hello every Qemu-developers.
Excuse me for I am here. I am not a developer. I wanted to write a question on the Qemu forum but it is impossible to registrate. I get the message that the confirmation cod is wrong and I am sure that I fill in exactly the right letters and numbers. I tried and tried again, a hundred times. So I shall vanish from this group as soon as I get an answer/ or/ I get help to registrate. Please...
My question is: I cannot maximize the Qemu. I have not the Maximize button and when I click in the Window menu in left corner, the "Maximize" not highlighted.
I have operating system Linux Ubuntu 10.8 and I look at Windows XP onQemu.
Quoted 2 lines
Greetings
IvanMaximize is not implemented (yet).