Skip to contentSkip to conversation

fix CGROUP VS RCU

PATCH In review Lai Jiangshan 4 participants 7 messages Nov 21, 2008 3 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix CGROUP VS RCU

current some cgroup struct are protected by RCU.

struct protected by RCU:
struct css_set, struct cgroup_subsys_state, struct cgroup

pointer protected by RCU:
struct task_struct.cgroups, struct css_set.subsys[*], struct cgroup_subsys_state.cgroup
the last two pointers are readonly pointer!

these patches are fix these structs, and pointers. And a faker:
struct cgroup_subsys.root

Not cleanup all yet.

Thanx, Lai

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 11 lines · On Fri, 21 Nov 2008 16:49:13 +0800 Lai Jiangshan…

current some cgroup struct are protected by RCU.

struct protected by RCU:
struct css_set, struct cgroup_subsys_state, struct cgroup

pointer protected by RCU:
struct task_struct.cgroups, struct css_set.subsys[*], struct cgroup_subsys_state.cgroup
the last two pointers are readonly pointer!

Quoted 5 lines

these patches are fix these structs, and pointers. And a faker:
struct cgroup_subsys.root

Not cleanup all yet.

These patches aren't sequence numbered. In what order should they be applied?

#3 lore raw
In reply to Lai Jiangshan
Quoted 11 lines · On Fri, 21 Nov 2008 16:49:13 +0800 Lai Jiangshan <[email protected]> wrote:

current some cgroup struct are protected by RCU.

struct protected by RCU:
struct css_set, struct cgroup_subsys_state, struct cgroup

pointer protected by RCU:
struct task_struct.cgroups, struct css_set.subsys[*], struct cgroup_subsys_state.cgroup
the last two pointers are readonly pointer!

Quoted 5 lines

these patches are fix these structs, and pointers. And a faker:
struct cgroup_subsys.root

Not cleanup all yet.

These patches aren't sequence numbered. In what order should they be applied?

A message that is not in the archive (sent off-list or not yet received): 20081121010637.0f71ffff.akpm-de/[email protected]

#5 lore raw
Quoted 12 lines · Andrew Morton
Quoted 10 lines · On Fri, 21 Nov 2008 16:49:13 +0800 Lai Jiangshan…

current some cgroup struct are protected by RCU.

struct protected by RCU:
struct css_set, struct cgroup_subsys_state, struct cgroup

pointer protected by RCU:
struct task_struct.cgroups, struct css_set.subsys[*], struct cgroup_subsys_state.cgroup
the last two pointers are readonly pointer!

Quoted 12 lines
Quoted 5 lines

these patches are fix these structs, and pointers. And a faker:
struct cgroup_subsys.root

Not cleanup all yet.

These patches aren't sequence numbered. In what order should they be applied?

No order number, they are dependent(except 2 patches which have order number).

Lai.

#6 lore raw
In reply to Andrew Morton
Quoted 12 lines · Andrew Morton
Quoted 10 lines · On Fri, 21 Nov 2008 16:49:13 +0800 Lai Jiangshan <[email protected]> wrote:

current some cgroup struct are protected by RCU.

struct protected by RCU:
struct css_set, struct cgroup_subsys_state, struct cgroup

pointer protected by RCU:
struct task_struct.cgroups, struct css_set.subsys[*], struct cgroup_subsys_state.cgroup
the last two pointers are readonly pointer!

Quoted 12 lines
Quoted 5 lines

these patches are fix these structs, and pointers. And a faker:
struct cgroup_subsys.root

Not cleanup all yet.

These patches aren't sequence numbered. In what order should they be applied?

No order number, they are dependent(except 2 patches which have order number).

Lai.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw
Quoted 18 lines · Lai Jiangshan
Quoted 17 lines · Andrew Morton
Quoted 15 lines · On Fri, 21 Nov 2008 16:49:13 +0800 Lai Jiangshan…

current some cgroup struct are protected by RCU.

struct protected by RCU:
struct css_set, struct cgroup_subsys_state, struct cgroup

pointer protected by RCU:
struct task_struct.cgroups, struct css_set.subsys[*], struct cgroup_subsys_state.cgroup
the last two pointers are readonly pointer!

these patches are fix these structs, and pointers. And a faker:
struct cgroup_subsys.root

Not cleanup all yet.

Quoted 8 lines
Quoted 6 lines

These patches aren't sequence numbered. In what order should they be applied?

No order number, they are dependent(except 2 patches which have order number).

                            dependent --> independent
Quoted 4 lines

Lai.

#9 lore raw
In reply to Lai Jiangshan
Quoted 18 lines · Lai Jiangshan
Quoted 17 lines · Andrew Morton
Quoted 15 lines · On Fri, 21 Nov 2008 16:49:13 +0800 Lai Jiangshan <[email protected]> wrote:

current some cgroup struct are protected by RCU.

struct protected by RCU:
struct css_set, struct cgroup_subsys_state, struct cgroup

pointer protected by RCU:
struct task_struct.cgroups, struct css_set.subsys[*], struct cgroup_subsys_state.cgroup
the last two pointers are readonly pointer!

these patches are fix these structs, and pointers. And a faker:
struct cgroup_subsys.root

Not cleanup all yet.

Quoted 8 lines
Quoted 6 lines

These patches aren't sequence numbered. In what order should they be applied?

No order number, they are dependent(except 2 patches which have order number).

                            dependent --> independent
Quoted 4 lines

Lai.