Skip to contentSkip to conversation

power: reset: linkstation-poweroff: add LS220D/E

PATCH In review Daniel González Cabanelas 2 participants 6 messages Feb 12, 2023 – Feb 28, 2023 System reset/shutdown drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power: reset: linkstation-poweroff: add LS220D/E

Add 2 new devices to the compatible list:
- Buffalo Linkstation LS220D
- Buffalo Linkstation LS220DE

---
 drivers/power/reset/linkstation-poweroff.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/power/reset/linkstation-poweroff.c +6 -0
index 02f5fdb8f..cfee2efd9 100644
@@ -142,6 +142,12 @@ static void linkstation_poweroff(void)
 }
 
 static const struct of_device_id ls_poweroff_of_match[] = {
+	{ .compatible = "buffalo,ls220d",
+	  .data = &linkstation_power_off_cfg,
+	},
+	{ .compatible = "buffalo,ls220de",
+	  .data = &linkstation_power_off_cfg,
+	},
 	{ .compatible = "buffalo,ls421d",
 	  .data = &linkstation_power_off_cfg,
 	},
Signature · 1 line
2.39.1
#1 lore raw

Hi,

Quoted 16 lines · Daniel González Cabanelas

Add 2 new devices to the compatible list:
- Buffalo Linkstation LS220D
- Buffalo Linkstation LS220DE

---
 drivers/power/reset/linkstation-poweroff.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/power/reset/linkstation-poweroff.c +0 -0
index 02f5fdb8f..cfee2efd9 100644
@@ -142,6 +142,12 @@ static void linkstation_poweroff(void)
 }
 

drivers/power/reset/linkstation-poweroff.c static void linkstation_poweroff(void) · line 153

Quoted 10 lines
drivers/power/reset/linkstation-poweroff.c +6 -0
 static const struct of_device_id ls_poweroff_of_match[] = {
+	{ .compatible = "buffalo,ls220d",
+	  .data = &linkstation_power_off_cfg,
+	},
+	{ .compatible = "buffalo,ls220de",
+	  .data = &linkstation_power_off_cfg,
+	},
 	{ .compatible = "buffalo,ls421d",
 	  .data = &linkstation_power_off_cfg,
 	},

Where is the patch adding these compatibles to the DT binding documentation?

-- Sebastian

#2 lore raw

Hi

Quoted 20 lines · Sebastian Reichel

Hi,

Quoted 16 lines · Daniel González Cabanelas

Add 2 new devices to the compatible list:
- Buffalo Linkstation LS220D
- Buffalo Linkstation LS220DE

---
 drivers/power/reset/linkstation-poweroff.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/power/reset/linkstation-poweroff.c +0 -0
index 02f5fdb8f..cfee2efd9 100644
@@ -142,6 +142,12 @@ static void linkstation_poweroff(void)
 }
 
Quoted 13 lines

drivers/power/reset/linkstation-poweroff.c static void linkstation_poweroff(void) · line 153

Quoted 10 lines
drivers/power/reset/linkstation-poweroff.c +6 -0
 static const struct of_device_id ls_poweroff_of_match[] = {
+     { .compatible = "buffalo,ls220d",
+       .data = &linkstation_power_off_cfg,
+     },
+     { .compatible = "buffalo,ls220de",
+       .data = &linkstation_power_off_cfg,
+     },
      { .compatible = "buffalo,ls421d",
        .data = &linkstation_power_off_cfg,
      },

Where is the patch adding these compatibles to the DT binding documentation?

There is no DT binding at all. So no documentation.

BTW I'm thinking to rework the driver again for adding DT bindings and therefore rid of the dependeny of adding new devices to the driver, every time a new compatible device appears. My first versions of this driver had DT-bindings but the DT documentation maintainer rejected them. He said there was no need to add any DT binding. So we ended with this no sense. Let's see if the next time we have a bit more luck.

Regards

Quoted 2 lines

-- Sebastian

#3 lore raw

[+cc DT binding people]

Hi,

Quoted 11 lines · Daniel González Cabanelas
Quoted 11 lines
Quoted 10 lines

static const struct of_device_id ls_poweroff_of_match[] = {

drivers/power/reset/linkstation-poweroff.c +6 -0
+     { .compatible = "buffalo,ls220d",
+       .data = &linkstation_power_off_cfg,
+     },
+     { .compatible = "buffalo,ls220de",
+       .data = &linkstation_power_off_cfg,
+     },
      { .compatible = "buffalo,ls421d",
        .data = &linkstation_power_off_cfg,
      },
Quoted 4 lines
Quoted 2 lines

Where is the patch adding these compatibles to the DT binding documentation?

There is no DT binding at all. So no documentation.

You are referencing a compatible, so there is supposed to be a DT binding for it. Note, that you also need DT bindings for board level compatible values. See for example:

Documentation/devicetree/bindings/arm/rockchip.yaml Documentation/devicetree/bindings/arm/fsl.yaml

-- Sebastian

#4 lore raw

Hi Sebastian,

Quoted 20 lines · Sebastian Reichel

[+cc DT binding people]

Hi,

Quoted 14 lines · Daniel González Cabanelas
Quoted 13 lines

drivers/power/reset/linkstation-poweroff.c static void linkstation_poweroff(void) · line 153

Quoted 10 lines

static const struct of_device_id ls_poweroff_of_match[] = {

drivers/power/reset/linkstation-poweroff.c +6 -0
+     { .compatible = "buffalo,ls220d",
+       .data = &linkstation_power_off_cfg,
+     },
+     { .compatible = "buffalo,ls220de",
+       .data = &linkstation_power_off_cfg,
+     },
      { .compatible = "buffalo,ls421d",
        .data = &linkstation_power_off_cfg,
      },

Where is the patch adding these compatibles to the DT binding documentation?

Quoted 8 lines
Quoted 1 line

There is no DT binding at all. So no documentation.

You are referencing a compatible, so there is supposed to be a DT binding for it. Note, that you also need DT bindings for board level compatible values. See for example:

Documentation/devicetree/bindings/arm/rockchip.yaml Documentation/devicetree/bindings/arm/fsl.yaml

Since the driver uses the root compatible string, I don't see any binding to document at least for the driver itself. Nor I don't see where a reference for this driver should be put if I documented the board compatible strings.

Quoted 2 lines

-- Sebastian

#5 lore raw

Hi,

Quoted 27 lines · Daniel González Cabanelas
Quoted 25 lines · Sebastian Reichel

[+cc DT binding people]

Hi,

Quoted 11 lines · Daniel González Cabanelas
Quoted 11 lines
Quoted 10 lines

static const struct of_device_id ls_poweroff_of_match[] = {

drivers/power/reset/linkstation-poweroff.c +6 -0
+     { .compatible = "buffalo,ls220d",
+       .data = &linkstation_power_off_cfg,
+     },
+     { .compatible = "buffalo,ls220de",
+       .data = &linkstation_power_off_cfg,
+     },
      { .compatible = "buffalo,ls421d",
        .data = &linkstation_power_off_cfg,
      },
Quoted 4 lines
Quoted 2 lines

Where is the patch adding these compatibles to the DT binding documentation?

There is no DT binding at all. So no documentation.

You are referencing a compatible, so there is supposed to be a DT binding for it. Note, that you also need DT bindings for board level compatible values. See for example:

Quoted 7 lines
Quoted 2 lines

Documentation/devicetree/bindings/arm/rockchip.yaml Documentation/devicetree/bindings/arm/fsl.yaml

Since the driver uses the root compatible string, I don't see any binding to document at least for the driver itself. Nor I don't see where a reference for this driver should be put if I documented the board compatible strings.

You should document the board compatible string for the board (ignoring this driver). Actually that should have happened before the board DT has been merged in the first place. Note, that the examples I provided above are for boards.

Since you are only referencing the root compatible string, we are good to go afterwards from DT perspective.

-- Sebastian