Skip to contentSkip to conversation

netdevice hdlc: Convert directly reference of netdev->priv

PATCH Applied Wang Chen 3 participants 5 messages Nov 21, 2008 – Nov 22, 2008

Subsystems (3)
Networking Network drivers Generic hdlc (wan) drivers
lore
Share & tools
lore

Wang Chen

author
#0 lore raw

PATCH 1/1 netdevice hdlc: Convert directly reference of netdev->priv

Krzysztof said that he will take this one, but not. I sent this to Dave again. :)

For killing directly reference of netdev->priv, use netdev->ml_priv to replace it. Because the private pvc data comes from add_pvc() and can't be allocated in alloc_netdev().

Signed-off-by Wang Chen <[email protected]>
Acked-by Krzysztof Halasa <[email protected]>
---
 drivers/net/wan/hdlc_fr.c |   10 +++++-----
 include/linux/hdlc.h      |    2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/net/wan/hdlc_fr.c +5 -5
index d3d5055..f1ddd7c 100644
@@ -342,7 +342,7 @@ static int fr_hard_header(struct sk_buff **skb_p, u16 dlci)
 
 static int pvc_open(struct net_device *dev)
 {
-	pvc_device *pvc = dev->priv;
+	pvc_device *pvc = dev->ml_priv;
 
 	if ((pvc->frad->flags & IFF_UP) == 0)
 		return -EIO;  /* Frad must be UP in order to activate PVC */

@@ -362,7 +362,7 @@ static int pvc_open(struct net_device *dev)
 
 static int pvc_close(struct net_device *dev)
 {
-	pvc_device *pvc = dev->priv;
+	pvc_device *pvc = dev->ml_priv;
 
 	if (--pvc->open_count == 0) {
 		hdlc_device *hdlc = dev_to_hdlc(pvc->frad);

@@ -381,7 +381,7 @@ static int pvc_close(struct net_device *dev)
 
 static int pvc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 {
-	pvc_device *pvc = dev->priv;
+	pvc_device *pvc = dev->ml_priv;
 	fr_proto_pvc_info info;
 
 	if (ifr->ifr_settings.type == IF_GET_PROTO) {

@@ -409,7 +409,7 @@ static int pvc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 
 static int pvc_xmit(struct sk_buff *skb, struct net_device *dev)
 {
-	pvc_device *pvc = dev->priv;
+	pvc_device *pvc = dev->ml_priv;
 
 	if (pvc->state.active) {
 		if (dev->type == ARPHRD_ETHER) {

@@ -1111,7 +1111,7 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type)
 	dev->change_mtu = pvc_change_mtu;
 	dev->mtu = HDLC_MAX_MTU;
 	dev->tx_queue_len = 0;
-	dev->priv = pvc;
+	dev->ml_priv = pvc;
 
 	result = dev_alloc_name(dev, dev->name);
 	if (result < 0) {
include/linux/hdlc.h +1 -1
index c597696..e960faa 100644
@@ -80,7 +80,7 @@ struct net_device *alloc_hdlcdev(void *priv);
 
 static inline struct hdlc_device* dev_to_hdlc(struct net_device *dev)
 {
-	return dev->priv;
+	return netdev_priv(dev);
 }
 
 static __inline__ void debug_frame(const struct sk_buff *skb)
Signature · 1 line
1.5.3.4
maintainer
#1 lore raw
Quoted 1 line · Wang Chen

Krzysztof said that he will take this one, but not.

Actually I did. Not yet made it upstream, right :-(

Signature · 1 line
Krzysztof Halasa
author
#2 lore raw

Krzysztof Halasa said the following on 2008-11-22 8:12:

Quoted 5 lines
Quoted 1 line · Wang Chen

Krzysztof said that he will take this one, but not.

Actually I did. Not yet made it upstream, right :-(

Ooh. I am too impatience to wait you do it ;)
Any way, thank you, Krzysztof.

maintainer
#3 lore raw
Quoted 1 line · Wang Chen

Any way, thank you, Krzysztof.

Really, thank YOU for your work.

Signature · 1 line
Krzysztof Halasa
maintainer Applied
#4 lore raw
In reply to Wang Chen

From: Wang Chen <[email protected]>
Date: Fri, 21 Nov 2008 17:02:49 +0800

Quoted 9 lines

Krzysztof said that he will take this one, but not. I sent this to Dave again. :)

For killing directly reference of netdev->priv, use netdev->ml_priv to replace it. Because the private pvc data comes from add_pvc() and can't be allocated in alloc_netdev().

Signed-off-by Wang Chen <[email protected]>
Acked-by Krzysztof Halasa <[email protected]>

Applied.