Skip to contentSkip to conversation

myri10ge: fix indentation

PATCH In review Brice Goglin 2 participants 4 messages Nov 23, 2008 – Nov 24, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Brice Goglin

author
#0 lore raw

PATCH 1/1 myri10ge: fix indentation

Bring the indentation in line with the output of the Lindent script.

Signed-off-by Brice Goglin <[email protected]>
drivers/net/myri10ge/myri10ge.c +11 -11
@@ -1024,7 +1024,7 @@
 			ss->dca_tag = NULL;
 		}
 	}
-#endif				/* CONFIG_MYRI10GE_DCA */
+#endif /* CONFIG_MYRI10GE_DCA */
 
 	/* reset mcp/driver shared state back to 0 */
 

@@ -1121,7 +1121,7 @@
 		myri10ge_teardown_dca(mgp);
 	return 0;
 }
-#endif				/* CONFIG_MYRI10GE_DCA */
+#endif /* CONFIG_MYRI10GE_DCA */
 
 static inline void
 myri10ge_submit_8rx(struct mcp_kreq_ether_recv __iomem * dst,

@@ -3370,7 +3370,7 @@
 	return -EIO;
 
 }
-#endif				/* CONFIG_PM */
+#endif /* CONFIG_PM */
 
 static u32 myri10ge_read_reboot(struct myri10ge_priv *mgp)
 {

@@ -3732,14 +3732,14 @@
 }
 
 static const struct net_device_ops myri10ge_netdev_ops = {
-	.ndo_open		= myri10ge_open,
-	.ndo_stop		= myri10ge_close,
-	.ndo_start_xmit		= myri10ge_xmit,
-	.ndo_get_stats		= myri10ge_get_stats,
-	.ndo_validate_addr	= eth_validate_addr,
-	.ndo_change_mtu		= myri10ge_change_mtu,
+	.ndo_open = myri10ge_open,
+	.ndo_stop = myri10ge_close,
+	.ndo_start_xmit = myri10ge_xmit,
+	.ndo_get_stats = myri10ge_get_stats,
+	.ndo_validate_addr = eth_validate_addr,
+	.ndo_change_mtu = myri10ge_change_mtu,
 	.ndo_set_multicast_list = myri10ge_set_multicast_list,
-	.ndo_set_mac_address	= myri10ge_set_mac_address,
+	.ndo_set_mac_address = myri10ge_set_mac_address,
 };
 
 static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)

@@ -4027,7 +4027,7 @@
 	.next = NULL,
 	.priority = 0,
 };
-#endif				/* CONFIG_MYRI10GE_DCA */
+#endif /* CONFIG_MYRI10GE_DCA */
 
 static __init int myri10ge_init_module(void)
 {
drivers/net/myri10ge/myri10ge_mcp.h +1 -1
@@ -423,4 +423,4 @@
 #define MXGEFW_NETQ_FILTERTYPE_VLAN 2
 #define MXGEFW_NETQ_FILTERTYPE_VLANMACADDR 3
 
-#endif				/* __MYRI10GE_MCP_H__ */
+#endif /* __MYRI10GE_MCP_H__ */
drivers/net/myri10ge/myri10ge_mcp_gen_header.h +1 -1
diff -ur net-next-2.6/drivers/net/myri10ge/myri10ge_mcp_gen_header.h /home/bgoglin/myri10ge/myri10ge-cvs/linux/linux-tmp/drivers/net/myri10ge/myri10ge_mcp_gen_header.h
@@ -45,4 +45,4 @@
 	/* 8 */
 };
 
-#endif				/* __MYRI10GE_MCP_GEN_HEADER_H__ */
+#endif /* __MYRI10GE_MCP_GEN_HEADER_H__ */
maintainer
#1 lore raw

From: Brice Goglin <[email protected]>
Date: Sun, 23 Nov 2008 14:43:25 +0100

Quoted 3 lines

Bring the indentation in line with the output of the Lindent script.

Signed-off-by Brice Goglin <[email protected]>

Please don't blindly apply tools like this.

Quoted 8 lines

static const struct net_device_ops myri10ge_netdev_ops = {

drivers/net/myri10ge/myri10ge.c +0 -6
-	.ndo_open		= myri10ge_open,
-	.ndo_stop		= myri10ge_close,
-	.ndo_start_xmit		= myri10ge_xmit,
-	.ndo_get_stats		= myri10ge_get_stats,
-	.ndo_validate_addr	= eth_validate_addr,
-	.ndo_change_mtu		= myri10ge_change_mtu,

drivers/net/myri10ge/myri10ge.c line 3743

Quoted 10 lines
drivers/net/myri10ge/myri10ge.c +7 -1
+	.ndo_open = myri10ge_open,
+	.ndo_stop = myri10ge_close,
+	.ndo_start_xmit = myri10ge_xmit,
+	.ndo_get_stats = myri10ge_get_stats,
+	.ndo_validate_addr = eth_validate_addr,
+	.ndo_change_mtu = myri10ge_change_mtu,
 	.ndo_set_multicast_list = myri10ge_set_multicast_list,
-	.ndo_set_mac_address	= myri10ge_set_mac_address,
+	.ndo_set_mac_address = myri10ge_set_mac_address,
 };

I specifically used tabs here when applying this, on the left side of the equal sign, in order to line everything up nicely. And now this patch is undoing that.

Patch not applied.

author
#2 lore raw
Quoted 11 lines · David Miller

From: Brice Goglin <[email protected]>
Date: Sun, 23 Nov 2008 14:43:25 +0100

Quoted 4 lines

Bring the indentation in line with the output of the Lindent script.

Signed-off-by Brice Goglin <[email protected]>

Please don't blindly apply tools like this.

We apply indent because our internal CVS contains some #ifdef'ery to support old kernels and we want to cleanup the mess before submitting patches. I'll see if I can hack something here to make this struct initializer match your will.

Brice

maintainer
#3 lore raw

From: Brice Goglin <[email protected]>
Date: Mon, 24 Nov 2008 23:52:47 +0100

Quoted 3 lines

We apply indent because our internal CVS contains some #ifdef'ery to support old kernels and we want to cleanup the mess before submitting patches.

That, of course, is purely your problem not ours.