Skip to contentSkip to conversation

fs: use menuconfig to control the Misc. filesystems menu

PATCH Superseded Randy Dunlap 2 participants 3 messages Nov 25, 2008 VFS

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: use menuconfig to control the Misc. filesystems menu

Subject:   [PATCH] fs: use menuconfig to control the Misc. filesystems menu
To:        [email protected]

Cc: akpm <[email protected]>,Al Viro <[email protected]>
Bcc:
=-=-=-=-=-=-=-=-=# Don't remove this line #=-=-=-=-=-=-=-=-=-
From: Randy Dunlap <[email protected]>

Have one option to control Miscellaneous filesystems. This makes it easy to disable all of them at one time.

---

Was this already attempted? If so, was there any problem with it?

 fs/Kconfig |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)
fs/Kconfig +15 -2
@@ -758,7 +758,20 @@ config CONFIGFS_FS
 
 endmenu
 
-menu "Miscellaneous filesystems"
+menuconfig MISC_FILESYSTEMS
+	bool "Miscellaneous filesystems"
+	default y
+	---help---
+	  Say Y here to get to see options for various miscellaneous
+	  filesystems, such as filesystems that came from other
+	  operating systems.
+
+	  This option alone does not add any kernel code.
+
+	  If you say N, all options in this submenu will be skipped and
+	  disabled; if unsure, say Y here.
+
+if MISC_FILESYSTEMS
 
 config ADFS_FS
 	tristate "ADFS file system support (EXPERIMENTAL)"
@@ -1128,7 +1141,7 @@ config UFS_DEBUG
 	  Y here.  This will result in _many_ additional debugging messages to be
 	  written to the system log.
 
-endmenu
+endif # MISC_FILESYSTEMS
 
 menuconfig NETWORK_FILESYSTEMS
 	bool "Network File Systems"
#1 lore raw

fs/Kconfig config CONFIGFS_FS · line 768

Quoted 12 lines · Randy Dunlap

Have one option to control Miscellaneous filesystems. This makes it easy to disable all of them at one time.

fs/Kconfig +8 -1
-menu "Miscellaneous filesystems"
+menuconfig MISC_FILESYSTEMS
+	bool "Miscellaneous filesystems"
+	default y
+	---help---
+	  Say Y here to get to see options for various miscellaneous
+	  filesystems, such as filesystems that came from other
+	  operating systems.
+

I have no particular issue against adding this option, but the help message is misleading. The miscellaneous submenu also contains (mainly) embedded filesystems such as jffs2, cramfs, romfs and eCrypt which are native to Linux.

The help message should be changed, or perhaps these filesystems moved into a new submenu of their own.

Phillip

#2 lore raw
Quoted 20 lines · Phillip Lougher

fs/Kconfig config CONFIGFS_FS · line 768

Quoted 12 lines · Randy Dunlap

Have one option to control Miscellaneous filesystems. This makes it easy to disable all of them at one time.

fs/Kconfig +8 -1
-menu "Miscellaneous filesystems"
+menuconfig MISC_FILESYSTEMS
+    bool "Miscellaneous filesystems"
+    default y
+    ---help---
+      Say Y here to get to see options for various miscellaneous
+      filesystems, such as filesystems that came from other
+      operating systems.
+

I have no particular issue against adding this option, but the help message is misleading. The miscellaneous submenu also contains (mainly) embedded filesystems such as jffs2, cramfs, romfs and eCrypt which are native to Linux.

Quoted 4 lines

The help message should be changed, or perhaps these filesystems moved into a new submenu of their own.

Phillip

OK, I'll be glad to change the help message. (awaiting other comments)

Thanks.