Skip to contentSkip to conversation

nvidia: fix sparse warnings

PATCH New Hannes Eder 1 participant 1 message Nov 28, 2008

Subsystems (2)
Kernel janitors Framebuffer layer
lore
Share & tools
lore

Hannes Eder

author
#0 lore raw

PATCH 1/1 nvidia: fix sparse warnings

Fix this sparse warnings:

drivers/video/nvidia/nv_accel.c:304:3: warning: returning void-valued expression drivers/video/nvidia/nv_accel.c:323:3: warning: returning void-valued expression

Signed-off-by Hannes Eder <[email protected]>
---
 drivers/video/nvidia/nv_accel.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)
drivers/video/nvidia/nv_accel.c +8 -4
index fa4821c..ad6472a 100644
@@ -300,8 +300,10 @@ void nvidiafb_copyarea(struct fb_info *info, const struct fb_copyarea *region)
 	if (info->state != FBINFO_STATE_RUNNING)
 		return;
 
-	if (par->lockup)
-		return cfb_copyarea(info, region);
+	if (par->lockup) {
+		cfb_copyarea(info, region);
+		return;
+	}
 
 	NVDmaStart(info, par, BLIT_POINT_SRC, 3);
 	NVDmaNext(par, (region->sy << 16) | region->sx);

@@ -319,8 +321,10 @@ void nvidiafb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
 	if (info->state != FBINFO_STATE_RUNNING)
 		return;
 
-	if (par->lockup)
-		return cfb_fillrect(info, rect);
+	if (par->lockup) {
+		cfb_fillrect(info, rect);
+		return;
+	}
 
 	if (info->var.bits_per_pixel = 8)
 		color = rect->color;
Signature · 1 line
1.5.6.3