Skip to contentSkip to conversation

viafb: fix sparse warnings

PATCH New Hannes Eder 1 participant 1 message Nov 28, 2008

Subsystems (2)
Kernel janitors Framebuffer layer
lore
Share & tools
lore

Hannes Eder

author
#0 lore raw

PATCH 1/1 viafb: fix sparse warnings

Fix this sparse warnings:

drivers/video/via/viafbdev.c:871:3: warning: returning void-valued expression drivers/video/via/viafbdev.c:938:3: warning: returning void-valued expression drivers/video/via/viafbdev.c:995:3: warning: returning void-valued expression

Signed-off-by Hannes Eder <[email protected]>
---
 drivers/video/via/viafbdev.c |   18 ++++++++++++------
 1 files changed, 12 insertions(+), 6 deletions(-)
drivers/video/via/viafbdev.c +12 -6
index 73ac754..243fde6 100644
@@ -867,8 +867,10 @@ static void viafb_fillrect(struct fb_info *info,
 	u32 col = 0, rop = 0;
 	int pitch;
 
-	if (!viafb_accel)
-		return cfb_fillrect(info, rect);
+	if (!viafb_accel) {
+		cfb_fillrect(info, rect);
+		return;
+	}
 
 	if (!rect->width || !rect->height)
 		return;

@@ -934,8 +936,10 @@ static void viafb_copyarea(struct fb_info *info,
 
 	DEBUG_MSG(KERN_INFO "viafb_copyarea!!\n");
 
-	if (!viafb_accel)
-		return cfb_copyarea(info, area);
+	if (!viafb_accel) {
+		cfb_copyarea(info, area);
+		return;
+	}
 
 	if (!area->width || !area->height)
 		return;

@@ -991,8 +995,10 @@ static void viafb_imageblit(struct fb_info *info,
 	int i;
 	int pitch;
 
-	if (!viafb_accel)
-		return cfb_imageblit(info, image);
+	if (!viafb_accel) {
+		cfb_imageblit(info, image);
+		return;
+	}
 
 	udata = (u32 *) image->data;
Signature · 1 line
1.5.6.3