Char: n_tty, include module.h
PATCH 1/1 Char: n_tty, include module.h
Since we are using EXPORT_SYMBOL, we should include linux/module.h
--- drivers/char/n_tty.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/char/n_tty.c +1 -0
@@ -41,6 +41,7 @@#include <linux/timer.h> #include <linux/ctype.h> #include <linux/mm.h> +#include <linux/module.h> #include <linux/string.h> #include <linux/slab.h> #include <linux/poll.h>
Signature · 1 line
1.6.0.4
Alan Cox
NAKQuoted 3 lines · On Wed, 3 Dec 2008 13:28:58 +0100 Jiri Slaby <[email protected]> wrote:
Since we are using
EXPORT_SYMBOL, we should includelinux/module.hSigned-off-by Jiri Slaby <[email protected]>
NAK
n_tty doesn't use EXPORT_SYMBOL.
Alan
Quoted 10 lines · Alan Cox
Quoted 3 lines · On Wed, 3 Dec 2008 13:28:58 +0100 Jiri Slaby <[email protected]> wrote:
Since we are using
EXPORT_SYMBOL, we should includelinux/module.hSigned-off-by Jiri Slaby <[email protected]>NAK
n_ttydoesn't useEXPORT_SYMBOL.
Sure it does. Maybe the patch didn't come to you yet. Will repost to akpm as a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.
$ grep EXPORT drivers/char/n_tty.c EXPORT_SYMBOL_GPL(n_tty_flush_buffer); EXPORT_SYMBOL_GPL(n_tty_chars_in_buffer); EXPORT_SYMBOL_GPL(n_tty_write_wakeup); EXPORT_SYMBOL_GPL(n_tty_receive_buf); EXPORT_SYMBOL_GPL(n_tty_set_termios); EXPORT_SYMBOL_GPL(n_tty_close); EXPORT_SYMBOL_GPL(n_tty_open); EXPORT_SYMBOL_GPL(n_tty_read); EXPORT_SYMBOL_GPL(n_tty_write); EXPORT_SYMBOL_GPL(n_tty_poll);
Quoted 6 lines · On Wed, 03 Dec 2008 16:17:52 +0100 Jiri Slaby <[email protected]> wrote:
Quoted 5 lines · Alan Cox
Quoted 2 lines · On Wed, 3 Dec 2008 13:28:58 +0100 Jiri Slaby <[email protected]> wrote:
Since we are using
EXPORT_SYMBOL, we should includelinux/module.h
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Jiri Slaby <[email protected]>NAK
n_ttydoesn't useEXPORT_SYMBOL.Sure it does. Maybe the patch didn't come to you yet. Will repost to akpm as a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix
And that patch isn't going in either. Ask Andrew to drop it instead. If the rest of the PPS stuff goes in then I'll redo that part of the n_tty stuff differently and cleanly.
Alan
Alan Cox napsal(a):
Quoted 12 lines
Quoted 9 lines · On Wed, 03 Dec 2008 16:17:52 +0100 Jiri Slaby <[email protected]> wrote:
Quoted 8 lines · Alan Cox
Quoted 3 lines · On Wed, 3 Dec 2008 13:28:58 +0100 Jiri Slaby <[email protected]> wrote:
Since we are using
EXPORT_SYMBOL, we should includelinux/module.hSigned-off-by Jiri Slaby <[email protected]>NAK
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
n_ttydoesn't useEXPORT_SYMBOL.Sure it does. Maybe the patch didn't come to you yet. Will repost to akpm as a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix
And that patch isn't going in either. Ask Andrew to drop it instead. If the rest of the PPS stuff goes in then I'll redo that part of the
n_ttystuff differently and cleanly.
Fair enough. Andrew, could you?