Skip to contentSkip to conversation

x86: make an error message more precise

PATCH New Jan Beulich 1 participant 1 message Dec 5, 2008

lore
Share & tools
lore

Jan Beulich

author
#0 lore raw

PATCH 1/1 x86: make an error message more precise

... allowing to distinguish whether the to be added or the already existing PIRQ binding is causing the failure.

Signed-off-by Jan Beulich <[email protected]>
xen/arch/x86/irq.c +5 -3
Index: 2008-11-20/xen/arch/x86/irq.c
===================================================================
@@ -623,9 +623,11 @@ int pirq_guest_bind(struct vcpu *v, int 
     }
     else if ( !will_share || !action->shareable )
     {
-        gdprintk(XENLOG_INFO, "Cannot bind IRQ %d to guest. "
-               "Will not share with others.\n",
-                irq);
+        gdprintk(XENLOG_INFO, "Cannot bind IRQ %d to guest. %s\n.",
+                 irq,
+                 will_share ?
+                 "Others do not share" :
+                 "Will not share with others");
         rc = -EBUSY;
         goto unlock_out;
     }