Skip to contentSkip to conversation

kvm-userspace: Fix -no-kvm-irqchip

PATCH Applied Jan Kiszka 2 participants 2 messages Dec 5, 2008 – Dec 7, 2008 KVM

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 kvm-userspace: Fix -no-kvm-irqchip

Commit fc94d163d1e3424199166cf50449e03447400579 broke -no-kvm-irqchip. This fixes the issue by restoring the logic of kvm_update_interrupt_request /wrt IRQ injection from the IO thread.

[However, I did not yet get the need for all the additional tests in that function.]

---

 qemu/qemu-kvm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
qemu/qemu-kvm.c +1 -1
index a7cfa24..9ca8da4 100644
@@ -117,7 +117,7 @@ void kvm_update_interrupt_request(CPUState *env)
     int signal = 0;
 
     if (env) {
-        if (current_env && !current_env->kvm_cpu_state.created)
+        if (!current_env || !current_env->kvm_cpu_state.created)
             signal = 1;
         /*
          * Testing for created here is really redundant
Applied
#1 lore raw
Quoted 5 lines · Jan Kiszka

Commit fc94d163d1e3424199166cf50449e03447400579 broke -no-kvm-irqchip. This fixes the issue by restoring the logic of kvm_update_interrupt_request /wrt IRQ injection from the IO thread.

Applied, thanks.

Quoted 3 lines

[However, I did not yet get the need for all the additional tests in that function.]

Neither does the comment in that function...

Signature · 1 line
error compiling committee.c: too many arguments to function