Skip to contentSkip to conversation

Fix memory-mapped i8042 on MIPS Magnum

PATCH RESEND In review Hervé Poussineau 2 participants 2 messages Dec 7, 2008 – Dec 8, 2008

lore
Share & tools
lore

Hervé Poussineau

author
#0 lore raw

PATCH RESEND 1/1 Fix memory-mapped i8042 on MIPS Magnum

Hi,

Current implementation of memory-mapped i8042 controller is atm implemented with an interface shift (it_shift) parameter, like most all memory-mapped devices in Qemu. However, this isn't suitable for MIPS Magnum, where i8042 controller is at 0x80005000 up to 0x80005fff.

Thomas Bogendoerfer (from #mipslinux) tested the behaviour of a real machine, and found that odd addresses are for status/command register, and even addresses for data register.

Attached patch implements this behaviour by replacing the it_shift parameter by a mask one. Incidentally, keyboard now works on OpenBSD 2.3, which accesses i8042 controller at 0x80005060 and 0x80005061.

Signed-off-by Hervé Poussineau <[email protected]>

Changes since v1:
- updated to qemu svn

Hervé

mips_jazz.c +1 -1
Index: hw/mips_jazz.c
===================================================================
@@ -229,7 +229,7 @@
     cpu_register_physical_memory(0x80004000, 0x00001000, s_rtc);
 
     /* Keyboard (i8042) */
-    i8042_mm_init(rc4030[6], rc4030[7], 0x80005000, 0);
+    i8042_mm_init(rc4030[6], rc4030[7], 0x80005000, 0x1000, 0x1);
 
     /* Serial ports */
     if (serial_hds[0])
pc.h +1 -1
Index: hw/pc.h
===================================================================
@@ -71,7 +71,7 @@
 
 void i8042_init(qemu_irq kbd_irq, qemu_irq mouse_irq, uint32_t io_base);
 void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq,
-                   target_phys_addr_t base, int it_shift);
+                   target_phys_addr_t base, ram_addr_t size, ram_addr_t mask);
 
 /* mc146818rtc.c */
pckbd.c +10 -18
Index: hw/pckbd.c
===================================================================
@@ -125,7 +125,7 @@
 
     qemu_irq irq_kbd;
     qemu_irq irq_mouse;
-    int it_shift;
+    ram_addr_t mask;
 } KBDState;
 
 static KBDState kbd_state;

@@ -391,28 +391,20 @@
 {
     KBDState *s = opaque;
 
-    switch (addr >> s->it_shift) {
-    case 0:
-        return kbd_read_data(s, 0) & 0xff;
-    case 1:
+    if (addr & s->mask)
         return kbd_read_status(s, 0) & 0xff;
-    default:
-        return 0xff;
-    }
+    else
+        return kbd_read_data(s, 0) & 0xff;
 }
 
 static void kbd_mm_writeb (void *opaque, target_phys_addr_t addr, uint32_t value)
 {
     KBDState *s = opaque;
 
-    switch (addr >> s->it_shift) {
-    case 0:
-        kbd_write_data(s, 0, value & 0xff);
-        break;
-    case 1:
+    if (addr & s->mask)
         kbd_write_command(s, 0, value & 0xff);
-        break;
-    }
+    else
+        kbd_write_data(s, 0, value & 0xff);
 }
 
 static CPUReadMemoryFunc *kbd_mm_read[] = {

@@ -428,19 +420,19 @@
 };
 
 void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq,
-                   target_phys_addr_t base, int it_shift)
+                   target_phys_addr_t base, ram_addr_t size, ram_addr_t mask)
 {
     KBDState *s = &kbd_state;
     int s_io_memory;
 
     s->irq_kbd = kbd_irq;
     s->irq_mouse = mouse_irq;
-    s->it_shift = it_shift;
+    s->mask = mask;
 
     kbd_reset(s);
     register_savevm("pckbd", 0, 3, kbd_save, kbd_load, s);
     s_io_memory = cpu_register_io_memory(0, kbd_mm_read, kbd_mm_write, s);
-    cpu_register_physical_memory(base, 2 << it_shift, s_io_memory);
+    cpu_register_physical_memory(base, size, s_io_memory);
 
     s->kbd = ps2_kbd_init(kbd_update_kbd_irq, s);
     s->mouse = ps2_mouse_init(kbd_update_aux_irq, s);
#1 lore raw
Quoted 1 line · Hervé Poussineau

Hi,

Hi!

Quoted 15 lines

Current implementation of memory-mapped i8042 controller is atm implemented with an interface shift (it_shift) parameter, like most all memory-mapped devices in Qemu.
However, this isn't suitable for MIPS Magnum, where i8042 controller is at 0x80005000 up to 0x80005fff.

Thomas Bogendoerfer (from #mipslinux) tested the behaviour of a real machine, and found that odd addresses are for status/command register, and even addresses for data register.

Attached patch implements this behaviour by replacing the it_shift parameter by a mask one.
Incidentally, keyboard now works on OpenBSD 2.3, which accesses i8042 controller at 0x80005060 and 0x80005061.

Quoted 4 lines
Signed-off-by Hervé Poussineau <[email protected]>

Changes since v1:
- updated to qemu svn

It looks basically ok, except that the size and the address should be of type target_phys_addr_t instead of ram_addr_t.

Aurelien

Signature · 4 lines
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   [email protected]         | [email protected]
   `-    people.debian.org/~aurel32 | www.aurel32.net