Skip to contentSkip to conversation

hso modem port detection fix patch

PATCH In review Denis Joseph Barrow 2 participants 2 messages Dec 8, 2008 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 3/3 hso modem port detection fix patch

This patch will clash with the previously posted. [PATCH 1/3] hso modem signals patch fix & should only be applied if the hso modem signals patch fix patch is not applied.

Fixed incorrect check for the modem port,

---

drivers/net/usb/hso.c +1 -1
Index: netdev-2.6/drivers/net/usb/hso.c
===================================================================
@@ -2343,7 +2343,7 @@
 	serial->parent = hso_dev;
 	hso_dev->port_data.dev_serial = serial;
 
-	if (port & HSO_PORT_MODEM)
+	if ((port & HSO_PORT_MASK) == HSO_PORT_MODEM)
 		num_urbs = 2;
 	else
 		num_urbs = 1;
Signature · 2 lines
best regards,
D.J. Barrow

Fixed incorrect check for the modem port,

---

drivers/net/usb/hso.c +1 -1
Index: netdev-2.6/drivers/net/usb/hso.c
===================================================================
@@ -2343,7 +2343,7 @@
 	serial->parent = hso_dev;
 	hso_dev->port_data.dev_serial = serial;
 
-	if (port & HSO_PORT_MODEM)
+	if ((port & HSO_PORT_MASK) == HSO_PORT_MODEM)
 		num_urbs = 2;
 	else
 		num_urbs = 1;

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

From: Denis Joseph Barrow <[email protected]>
Date: Mon, 08 Dec 2008 11:44:57 +0100

Again, please CC: Alan for changes that might even remotely be TTY layer related and thus he'd be interested in reviewing.

Thanks.

Quoted 27 lines

This patch will clash with the previously posted. [PATCH 1/3] hso modem signals patch fix & should only be applied if the hso modem signals patch fix patch is not applied.

Fixed incorrect check for the modem port,

---
Index: netdev-2.6/drivers/net/usb/hso.c
===================================================================

drivers/net/usb/hso.c +1 -1
@@ -2343,7 +2343,7 @@
 	serial->parent = hso_dev;
 	hso_dev->port_data.dev_serial = serial;
 
-	if (port & HSO_PORT_MODEM)
+	if ((port & HSO_PORT_MASK) == HSO_PORT_MODEM)
 		num_urbs = 2;
 	else
 		num_urbs = 1;
Signature · 3 lines
-- 
best regards,
D.J. Barrow

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html