Standard rules for AoE devices.

PATCH Applied Ryan Thomas 3 participants 8 messages Dec 9, 2008

Share & tools

Ryan Thomas

author

2008-12-09 00:10 UTC #0 lore raw

PATCH 1/1 Standard rules for AoE devices.

In the interest of standardizing udev rules, please consider the following patch that adds udev rules for the ATA over Ethernet character and block devices. The aoe module has been a long-time member of the kernel and needs inclusion in the standard udev rules.

Thanks,
Ryan Thomas

---
  rules/packages/40-aoe.rules |    9 +++++++++
  1 files changed, 9 insertions(+), 0 deletions(-)

create mode 100644 rules/packages/40-aoe.rules

rules/packages/40-aoe.rules new file +2 -0

new file mode 100644
index 0000000..38c0e00
@@ -0,0 +1,9 @@
+# aoe char devices
+SUBSYSTEM="aoe", KERNEL="discover",   NAME="etherd/%k", GROUP="disk",

MODE="0220"
+SUBSYSTEM="aoe", KERNEL="err", NAME="etherd/%k", GROUP="disk",
MODE="0440"
+SUBSYSTEM="aoe", KERNEL="interfaces", NAME="etherd/%k", GROUP="disk", MODE="0220"
+SUBSYSTEM="aoe", KERNEL="revalidate", NAME="etherd/%k", GROUP="disk", MODE="0220"
+SUBSYSTEM="aoe", KERNEL="flush", NAME="etherd/%k", GROUP="disk",
MODE="0220"
+
+# aoe block devices
+SUBSYSTEM="aoe", KERNEL="etherd*", NAME="%k", GROUP="disk"

Signature · 1 line

1.5.6.5

Kay Sievers

Applied

2008-12-09 00:36 UTC #1 lore raw

Quoted 4 lines · Ryan Thomas

In the interest of standardizing udev rules, please consider the following patch that adds udev rules for the ATA over Ethernet character and block devices. The aoe module has been a long-time member of the kernel and needs inclusion in the standard udev rules.

Applied.

Thanks,
Kay

Marco d'Itri

2008-12-09 00:49 UTC #2 lore raw

In reply to Ryan Thomas

Quoted 4 lines · Ryan Thomas

In the interest of standardizing udev rules, please consider the following patch that adds udev rules for the ATA over Ethernet character and block devices. The aoe module has been a long-time member of the kernel and needs inclusion in the standard udev rules.

Debian so far has used these rules which are more generic and much simpler. Are they incorrect in some way?

# AOE character devices
SUBSYSTEM="aoe", NAME="etherd/%k"

SUBSYSTEM="aoe", MODE="0220", GROUP="disk"
SUBSYSTEM="aoe", KERNEL="err", MODE="0440", GROUP="disk"

Signature · 2 lines

ciao,
Marco

Kay Sievers

2008-12-09 01:01 UTC #3 lore raw

In reply to Ryan Thomas

Quoted 7 lines · Marco d'Itri

Quoted 4 lines · Ryan Thomas
In the interest of standardizing udev rules, please consider the following patch that adds udev rules for the ATA over Ethernet character and block devices. The aoe module has been a long-time member of the kernel and needs inclusion in the standard udev rules.

Quoted 8 lines

Debian so far has used these rules which are more generic and much simpler. Are they incorrect in some way?
# AOE character devices
SUBSYSTEM="aoe", NAME="etherd/%k"
SUBSYSTEM="aoe", MODE="0220", GROUP="disk"
SUBSYSTEM="aoe", KERNEL="err", MODE="0440", GROUP="disk"

That looks fine.

I wonder why we have this comment:
+# aoe block devices
+SUBSYSTEM="aoe", KERNEL="etherd*", NAME="%k", GROUP="disk"

They can not be block devices if they have SUBSYSTEM="aoe". Do the etherd* devices belong into the subdir or not?

We have:
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk"
in the current default rules.

I guess doing:
# ATA over Ethernet
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk", MODE="0220" SUBSYSTEM="aoe", KERNEL="err", MODE="0440"
would be all we need.

Kay

Ryan Thomas

author

2008-12-09 03:07 UTC #4 lore raw

In reply to Ryan Thomas

Quoted 29 lines · Kay Sievers

Quoted 6 lines · Marco d'Itri
Quoted 4 lines · Ryan Thomas
In the interest of standardizing udev rules, please consider the following patch that adds udev rules for the ATA over Ethernet character and block devices. The aoe module has been a long-time member of the kernel and needs inclusion in the standard udev rules.
Quoted 8 lines
Debian so far has used these rules which are more generic and much simpler. Are they incorrect in some way?
# AOE character devices
SUBSYSTEM="aoe", NAME="etherd/%k"
SUBSYSTEM="aoe", MODE="0220", GROUP="disk"
SUBSYSTEM="aoe", KERNEL="err", MODE="0440", GROUP="disk"
That looks fine.
I wonder why we have this comment:
+# aoe block devices
+SUBSYSTEM="aoe", KERNEL="etherd*", NAME="%k", GROUP="disk"
They can not be block devices if they have SUBSYSTEM="aoe". Do the etherd* devices belong into the subdir or not?
We have:
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk"
in the current default rules.

Quoted 8 lines

I guess doing:
# ATA over Ethernet
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk", MODE="0220" SUBSYSTEM="aoe", KERNEL="err", MODE="0440"
would be all we need.
Kay

My previous patch should be backed out as you are right that it's not needed.

A patch to the default rules to correct the mode on the etherd/err character device is all that is needed.

Thanks for the help straightening this (and me) out. Ryan

---
  rules/rules.d/50-udev-default.rules |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

(quoted diff) +0 -0

b/rules/rules.d/50-udev-default.rules
index 2743dcb..0f27982 100644

rules/rules.d/50-udev-default.rules +1 -1

@@ -87,7 +87,7 @@ KERNEL="pktcdvd[0-9]*",      NAME="pktcdvd/%k"
  KERNEL="pktcdvd",             NAME="pktcdvd/control"
  KERNEL="qft0",                        SYMLINK+="ftape"
  SUBSYSTEM="bsg",              NAME="bsg/%k"
-SUBSYSTEM="aoe",              NAME="etherd/%k", GROUP="disk"
+SUBSYSTEM="aoe",              NAME="etherd/%k", GROUP="disk", MODE="0220"
  SUBSYSTEM="aoe", KERNEL="err", MODE="0440"
 
  # network

Signature · 1 line

1.5.6.5

Kay Sievers

Applied

2008-12-09 03:23 UTC #5 lore raw

In reply to Ryan Thomas

Quoted 37 lines · Ryan Thomas

Quoted 30 lines · Kay Sievers
Quoted 7 lines · Marco d'Itri
Quoted 4 lines · Ryan Thomas
In the interest of standardizing udev rules, please consider the following patch that adds udev rules for the ATA over Ethernet character and block devices. The aoe module has been a long-time member of the kernel and needs inclusion in the standard udev rules.
Quoted 8 lines
Debian so far has used these rules which are more generic and much simpler. Are they incorrect in some way?
# AOE character devices
SUBSYSTEM="aoe", NAME="etherd/%k"
SUBSYSTEM="aoe", MODE="0220", GROUP="disk"
SUBSYSTEM="aoe", KERNEL="err", MODE="0440", GROUP="disk"
That looks fine.
I wonder why we have this comment:
+# aoe block devices
+SUBSYSTEM="aoe", KERNEL="etherd*", NAME="%k", GROUP="disk"
They can not be block devices if they have SUBSYSTEM="aoe". Do the etherd* devices belong into the subdir or not?
We have:
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk"
in the current default rules.
Quoted 5 lines
I guess doing:
# ATA over Ethernet
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk", MODE="0220" SUBSYSTEM="aoe", KERNEL="err", MODE="0440"
would be all we need.

Quoted 5 lines

My previous patch should be backed out as you are right that it's not needed.
A patch to the default rules to correct the mode on the etherd/err character device is all that is needed.

Applied. Please check:
http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h/c635fb67dbd509f4ee532c8bf0d3885cc71989

The block device are never moved to the subdir, they all just stay in /dev, right?

Thanks,
Kay

Ryan Thomas

author

2008-12-09 11:23 UTC #6 lore raw

In reply to Ryan Thomas

Quoted 39 lines · Kay Sievers

Quoted 38 lines · Ryan Thomas
Quoted 28 lines · Kay Sievers
Quoted 6 lines · Marco d'Itri
Quoted 4 lines · Ryan Thomas
In the interest of standardizing udev rules, please consider the following patch that adds udev rules for the ATA over Ethernet character and block devices. The aoe module has been a long-time member of the kernel and needs inclusion in the standard udev rules.
Quoted 8 lines
Debian so far has used these rules which are more generic and much simpler. Are they incorrect in some way?
# AOE character devices
SUBSYSTEM="aoe", NAME="etherd/%k"
SUBSYSTEM="aoe", MODE="0220", GROUP="disk"
SUBSYSTEM="aoe", KERNEL="err", MODE="0440", GROUP="disk"
That looks fine.
I wonder why we have this comment:
+# aoe block devices
+SUBSYSTEM="aoe", KERNEL="etherd*", NAME="%k", GROUP="disk"
They can not be block devices if they have SUBSYSTEM="aoe". Do the etherd* devices belong into the subdir or not?
We have:
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk"
in the current default rules.
Quoted 5 lines
I guess doing:
# ATA over Ethernet
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk", MODE="0220" SUBSYSTEM="aoe", KERNEL="err", MODE="0440"
would be all we need.
My previous patch should be backed out as you are right that it's not needed.

Quoted 9 lines

Quoted 2 lines
A patch to the default rules to correct the mode on the etherd/err character device is all that is needed.
Applied. Please check:
http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h/c635fb67dbd509f4ee532c8bf0d3885cc71989
The block device are never moved to the subdir, they all just stay in /dev, right?

The block device does go in the subdir. The kernel name for the block device is "etherd!eX.Y" which means that the subdir is automatically taken care of.

Ryan

Kay Sievers

2008-12-09 16:17 UTC #7 lore raw

In reply to Ryan Thomas

Quoted 49 lines · Ryan Thomas

Quoted 48 lines · Kay Sievers
Quoted 38 lines · Ryan Thomas
Quoted 31 lines · Kay Sievers
Quoted 8 lines · Marco d'Itri
Quoted 5 lines · Ryan Thomas
In the interest of standardizing udev rules, please consider the following patch that adds udev rules for the ATA over Ethernet character
and block devices. The aoe module has been a long-time member of the kernel and needs inclusion in the standard udev rules.
Quoted 8 lines
Debian so far has used these rules which are more generic and much simpler. Are they incorrect in some way?
# AOE character devices
SUBSYSTEM="aoe", NAME="etherd/%k"
SUBSYSTEM="aoe", MODE="0220", GROUP="disk"
SUBSYSTEM="aoe", KERNEL="err", MODE="0440", GROUP="disk"
That looks fine.
I wonder why we have this comment:
+# aoe block devices
+SUBSYSTEM="aoe", KERNEL="etherd*", NAME="%k", GROUP="disk"
They can not be block devices if they have SUBSYSTEM="aoe". Do the etherd* devices belong into the subdir or not?
We have:
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk"
in the current default rules.
Quoted 5 lines
I guess doing:
# ATA over Ethernet
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk", MODE="0220" SUBSYSTEM="aoe", KERNEL="err", MODE="0440"
would be all we need.
Quoted 6 lines
My previous patch should be backed out as you are right that it's not needed.
A patch to the default rules to correct the mode on the etherd/err character
device is all that is needed.
Applied. Please check:

Quoted 8 lines

Quoted 4 lines
http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h/c635fb67dbd509f4ee532c8bf0d3885cc71989
The block device are never moved to the subdir, they all just stay in /dev, right?
The block device does go in the subdir. The kernel name for the block device is "etherd!eX.Y" which means that the subdir is automatically taken care of.

Ah, nice, so it should be fine.

The char devices should have done just the same '!' thing, then no rule, besides the permissions would be needed. :)

Thanks,
Kay