ipv6:fix the return interface index when get it while no message is received
Subsystems (3)
RFC PATCH 2/3 ipv6:fix the return interface index when get it while no message is received
When get receiving interface index while no message is received, the the value seted with setsockopt() should be returned.
RFC 3542:
Issuing getsockopt() for the above options will return the sticky option value i.e., the value set with setsockopt(). If no sticky option value has been set getsockopt() will return the following values:
- For the IPV6_PKTINFO option, it will return an in6_pktinfo structure with ipi6_addr being in6addr_any and ipi6_ifindex being zero.
--- net/ipv6/ipv6_sockglue.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
net/ipv6/ipv6_sockglue.c +4 -4
@@ -938,8 +938,8 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname, }else {if (np->rxopt.bits.rxinfo) {struct in6_pktinfo src_info; - src_info.ipi6_ifindex = np->mcast_oif ? np->mcast_oif : sk->sk_bound_dev_if; -ipv6_addr_copy (&src_info.ipi6_addr, &np->daddr); + src_info.ipi6_ifindex = np->sticky_pktinfo.ipi6_ifindex; +ipv6_addr_copy (&src_info.ipi6_addr, &(np->sticky_pktinfo.ipi6_addr));put_cmsg (&msg,SOL_IPV6 ,IPV6_PKTINFO ,sizeof (src_info), &src_info); }if (np->rxopt.bits.rxhlim) {
@@ -948,8 +948,8 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname, }if (np->rxopt.bits.rxoinfo) {struct in6_pktinfo src_info; - src_info.ipi6_ifindex = np->mcast_oif ? np->mcast_oif : sk->sk_bound_dev_if; -ipv6_addr_copy (&src_info.ipi6_addr, &np->daddr); + src_info.ipi6_ifindex = np->sticky_pktinfo.ipi6_ifindex; +ipv6_addr_copy (&src_info.ipi6_addr, &(np->sticky_pktinfo.ipi6_addr));put_cmsg (&msg,SOL_IPV6 ,IPV6_2292PKTINFO ,sizeof (src_info), &src_info); }if (np->rxopt.bits.rxohlim) {
Signature · 1 line
1.6.0.1
Quoted 34 lines · Yang Hongyang
When get receiving interface index while no message is received, the the value seted with
setsockopt()should be returned.RFC 3542:
Issuinggetsockopt()for the above options will return the sticky option value i.e., the value set withsetsockopt(). If no sticky option value has been setgetsockopt()will return the following values:- For the
IPV6_PKTINFOoption, it will return anin6_pktinfostructure withipi6_addrbeingin6addr_anyandipi6_ifindexbeing zero.Signed-off-by Yang Hongyang<[email protected]>--- net/ipv6/ipv6_sockglue.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)net/ipv6/ipv6_sockglue.c +2
-2@@ -938,8 +938,8 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname, }else {if (np->rxopt.bits.rxinfo) {struct in6_pktinfo src_info; - src_info.ipi6_ifindex = np->mcast_oif ? np->mcast_oif : sk->sk_bound_dev_if; -ipv6_addr_copy (&src_info.ipi6_addr, &np->daddr); + src_info.ipi6_ifindex = np->sticky_pktinfo.ipi6_ifindex; +ipv6_addr_copy (&src_info.ipi6_addr, &(np->sticky_pktinfo.ipi6_addr));put_cmsg (&msg,SOL_IPV6 ,IPV6_PKTINFO ,sizeof (src_info), &src_info); }if (np->rxopt.bits.rxhlim) {
net/ipv6/ipv6_sockglue.c static int do_ipv6_getsockopt(struct sock *sk, int level, int optname, · line 955
Quoted 10 lines
net/ipv6/ipv6_sockglue.c +2
-2@@ -948,8 +948,8 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname, }if (np->rxopt.bits.rxoinfo) {struct in6_pktinfo src_info; - src_info.ipi6_ifindex = np->mcast_oif ? np->mcast_oif : sk->sk_bound_dev_if; -ipv6_addr_copy (&src_info.ipi6_addr, &np->daddr); + src_info.ipi6_ifindex = np->sticky_pktinfo.ipi6_ifindex; +ipv6_addr_copy (&src_info.ipi6_addr, &(np->sticky_pktinfo.ipi6_addr));put_cmsg (&msg,SOL_IPV6 ,IPV6_2292PKTINFO ,sizeof (src_info), &src_info); }if (np->rxopt.bits.rxohlim) {
Updated patch:
When get receiving interface index while no message is received, the the value seted with setsockopt() should be returned.
RFC 3542:
Issuing getsockopt() for the above options will return the sticky option value i.e., the value set with setsockopt(). If no sticky option value has been set getsockopt() will return the following values:
- For the IPV6_PKTINFO option, it will return an in6_pktinfo structure with ipi6_addr being in6addr_any and ipi6_ifindex being zero.
--- net/ipv6/ipv6_sockglue.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-)
net/ipv6/ipv6_sockglue.c +8 -4
@@ -938,8 +938,10 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname, }else {if (np->rxopt.bits.rxinfo) {struct in6_pktinfo src_info; - src_info.ipi6_ifindex = np->mcast_oif ? np->mcast_oif : sk->sk_bound_dev_if; -ipv6_addr_copy (&src_info.ipi6_addr, &np->daddr); + src_info.ipi6_ifindex = np->mcast_oif ? np->mcast_oif : + np->sticky_pktinfo.ipi6_ifindex; + np->mcast_oif?ipv6_addr_copy (&src_info.ipi6_addr, &np->daddr) : +ipv6_addr_copy (&src_info.ipi6_addr, &(np->sticky_pktinfo.ipi6_addr));put_cmsg (&msg,SOL_IPV6 ,IPV6_PKTINFO ,sizeof (src_info), &src_info); }if (np->rxopt.bits.rxhlim) {
@@ -948,8 +950,10 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname, }if (np->rxopt.bits.rxoinfo) {struct in6_pktinfo src_info; - src_info.ipi6_ifindex = np->mcast_oif ? np->mcast_oif : sk->sk_bound_dev_if; -ipv6_addr_copy (&src_info.ipi6_addr, &np->daddr); + src_info.ipi6_ifindex = np->mcast_oif ? np->mcast_oif : + np->sticky_pktinfo.ipi6_ifindex; + np->mcast_oif?ipv6_addr_copy (&src_info.ipi6_addr, &np->daddr) : +ipv6_addr_copy (&src_info.ipi6_addr, &(np->sticky_pktinfo.ipi6_addr));put_cmsg (&msg,SOL_IPV6 ,IPV6_2292PKTINFO ,sizeof (src_info), &src_info); }if (np->rxopt.bits.rxohlim) {
Signature · 1 line
1.6.0.1
David Miller
maintainerFrom: Yang Hongyang <[email protected]>
Date: Mon, 15 Dec 2008 17:05:54 +0800
Quoted 1 line
Updated patch:
Thanks Yang. I'm still reviewing this and deciding if I will apply the latest version of your patches.
Thanks in advance for your patience.
Quoted 11 lines · David Miller
From: Yang Hongyang <[email protected]>
Date: Mon, 15 Dec 2008 17:05:54 +0800Quoted 1 line
Updated patch:
Thanks Yang. I'm still reviewing this and deciding if I will apply the latest version of your patches.
Thanks in advance for your patience.
Thanks Dave,I'm patiently waiting for your response.^_^
From: Yang Hongyang <[email protected]>
Date: Mon, 15 Dec 2008 17:05:54 +0800
Quoted 4 lines
Updated patch:
When get receiving interface index while no message is received, the the value seted with
setsockopt()should be returned.
...
Quoted 1 line
Signed-off-by Yang Hongyang<[email protected]>
Applied.